[INFO] updating cached repository sjsyrek/cormen-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sjsyrek/cormen-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sjsyrek/cormen-rust" "work/ex/clippy-test-run/sources/stable/gh/sjsyrek/cormen-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sjsyrek/cormen-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sjsyrek/cormen-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sjsyrek/cormen-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sjsyrek/cormen-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5d48e3c79004cd805bba4e3ec5c971b1448de5f9
[INFO] sha for GitHub repo sjsyrek/cormen-rust: 5d48e3c79004cd805bba4e3ec5c971b1448de5f9
[INFO] validating manifest of sjsyrek/cormen-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sjsyrek/cormen-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sjsyrek/cormen-rust
[INFO] finished frobbing sjsyrek/cormen-rust
[INFO] frobbed toml for sjsyrek/cormen-rust written to work/ex/clippy-test-run/sources/stable/gh/sjsyrek/cormen-rust/Cargo.toml
[INFO] started frobbing sjsyrek/cormen-rust
[INFO] finished frobbing sjsyrek/cormen-rust
[INFO] frobbed toml for sjsyrek/cormen-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sjsyrek/cormen-rust/Cargo.toml
[INFO] crate sjsyrek/cormen-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sjsyrek/cormen-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sjsyrek/cormen-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] ecec3f9cc79218e3b8561b4412b8d5f3393caffe7474384d2b060f27bb254ca1
[INFO] running `"docker" "start" "-a" "ecec3f9cc79218e3b8561b4412b8d5f3393caffe7474384d2b060f27bb254ca1"`
[INFO] [stderr]     Checking cormen_rust v0.2.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/sorts/merge_sort.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let mut i = 0;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/sorts/merge_sort.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |     let mut j = 0;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/sorts/merge_sort.rs:24:13
[INFO] [stderr]    |
[INFO] [stderr] 24 |     let mut i = 0;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/sorts/merge_sort.rs:25:13
[INFO] [stderr]    |
[INFO] [stderr] 25 |     let mut j = 0;
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/sorts/merge_sort.rs:14:40
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let mut left: Vec<isize> = vec![0; (n1 + 1)];
[INFO] [stderr]    |                                        ^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/sorts/merge_sort.rs:15:41
[INFO] [stderr]    |
[INFO] [stderr] 15 |     let mut right: Vec<isize> = vec![0; (n2 + 1)];
[INFO] [stderr]    |                                         ^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:11:22
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn vec_to_str(v: &Vec<isize>) -> String {
[INFO] [stderr]    |                      ^^^^^^^^^^^ help: change this to: `&[isize]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/sorts/insertion_sort.rs:18:13
[INFO] [stderr]    |
[INFO] [stderr] 18 |             i = i - 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: replace it with: `i -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `a` manually
[INFO] [stderr]   --> src/sorts/selection_sort.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 | /         let temp = a[j];
[INFO] [stderr] 21 | |         a[j] = a[smallest];
[INFO] [stderr] 22 | |         a[smallest] = temp;
[INFO] [stderr]    | |__________________________^ help: try: `a.swap(j, smallest)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/sorts/merge_sort.rs:14:40
[INFO] [stderr]    |
[INFO] [stderr] 14 |     let mut left: Vec<isize> = vec![0; (n1 + 1)];
[INFO] [stderr]    |                                        ^^^^^^^^ help: remove these parentheses
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_parens)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unnecessary parentheses around function argument
[INFO] [stderr]   --> src/sorts/merge_sort.rs:15:41
[INFO] [stderr]    |
[INFO] [stderr] 15 |     let mut right: Vec<isize> = vec![0; (n2 + 1)];
[INFO] [stderr]    |                                         ^^^^^^^^ help: remove these parentheses
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/sorts/merge_sort.rs:16:14
[INFO] [stderr]    |
[INFO] [stderr] 16 |     for i in 0..n1 {
[INFO] [stderr]    |              ^^^^^ help: try replacing the loop by: `left[..n1].clone_from_slice(&a[p..(n1 + p)])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/sorts/merge_sort.rs:19:14
[INFO] [stderr]    |
[INFO] [stderr] 19 |     for j in 0..n2 {
[INFO] [stderr]    |              ^^^^^ help: try replacing the loop by: `right[..n2].clone_from_slice(&a[q..(n2 + q)])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `k` is only used to index `a`.
[INFO] [stderr]   --> src/sorts/merge_sort.rs:26:14
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for k in p..r {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for <item> in a.iter_mut().take(r).skip(p) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils.rs:11:22
[INFO] [stderr]    |
[INFO] [stderr] 11 | pub fn vec_to_str(v: &Vec<isize>) -> String {
[INFO] [stderr]    |                      ^^^^^^^^^^^ help: change this to: `&[isize]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/sorts/insertion_sort.rs:18:13
[INFO] [stderr]    |
[INFO] [stderr] 18 |             i = i - 1;
[INFO] [stderr]    |             ^^^^^^^^^ help: replace it with: `i -= 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this looks like you are swapping elements of `a` manually
[INFO] [stderr]   --> src/sorts/selection_sort.rs:20:9
[INFO] [stderr]    |
[INFO] [stderr] 20 | /         let temp = a[j];
[INFO] [stderr] 21 | |         a[j] = a[smallest];
[INFO] [stderr] 22 | |         a[smallest] = temp;
[INFO] [stderr]    | |__________________________^ help: try: `a.swap(j, smallest)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_swap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/sorts/merge_sort.rs:16:14
[INFO] [stderr]    |
[INFO] [stderr] 16 |     for i in 0..n1 {
[INFO] [stderr]    |              ^^^^^ help: try replacing the loop by: `left[..n1].clone_from_slice(&a[p..(n1 + p)])`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::manual_memcpy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: it looks like you're manually copying between slices
[INFO] [stderr]   --> src/sorts/merge_sort.rs:19:14
[INFO] [stderr]    |
[INFO] [stderr] 19 |     for j in 0..n2 {
[INFO] [stderr]    |              ^^^^^ help: try replacing the loop by: `right[..n2].clone_from_slice(&a[q..(n2 + q)])`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `k` is only used to index `a`.
[INFO] [stderr]   --> src/sorts/merge_sort.rs:26:14
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for k in p..r {
[INFO] [stderr]    |              ^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 26 |     for <item> in a.iter_mut().take(r).skip(p) {
[INFO] [stderr]    |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.65s
[INFO] running `"docker" "inspect" "ecec3f9cc79218e3b8561b4412b8d5f3393caffe7474384d2b060f27bb254ca1"`
[INFO] running `"docker" "rm" "-f" "ecec3f9cc79218e3b8561b4412b8d5f3393caffe7474384d2b060f27bb254ca1"`
[INFO] [stdout] ecec3f9cc79218e3b8561b4412b8d5f3393caffe7474384d2b060f27bb254ca1