[INFO] updating cached repository sjmarshy/beewriter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sjmarshy/beewriter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sjmarshy/beewriter" "work/ex/clippy-test-run/sources/stable/gh/sjmarshy/beewriter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sjmarshy/beewriter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sjmarshy/beewriter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sjmarshy/beewriter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sjmarshy/beewriter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f51c17c78c7565c8d654f2daf799142bda745f39 [INFO] sha for GitHub repo sjmarshy/beewriter: f51c17c78c7565c8d654f2daf799142bda745f39 [INFO] validating manifest of sjmarshy/beewriter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sjmarshy/beewriter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sjmarshy/beewriter [INFO] finished frobbing sjmarshy/beewriter [INFO] frobbed toml for sjmarshy/beewriter written to work/ex/clippy-test-run/sources/stable/gh/sjmarshy/beewriter/Cargo.toml [INFO] started frobbing sjmarshy/beewriter [INFO] finished frobbing sjmarshy/beewriter [INFO] frobbed toml for sjmarshy/beewriter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sjmarshy/beewriter/Cargo.toml [INFO] crate sjmarshy/beewriter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sjmarshy/beewriter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sjmarshy/beewriter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 863e8f371bc2fda282c18fc257347f1686ffe15b10b91183d783ad806bf3784e [INFO] running `"docker" "start" "-a" "863e8f371bc2fda282c18fc257347f1686ffe15b10b91183d783ad806bf3784e"` [INFO] [stderr] Checking bytes v0.3.0 [INFO] [stderr] Checking slab v0.1.3 [INFO] [stderr] Compiling ws2_32-sys v0.2.1 [INFO] [stderr] Checking time v0.1.38 [INFO] [stderr] Checking memchr v1.0.1 [INFO] [stderr] Checking filetime v0.1.10 [INFO] [stderr] Checking inotify v0.3.0 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking aho-corasick v0.6.3 [INFO] [stderr] Checking walkdir v0.1.8 [INFO] [stderr] Checking miow v0.1.5 [INFO] [stderr] Checking regex v0.2.2 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking notify v4.0.1 [INFO] [stderr] Checking beewriter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `RecommendedWatcher`, `RecursiveMode` [INFO] [stderr] --> src/main.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | use notify::{RecommendedWatcher, RecursiveMode, Watcher}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc::channel` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::sync::mpsc::channel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `Watcher` [INFO] [stderr] --> src/main.rs:4:49 [INFO] [stderr] | [INFO] [stderr] 4 | use notify::{RecommendedWatcher, RecursiveMode, Watcher}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `RecommendedWatcher`, `RecursiveMode` [INFO] [stderr] --> src/main.rs:4:14 [INFO] [stderr] | [INFO] [stderr] 4 | use notify::{RecommendedWatcher, RecursiveMode, Watcher}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::sync::mpsc::channel` [INFO] [stderr] --> src/main.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | use std::sync::mpsc::channel; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::time::Duration` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use std::time::Duration; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | read_dir(p).and_then(|dir| Ok(get_file_path(dir))).unwrap_or(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `read_dir(p).and_then(|dir| Ok(get_file_path(dir))).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:67:32 [INFO] [stderr] | [INFO] [stderr] 67 | let initial_count: usize = files.unwrap_or(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `files.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused import: `Watcher` [INFO] [stderr] --> src/main.rs:4:49 [INFO] [stderr] | [INFO] [stderr] 4 | use notify::{RecommendedWatcher, RecursiveMode, Watcher}; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | read_dir(p).and_then(|dir| Ok(get_file_path(dir))).unwrap_or(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `read_dir(p).and_then(|dir| Ok(get_file_path(dir))).unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/main.rs:67:32 [INFO] [stderr] | [INFO] [stderr] 67 | let initial_count: usize = files.unwrap_or(Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `files.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.08s [INFO] running `"docker" "inspect" "863e8f371bc2fda282c18fc257347f1686ffe15b10b91183d783ad806bf3784e"` [INFO] running `"docker" "rm" "-f" "863e8f371bc2fda282c18fc257347f1686ffe15b10b91183d783ad806bf3784e"` [INFO] [stdout] 863e8f371bc2fda282c18fc257347f1686ffe15b10b91183d783ad806bf3784e