[INFO] updating cached repository sirkibsirkib/vault [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sirkibsirkib/vault [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/vault" "work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/vault"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/vault'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/vault" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/vault"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/vault'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 259a4be6607bf6d11b73e630f8b346d643ab64b8 [INFO] sha for GitHub repo sirkibsirkib/vault: 259a4be6607bf6d11b73e630f8b346d643ab64b8 [INFO] validating manifest of sirkibsirkib/vault on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sirkibsirkib/vault on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sirkibsirkib/vault [INFO] finished frobbing sirkibsirkib/vault [INFO] frobbed toml for sirkibsirkib/vault written to work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/vault/Cargo.toml [INFO] started frobbing sirkibsirkib/vault [INFO] finished frobbing sirkibsirkib/vault [INFO] frobbed toml for sirkibsirkib/vault written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/vault/Cargo.toml [INFO] crate sirkibsirkib/vault has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sirkibsirkib/vault against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/vault:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45ca76ff2214fb3e41c61a71ac789a61770e7c38655b097849f7246117939ce0 [INFO] running `"docker" "start" "-a" "45ca76ff2214fb3e41c61a71ac789a61770e7c38655b097849f7246117939ce0"` [INFO] [stderr] Compiling serde v1.0.64 [INFO] [stderr] Checking rand_core v0.2.0 [INFO] [stderr] Checking rpassword v2.0.0 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Compiling serde_derive v1.0.64 [INFO] [stderr] Checking rand v0.5.0 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking serde_json v1.0.19 [INFO] [stderr] Checking bincode v1.0.0 [INFO] [stderr] Checking vault v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:332:11 [INFO] [stderr] | [INFO] [stderr] 332 | } else { [INFO] [stderr] | _________________^ [INFO] [stderr] 333 | | if !user_confirmation("Found entry file, but cannot open it using current config. Proceed with rm?") { [INFO] [stderr] 334 | | return [INFO] [stderr] 335 | | } [INFO] [stderr] 336 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 332 | } else if !user_confirmation("Found entry file, but cannot open it using current config. Proceed with rm?") { [INFO] [stderr] 333 | return [INFO] [stderr] 334 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:332:11 [INFO] [stderr] | [INFO] [stderr] 332 | } else { [INFO] [stderr] | _________________^ [INFO] [stderr] 333 | | if !user_confirmation("Found entry file, but cannot open it using current config. Proceed with rm?") { [INFO] [stderr] 334 | | return [INFO] [stderr] 335 | | } [INFO] [stderr] 336 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 332 | } else if !user_confirmation("Found entry file, but cannot open it using current config. Proceed with rm?") { [INFO] [stderr] 333 | return [INFO] [stderr] 334 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:59:29 [INFO] [stderr] | [INFO] [stderr] 59 | final_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | final_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:208:46 [INFO] [stderr] | [INFO] [stderr] 208 | let tokens: Vec<&str> = cmd_input.split(" ").filter(|x| x.len() > 0).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:208:62 [INFO] [stderr] | [INFO] [stderr] 208 | let tokens: Vec<&str> = cmd_input.split(" ").filter(|x| x.len() > 0).collect(); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | if tokens.len() == 0 {continue} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:278:3 [INFO] [stderr] | [INFO] [stderr] 278 | match &s as &str { [INFO] [stderr] | _________^ [INFO] [stderr] 279 | | "y" => return true, [INFO] [stderr] 280 | | _ => (), [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________^ help: try this: `if let "y" = &s as &str { return true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:356:6 [INFO] [stderr] | [INFO] [stderr] 356 | if secret.value.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `secret.value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:59:29 [INFO] [stderr] | [INFO] [stderr] 59 | final_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:82:29 [INFO] [stderr] | [INFO] [stderr] 82 | final_result.extend(write_buffer.take_read_buffer().take_remaining().iter().map(|&i| i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `write_buffer.take_read_buffer().take_remaining().iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:208:46 [INFO] [stderr] | [INFO] [stderr] 208 | let tokens: Vec<&str> = cmd_input.split(" ").filter(|x| x.len() > 0).collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:208:62 [INFO] [stderr] | [INFO] [stderr] 208 | let tokens: Vec<&str> = cmd_input.split(" ").filter(|x| x.len() > 0).collect(); [INFO] [stderr] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!x.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:209:9 [INFO] [stderr] | [INFO] [stderr] 209 | if tokens.len() == 0 {continue} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tokens.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:278:3 [INFO] [stderr] | [INFO] [stderr] 278 | match &s as &str { [INFO] [stderr] | _________^ [INFO] [stderr] 279 | | "y" => return true, [INFO] [stderr] 280 | | _ => (), [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________^ help: try this: `if let "y" = &s as &str { return true }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:356:6 [INFO] [stderr] | [INFO] [stderr] 356 | if secret.value.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `secret.value.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 37.21s [INFO] running `"docker" "inspect" "45ca76ff2214fb3e41c61a71ac789a61770e7c38655b097849f7246117939ce0"` [INFO] running `"docker" "rm" "-f" "45ca76ff2214fb3e41c61a71ac789a61770e7c38655b097849f7246117939ce0"` [INFO] [stdout] 45ca76ff2214fb3e41c61a71ac789a61770e7c38655b097849f7246117939ce0