[INFO] updating cached repository sirkibsirkib/specs_nbody [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sirkibsirkib/specs_nbody [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/specs_nbody" "work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/specs_nbody"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/specs_nbody'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/specs_nbody" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/specs_nbody"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/specs_nbody'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 645fdaadf23c27761b23463b7ee6c96e0a7929f3 [INFO] sha for GitHub repo sirkibsirkib/specs_nbody: 645fdaadf23c27761b23463b7ee6c96e0a7929f3 [INFO] validating manifest of sirkibsirkib/specs_nbody on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sirkibsirkib/specs_nbody on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sirkibsirkib/specs_nbody [INFO] finished frobbing sirkibsirkib/specs_nbody [INFO] frobbed toml for sirkibsirkib/specs_nbody written to work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/specs_nbody/Cargo.toml [INFO] started frobbing sirkibsirkib/specs_nbody [INFO] finished frobbing sirkibsirkib/specs_nbody [INFO] frobbed toml for sirkibsirkib/specs_nbody written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/specs_nbody/Cargo.toml [INFO] crate sirkibsirkib/specs_nbody has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sirkibsirkib/specs_nbody against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/specs_nbody:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b41854f4387dff53ff0093df20253f7d7f43e618a084b3f37af06ffc45636f4b [INFO] running `"docker" "start" "-a" "b41854f4387dff53ff0093df20253f7d7f43e618a084b3f37af06ffc45636f4b"` [INFO] [stderr] Checking atom v0.3.5 [INFO] [stderr] Checking nonzero_signed v1.0.2 [INFO] [stderr] Checking crossbeam-utils v0.6.1 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking parking_lot_core v0.2.14 [INFO] [stderr] Checking rayon-core v1.4.1 [INFO] [stderr] Checking parking_lot_core v0.3.1 [INFO] [stderr] Compiling shred-derive v0.5.1 [INFO] [stderr] Checking rand v0.6.1 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Checking parking_lot v0.5.5 [INFO] [stderr] Checking crossbeam-deque v0.5.2 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking rayon v1.0.3 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking shrev v1.0.1 [INFO] [stderr] Checking crossbeam v0.4.1 [INFO] [stderr] Checking shred v0.7.1 [INFO] [stderr] Checking hibitset v0.5.3 [INFO] [stderr] Checking specs v0.14.1 [INFO] [stderr] Checking rust_testbed v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:84:36 [INFO] [stderr] | [INFO] [stderr] 84 | Action::BumpEntity(e, pt) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:84:36 [INFO] [stderr] | [INFO] [stderr] 84 | Action::BumpEntity(e, pt) => { [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `HashMapStorage` [INFO] [stderr] --> src/components.rs:2:36 [INFO] [stderr] | [INFO] [stderr] 2 | use specs::{Component, VecStorage, HashMapStorage}; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ActionEnqueuer`, `Action`, `Actor` [INFO] [stderr] --> src/components.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use actions::{Actor, ActionEnqueuer, Action}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `specs::Entity` [INFO] [stderr] --> src/components.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use specs::Entity; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `actions::*` [INFO] [stderr] --> src/systems.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use actions::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `entity` [INFO] [stderr] --> src/actions.rs:55:41 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn read(self, entity: Entity) -> ReadStorage<'a, T> { [INFO] [stderr] | ^^^^^^ help: consider using `_entity` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `HashMapStorage` [INFO] [stderr] --> src/components.rs:2:36 [INFO] [stderr] | [INFO] [stderr] 2 | use specs::{Component, VecStorage, HashMapStorage}; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ActionEnqueuer`, `Action`, `Actor` [INFO] [stderr] --> src/components.rs:3:15 [INFO] [stderr] | [INFO] [stderr] 3 | use actions::{Actor, ActionEnqueuer, Action}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `specs::Entity` [INFO] [stderr] --> src/components.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use specs::Entity; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `actions::*` [INFO] [stderr] --> src/systems.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use actions::*; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `TickId` [INFO] [stderr] --> src/main.rs:105:1 [INFO] [stderr] | [INFO] [stderr] 105 | struct TickId(usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/systems.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | image: iter::repeat('o' as u8).take(w * h).collect(), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/systems.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | *c = ' ' as u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/systems.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | self.put(x, y, 'o' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: unused variable: `entity` [INFO] [stderr] --> src/actions.rs:55:41 [INFO] [stderr] | [INFO] [stderr] 55 | pub fn read(self, entity: Entity) -> ReadStorage<'a, T> { [INFO] [stderr] | ^^^^^^ help: consider using `_entity` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `TickId` [INFO] [stderr] --> src/main.rs:105:1 [INFO] [stderr] | [INFO] [stderr] 105 | struct TickId(usize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/systems.rs:55:33 [INFO] [stderr] | [INFO] [stderr] 55 | image: iter::repeat('o' as u8).take(w * h).collect(), [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::char_lit_as_u8)] on by default [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/systems.rs:60:18 [INFO] [stderr] | [INFO] [stderr] 60 | *c = ' ' as u8 [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b' ' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] warning: casting character literal to u8. `char`s are 4 bytes wide in rust, so casting to u8 truncates them [INFO] [stderr] --> src/systems.rs:103:28 [INFO] [stderr] | [INFO] [stderr] 103 | self.put(x, y, 'o' as u8); [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider using a byte literal instead: [INFO] [stderr] b'o' [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 26.59s [INFO] running `"docker" "inspect" "b41854f4387dff53ff0093df20253f7d7f43e618a084b3f37af06ffc45636f4b"` [INFO] running `"docker" "rm" "-f" "b41854f4387dff53ff0093df20253f7d7f43e618a084b3f37af06ffc45636f4b"` [INFO] [stdout] b41854f4387dff53ff0093df20253f7d7f43e618a084b3f37af06ffc45636f4b