[INFO] updating cached repository sirkibsirkib/mc_dummy [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sirkibsirkib/mc_dummy [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/mc_dummy" "work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/mc_dummy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/mc_dummy'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/mc_dummy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/mc_dummy"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/mc_dummy'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 482714e31f7071909367e56c7fe5600b272a8aa3 [INFO] sha for GitHub repo sirkibsirkib/mc_dummy: 482714e31f7071909367e56c7fe5600b272a8aa3 [INFO] validating manifest of sirkibsirkib/mc_dummy on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sirkibsirkib/mc_dummy on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sirkibsirkib/mc_dummy [INFO] finished frobbing sirkibsirkib/mc_dummy [INFO] frobbed toml for sirkibsirkib/mc_dummy written to work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/mc_dummy/Cargo.toml [INFO] started frobbing sirkibsirkib/mc_dummy [INFO] finished frobbing sirkibsirkib/mc_dummy [INFO] frobbed toml for sirkibsirkib/mc_dummy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/mc_dummy/Cargo.toml [INFO] crate sirkibsirkib/mc_dummy has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sirkibsirkib/mc_dummy against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/mc_dummy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c06368597fcefdc8690ba8bad5ecb67e5004d687fc2d3322333f1aaf06311d26 [INFO] running `"docker" "start" "-a" "c06368597fcefdc8690ba8bad5ecb67e5004d687fc2d3322333f1aaf06311d26"` [INFO] [stderr] Checking mc_dummy v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mc_channel.rs:213:22 [INFO] [stderr] | [INFO] [stderr] 213 | ((position.x & 0x3FFFFFF) << 38) [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x03FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mc_channel.rs:215:23 [INFO] [stderr] | [INFO] [stderr] 215 | | (position.z & 0x3FFFFFF); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x03FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mc_channel.rs:278:23 [INFO] [stderr] | [INFO] [stderr] 278 | x: (if x >= 2^25 { x as i64 - 2^26 } else {x as i64}), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(x as i64 - 2) ^ 26` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mc_channel.rs:279:23 [INFO] [stderr] | [INFO] [stderr] 279 | y: (if y >= 2^11 { y as i64 - 2^12 } else {y as i64}), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(y as i64 - 2) ^ 12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mc_channel.rs:280:23 [INFO] [stderr] | [INFO] [stderr] 280 | z: (if z >= 2^25 { z as i64 - 2^26 } else {z as i64}), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(z as i64 - 2) ^ 26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unused import: `WritePlusPlus` [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | WritePlusPlus, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Position` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Position, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mc_channel.rs:213:22 [INFO] [stderr] | [INFO] [stderr] 213 | ((position.x & 0x3FFFFFF) << 38) [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x03FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/mc_channel.rs:215:23 [INFO] [stderr] | [INFO] [stderr] 215 | | (position.z & 0x3FFFFFF); [INFO] [stderr] | ^^^^^^^^^ help: consider: `0x03FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mc_channel.rs:278:23 [INFO] [stderr] | [INFO] [stderr] 278 | x: (if x >= 2^25 { x as i64 - 2^26 } else {x as i64}), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(x as i64 - 2) ^ 26` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mc_channel.rs:279:23 [INFO] [stderr] | [INFO] [stderr] 279 | y: (if y >= 2^11 { y as i64 - 2^12 } else {y as i64}), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(y as i64 - 2) ^ 12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/mc_channel.rs:280:23 [INFO] [stderr] | [INFO] [stderr] 280 | z: (if z >= 2^25 { z as i64 - 2^26 } else {z as i64}), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(z as i64 - 2) ^ 26` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unused import: `WritePlusPlus` [INFO] [stderr] --> src/main.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | WritePlusPlus, [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `Position` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | Position, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Clientward` [INFO] [stderr] --> src/mc_channel.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub enum Clientward { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Status` [INFO] [stderr] --> src/mc_channel.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | Login, Status, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `CommandsOnly` [INFO] [stderr] --> src/mc_channel.rs:48:11 [INFO] [stderr] | [INFO] [stderr] 48 | Enabled, CommandsOnly, Hidden [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Hidden` [INFO] [stderr] --> src/mc_channel.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | Enabled, CommandsOnly, Hidden [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/mc_channel.rs:51:2 [INFO] [stderr] | [INFO] [stderr] 51 | Left, Right, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `PayloadReader` [INFO] [stderr] --> src/main.rs:65:1 [INFO] [stderr] | [INFO] [stderr] 65 | type PayloadReader<'a> = BufReader<&'a [u8]>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `move_rel` [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | fn move_rel(&mut self, x: f64, y: f64, z: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mc_channel.rs:127:3 [INFO] [stderr] | [INFO] [stderr] 127 | packet.write(data).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mc_channel.rs:143:3 [INFO] [stderr] | [INFO] [stderr] 143 | w.write(&self.bytes[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | x = x + (1 << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `x += (1 << 32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/mc_channel.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | x = x + (1 << 32); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | x = x >> 7; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `x >>= 7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mc_channel.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | self.write(&buf[..i+1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/mc_channel.rs:177:25 [INFO] [stderr] | [INFO] [stderr] 177 | self.write(&buf[..i+1]).unwrap(); [INFO] [stderr] | ^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mc_channel.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | self.write(s.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mc_channel.rs:208:3 [INFO] [stderr] | [INFO] [stderr] 208 | self.write(& [byte; 1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mc_channel.rs:220:6 [INFO] [stderr] | [INFO] [stderr] 220 | self.write_f64::(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mc_channel.rs:224:6 [INFO] [stderr] | [INFO] [stderr] 224 | self.write_f32::(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/mc_channel.rs:261:19 [INFO] [stderr] | [INFO] [stderr] 261 | val = self.read_u8().unwrap() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.read_u8().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | total = total | ((val & 0x7F) << shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total |= ((val & 0x7F) << shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | shift = shift + 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `shift += 7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | total = total - (1 << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total -= (1 << 32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `total` [INFO] [stderr] --> src/mc_channel.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | total = total - (1 << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Clientward` [INFO] [stderr] --> src/mc_channel.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | pub enum Clientward { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Status` [INFO] [stderr] --> src/mc_channel.rs:34:9 [INFO] [stderr] | [INFO] [stderr] 34 | Login, Status, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:115:37 [INFO] [stderr] | [INFO] [stderr] 115 | while len > buf.len() { &buf.push(0u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `buf.push(0u8);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] warning: variant is never constructed: `CommandsOnly` [INFO] [stderr] --> src/mc_channel.rs:48:11 [INFO] [stderr] | [INFO] [stderr] 48 | Enabled, CommandsOnly, Hidden [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Hidden` [INFO] [stderr] --> src/mc_channel.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | Enabled, CommandsOnly, Hidden [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Left` [INFO] [stderr] --> src/mc_channel.rs:51:2 [INFO] [stderr] | [INFO] [stderr] 51 | Left, Right, [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `PayloadReader` [INFO] [stderr] --> src/main.rs:65:1 [INFO] [stderr] | [INFO] [stderr] 65 | type PayloadReader<'a> = BufReader<&'a [u8]>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `move_rel` [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | fn move_rel(&mut self, x: f64, y: f64, z: f64) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:149:60 [INFO] [stderr] | [INFO] [stderr] 149 | Packet::new_plugin_message("MC|Brand", &vec![7, 118, 97, 110, 105, 108, 108, 97]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[7, 118, 97, 110, 105, 108, 108, 97]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mc_channel.rs:127:3 [INFO] [stderr] | [INFO] [stderr] 127 | packet.write(data).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mc_channel.rs:143:3 [INFO] [stderr] | [INFO] [stderr] 143 | w.write(&self.bytes[..]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:169:13 [INFO] [stderr] | [INFO] [stderr] 169 | x = x + (1 << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `x += (1 << 32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `x` [INFO] [stderr] --> src/mc_channel.rs:169:17 [INFO] [stderr] | [INFO] [stderr] 169 | x = x + (1 << 32); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: Could not compile `mc_dummy`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:173:13 [INFO] [stderr] | [INFO] [stderr] 173 | x = x >> 7; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `x >>= 7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | i = i + 1; [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `i += 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mc_channel.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | self.write(&buf[..i+1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/mc_channel.rs:177:25 [INFO] [stderr] | [INFO] [stderr] 177 | self.write(&buf[..i+1]).unwrap(); [INFO] [stderr] | ^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mc_channel.rs:182:9 [INFO] [stderr] | [INFO] [stderr] 182 | self.write(s.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/mc_channel.rs:208:3 [INFO] [stderr] | [INFO] [stderr] 208 | self.write(& [byte; 1]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mc_channel.rs:220:6 [INFO] [stderr] | [INFO] [stderr] 220 | self.write_f64::(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/mc_channel.rs:224:6 [INFO] [stderr] | [INFO] [stderr] 224 | self.write_f32::(x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/mc_channel.rs:261:19 [INFO] [stderr] | [INFO] [stderr] 261 | val = self.read_u8().unwrap() as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(self.read_u8().unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:262:13 [INFO] [stderr] | [INFO] [stderr] 262 | total = total | ((val & 0x7F) << shift); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total |= ((val & 0x7F) << shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:263:13 [INFO] [stderr] | [INFO] [stderr] 263 | shift = shift + 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `shift += 7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/mc_channel.rs:267:13 [INFO] [stderr] | [INFO] [stderr] 267 | total = total - (1 << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total -= (1 << 32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `total` [INFO] [stderr] --> src/mc_channel.rs:267:21 [INFO] [stderr] | [INFO] [stderr] 267 | total = total - (1 << 32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:115:37 [INFO] [stderr] | [INFO] [stderr] 115 | while len > buf.len() { &buf.push(0u8); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `buf.push(0u8);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/main.rs:149:60 [INFO] [stderr] | [INFO] [stderr] 149 | Packet::new_plugin_message("MC|Brand", &vec![7, 118, 97, 110, 105, 108, 108, 97]) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[7, 118, 97, 110, 105, 108, 108, 97]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `mc_dummy`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c06368597fcefdc8690ba8bad5ecb67e5004d687fc2d3322333f1aaf06311d26"` [INFO] running `"docker" "rm" "-f" "c06368597fcefdc8690ba8bad5ecb67e5004d687fc2d3322333f1aaf06311d26"` [INFO] [stdout] c06368597fcefdc8690ba8bad5ecb67e5004d687fc2d3322333f1aaf06311d26