[INFO] updating cached repository sirkibsirkib/liltcp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sirkibsirkib/liltcp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/liltcp" "work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/liltcp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/liltcp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sirkibsirkib/liltcp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/liltcp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/liltcp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c40a978fe086baf60d362bdcc81910569010c29e [INFO] sha for GitHub repo sirkibsirkib/liltcp: c40a978fe086baf60d362bdcc81910569010c29e [INFO] validating manifest of sirkibsirkib/liltcp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sirkibsirkib/liltcp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sirkibsirkib/liltcp [INFO] finished frobbing sirkibsirkib/liltcp [INFO] frobbed toml for sirkibsirkib/liltcp written to work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/liltcp/Cargo.toml [INFO] started frobbing sirkibsirkib/liltcp [INFO] finished frobbing sirkibsirkib/liltcp [INFO] frobbed toml for sirkibsirkib/liltcp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sirkibsirkib/liltcp/Cargo.toml [INFO] crate sirkibsirkib/liltcp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sirkibsirkib/liltcp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sirkibsirkib/liltcp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8082f854fb6a1436f8400231820aefdb9498655e27e1634be2e876c61c9ba328 [INFO] running `"docker" "start" "-a" "8082f854fb6a1436f8400231820aefdb9498655e27e1634be2e876c61c9ba328"` [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking liltcp v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 20 | | &Setting::Hex => "hex", [INFO] [stderr] 21 | | &Setting::Base64 => "base 64", [INFO] [stderr] 22 | | &Setting::Utf8 => "utf-8", [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | let s = match *self { [INFO] [stderr] 20 | Setting::Hex => "hex", [INFO] [stderr] 21 | Setting::Base64 => "base 64", [INFO] [stderr] 22 | Setting::Utf8 => "utf-8", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/main.rs:109:16 [INFO] [stderr] | [INFO] [stderr] 109 | if key_buffer[..in_bytes].chars().last() == Some('\n') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `key_buffer[..in_bytes].ends_with('\n')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/main.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | if key_buffer[..in_bytes].chars().last() == Some('\r') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `key_buffer[..in_bytes].ends_with('\r')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | stream.write(&text.as_bytes()).expect("writing went bad"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:229:17 [INFO] [stderr] | [INFO] [stderr] 229 | stream.write(&b).expect("writing went bad"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | stream.write(&b).expect("writing went bad"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `liltcp`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/main.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 20 | | &Setting::Hex => "hex", [INFO] [stderr] 21 | | &Setting::Base64 => "base 64", [INFO] [stderr] 22 | | &Setting::Utf8 => "utf-8", [INFO] [stderr] 23 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 19 | let s = match *self { [INFO] [stderr] 20 | Setting::Hex => "hex", [INFO] [stderr] 21 | Setting::Base64 => "base 64", [INFO] [stderr] 22 | Setting::Utf8 => "utf-8", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/main.rs:109:16 [INFO] [stderr] | [INFO] [stderr] 109 | if key_buffer[..in_bytes].chars().last() == Some('\n') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `key_buffer[..in_bytes].ends_with('\n')` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::chars_last_cmp)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] warning: you should use the `ends_with` method [INFO] [stderr] --> src/main.rs:112:16 [INFO] [stderr] | [INFO] [stderr] 112 | if key_buffer[..in_bytes].chars().last() == Some('\r') { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: like this: `key_buffer[..in_bytes].ends_with('\r')` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#chars_last_cmp [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | stream.write(&text.as_bytes()).expect("writing went bad"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:229:17 [INFO] [stderr] | [INFO] [stderr] 229 | stream.write(&b).expect("writing went bad"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:236:17 [INFO] [stderr] | [INFO] [stderr] 236 | stream.write(&b).expect("writing went bad"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `liltcp`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8082f854fb6a1436f8400231820aefdb9498655e27e1634be2e876c61c9ba328"` [INFO] running `"docker" "rm" "-f" "8082f854fb6a1436f8400231820aefdb9498655e27e1634be2e876c61c9ba328"` [INFO] [stdout] 8082f854fb6a1436f8400231820aefdb9498655e27e1634be2e876c61c9ba328