[INFO] updating cached repository sinclairzx81/crimson-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sinclairzx81/crimson-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sinclairzx81/crimson-rust" "work/ex/clippy-test-run/sources/stable/gh/sinclairzx81/crimson-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sinclairzx81/crimson-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sinclairzx81/crimson-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sinclairzx81/crimson-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sinclairzx81/crimson-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 8ab88fd6d7223144b78312a8267d32db1b5543b6
[INFO] sha for GitHub repo sinclairzx81/crimson-rust: 8ab88fd6d7223144b78312a8267d32db1b5543b6
[INFO] validating manifest of sinclairzx81/crimson-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sinclairzx81/crimson-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sinclairzx81/crimson-rust
[INFO] finished frobbing sinclairzx81/crimson-rust
[INFO] frobbed toml for sinclairzx81/crimson-rust written to work/ex/clippy-test-run/sources/stable/gh/sinclairzx81/crimson-rust/Cargo.toml
[INFO] started frobbing sinclairzx81/crimson-rust
[INFO] finished frobbing sinclairzx81/crimson-rust
[INFO] frobbed toml for sinclairzx81/crimson-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sinclairzx81/crimson-rust/Cargo.toml
[INFO] crate sinclairzx81/crimson-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sinclairzx81/crimson-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sinclairzx81/crimson-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 1db24a422b7663e18648a120097ce3d0e7aa125c70cba08e1ee83bf4aca86129
[INFO] running `"docker" "start" "-a" "1db24a422b7663e18648a120097ce3d0e7aa125c70cba08e1ee83bf4aca86129"`
[INFO] [stderr]     Checking actor-csp v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: variant is never constructed: `Publish`
[INFO] [stderr]   --> src/crimson/system.rs:98:5
[INFO] [stderr]    |
[INFO] [stderr] 98 |     Publish(String, String, T),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `publish`
[INFO] [stderr]    --> src/crimson/system.rs:134:5
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn publish(&self, to: &str, value: T) -> Result<(), SendError<ActorEvent<T>>> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter`
[INFO] [stderr]   --> src/crimson/system.rs:47:21
[INFO] [stderr]    |
[INFO] [stderr] 47 |           receivers = receivers
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 48 | |             .into_iter()
[INFO] [stderr] 49 | |             .filter_map(|inner| match inner.try_recv() {
[INFO] [stderr] 50 | |                 Ok(value) => match sender.send(value) {
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |                 },
[INFO] [stderr] 58 | |             })
[INFO] [stderr]    | |______________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_filter_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/crimson/system.rs:60:12
[INFO] [stderr]    |
[INFO] [stderr] 60 |         if receivers.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `receivers.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: variant is never constructed: `Publish`
[INFO] [stderr]   --> src/crimson/system.rs:98:5
[INFO] [stderr]    |
[INFO] [stderr] 98 |     Publish(String, String, T),
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `publish`
[INFO] [stderr]    --> src/crimson/system.rs:134:5
[INFO] [stderr]     |
[INFO] [stderr] 134 |     pub fn publish(&self, to: &str, value: T) -> Result<(), SendError<ActorEvent<T>>> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/crimson/system.rs:154:20
[INFO] [stderr]     |
[INFO] [stderr] 154 |         for key in keys.into_iter() {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `keys`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: this `.filter_map` can be written more simply using `.filter`
[INFO] [stderr]   --> src/crimson/system.rs:47:21
[INFO] [stderr]    |
[INFO] [stderr] 47 |           receivers = receivers
[INFO] [stderr]    |  _____________________^
[INFO] [stderr] 48 | |             .into_iter()
[INFO] [stderr] 49 | |             .filter_map(|inner| match inner.try_recv() {
[INFO] [stderr] 50 | |                 Ok(value) => match sender.send(value) {
[INFO] [stderr] ...  |
[INFO] [stderr] 57 | |                 },
[INFO] [stderr] 58 | |             })
[INFO] [stderr]    | |______________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_filter_map)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_filter_map
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/crimson/system.rs:60:12
[INFO] [stderr]    |
[INFO] [stderr] 60 |         if receivers.len() == 0 {
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `receivers.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/crimson/system.rs:154:20
[INFO] [stderr]     |
[INFO] [stderr] 154 |         for key in keys.into_iter() {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `keys`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/crimson/system.rs:224:9
[INFO] [stderr]     |
[INFO] [stderr] 224 | /         match self.senders.get_mut(&address) {
[INFO] [stderr] 225 | |             Some(ref mut vec) => vec.push(sender),
[INFO] [stderr] 226 | |             None => {}
[INFO] [stderr] 227 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(ref mut vec) = self.senders.get_mut(&address) { vec.push(sender) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/crimson/system.rs:224:9
[INFO] [stderr]     |
[INFO] [stderr] 224 | /         match self.senders.get_mut(&address) {
[INFO] [stderr] 225 | |             Some(ref mut vec) => vec.push(sender),
[INFO] [stderr] 226 | |             None => {}
[INFO] [stderr] 227 | |         }
[INFO] [stderr]     | |_________^ help: try this: `if let Some(ref mut vec) = self.senders.get_mut(&address) { vec.push(sender) }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/crimson/system.rs:249:58
[INFO] [stderr]     |
[INFO] [stderr] 249 |                         None => f(SystemEvent::Error(to, format!("does not exist"))),
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"does not exist".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/crimson/system.rs:252:29
[INFO] [stderr]     |
[INFO] [stderr] 252 | /                             match sender.send(value) {
[INFO] [stderr] 253 | |                                 Err(_) => f(SystemEvent::Error(to, format!("send error"))),
[INFO] [stderr] 254 | |                                 Ok(_) => {}
[INFO] [stderr] 255 | |                             }
[INFO] [stderr]     | |_____________________________^ help: try this: `if let Err(_) = sender.send(value) { f(SystemEvent::Error(to, format!("send error"))) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/crimson/system.rs:253:68
[INFO] [stderr]     |
[INFO] [stderr] 253 |                                 Err(_) => f(SystemEvent::Error(to, format!("send error"))),
[INFO] [stderr]     |                                                                    ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"send error".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/crimson/system.rs:249:58
[INFO] [stderr]     |
[INFO] [stderr] 249 |                         None => f(SystemEvent::Error(to, format!("does not exist"))),
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"does not exist".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/crimson/system.rs:263:58
[INFO] [stderr]     |
[INFO] [stderr] 263 |                         None => f(SystemEvent::Error(to, format!("does not exist"))),
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"does not exist".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/crimson/system.rs:252:29
[INFO] [stderr]     |
[INFO] [stderr] 252 | /                             match sender.send(value) {
[INFO] [stderr] 253 | |                                 Err(_) => f(SystemEvent::Error(to, format!("send error"))),
[INFO] [stderr] 254 | |                                 Ok(_) => {}
[INFO] [stderr] 255 | |                             }
[INFO] [stderr]     | |_____________________________^ help: try this: `if let Err(_) = sender.send(value) { f(SystemEvent::Error(to, format!("send error"))) }`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/crimson/system.rs:266:33
[INFO] [stderr]     |
[INFO] [stderr] 266 | /                                 match sender.send(value.clone()) {
[INFO] [stderr] 267 | |                                     Err(_) => {
[INFO] [stderr] 268 | |                                         f(SystemEvent::Error(to.clone(), format!("send error")))
[INFO] [stderr] 269 | |                                     }
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr] 270 | |                                     Ok(_) => {}
[INFO] [stderr]    --> src/crimson/system.rs:253:68
[INFO] [stderr] 271 | |                                 }
[INFO] [stderr]     |
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr] 253 |                                 Err(_) => f(SystemEvent::Error(to, format!("send error"))),
[INFO] [stderr]     |                                                                    ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"send error".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 266 |                                 if let Err(_) = sender.send(value.clone()) {
[INFO] [stderr] 267 |     f(SystemEvent::Error(to.clone(), format!("send error")))
[INFO] [stderr] 268 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/crimson/system.rs:263:58
[INFO] [stderr]     |
[INFO] [stderr] 263 |                         None => f(SystemEvent::Error(to, format!("does not exist"))),
[INFO] [stderr]     |                                                          ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"does not exist".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/crimson/system.rs:266:33
[INFO] [stderr]     |
[INFO] [stderr] 266 | /                                 match sender.send(value.clone()) {
[INFO] [stderr] 267 | |                                     Err(_) => {
[INFO] [stderr] 268 | |                                         f(SystemEvent::Error(to.clone(), format!("send error")))
[INFO] [stderr] 269 | |                                     }
[INFO] [stderr] 270 | |                                     Ok(_) => {}
[INFO] [stderr] 271 | |                                 }
[INFO] [stderr]     | |_________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 266 |                                 if let Err(_) = sender.send(value.clone()) {
[INFO] [stderr] 267 |     f(SystemEvent::Error(to.clone(), format!("send error")))
[INFO] [stderr] 268 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/crimson/system.rs:268:74
[INFO] [stderr]     |
[INFO] [stderr] 268 |                                         f(SystemEvent::Error(to.clone(), format!("send error")))
[INFO] [stderr]     |                                                                          ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"send error".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/crimson/system.rs:268:74
[INFO] [stderr]     |
[INFO] [stderr] 268 |                                         f(SystemEvent::Error(to.clone(), format!("send error")))
[INFO] [stderr]     |                                                                          ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"send error".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.77s
[INFO] running `"docker" "inspect" "1db24a422b7663e18648a120097ce3d0e7aa125c70cba08e1ee83bf4aca86129"`
[INFO] running `"docker" "rm" "-f" "1db24a422b7663e18648a120097ce3d0e7aa125c70cba08e1ee83bf4aca86129"`
[INFO] [stdout] 1db24a422b7663e18648a120097ce3d0e7aa125c70cba08e1ee83bf4aca86129