[INFO] updating cached repository simonvandel/rplace [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/simonvandel/rplace [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/simonvandel/rplace" "work/ex/clippy-test-run/sources/stable/gh/simonvandel/rplace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simonvandel/rplace'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/simonvandel/rplace" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simonvandel/rplace"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simonvandel/rplace'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 57732c4929f4686ee18b82d873d25e2a3a7fecdf [INFO] sha for GitHub repo simonvandel/rplace: 57732c4929f4686ee18b82d873d25e2a3a7fecdf [INFO] validating manifest of simonvandel/rplace on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simonvandel/rplace on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simonvandel/rplace [INFO] finished frobbing simonvandel/rplace [INFO] frobbed toml for simonvandel/rplace written to work/ex/clippy-test-run/sources/stable/gh/simonvandel/rplace/Cargo.toml [INFO] started frobbing simonvandel/rplace [INFO] finished frobbing simonvandel/rplace [INFO] frobbed toml for simonvandel/rplace written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simonvandel/rplace/Cargo.toml [INFO] crate simonvandel/rplace has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simonvandel/rplace against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/simonvandel/rplace:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a02a4b71330215259815dc960fd26d7d4b7e496c2a1f5d58e0418e0a87d31291 [INFO] running `"docker" "start" "-a" "a02a4b71330215259815dc960fd26d7d4b7e496c2a1f5d58e0418e0a87d31291"` [INFO] [stderr] Checking rplace v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | Grid {buffer: buffer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/grid.rs:10:15 [INFO] [stderr] | [INFO] [stderr] 10 | Grid {buffer: buffer } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:68:15 [INFO] [stderr] | [INFO] [stderr] 68 | 0 => 0xFFFFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:69:15 [INFO] [stderr] | [INFO] [stderr] 69 | 1 => 0xE4E4E4, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E4_E4E4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:70:15 [INFO] [stderr] | [INFO] [stderr] 70 | 2 => 0x888888, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0088_8888` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:71:15 [INFO] [stderr] | [INFO] [stderr] 71 | 3 => 0x222222, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0022_2222` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:72:15 [INFO] [stderr] | [INFO] [stderr] 72 | 4 => 0xFFA7D1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_A7D1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:73:15 [INFO] [stderr] | [INFO] [stderr] 73 | 5 => 0xE50000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E5_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:74:15 [INFO] [stderr] | [INFO] [stderr] 74 | 6 => 0xE59500, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E5_9500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:75:15 [INFO] [stderr] | [INFO] [stderr] 75 | 7 => 0xA06A42, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00A0_6A42` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:76:15 [INFO] [stderr] | [INFO] [stderr] 76 | 8 => 0xE5D900, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E5_D900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:77:15 [INFO] [stderr] | [INFO] [stderr] 77 | 9 => 0x94E044, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0094_E044` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:78:15 [INFO] [stderr] | [INFO] [stderr] 78 | 10 => 0x02BE01, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0002_BE01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:79:15 [INFO] [stderr] | [INFO] [stderr] 79 | 11 => 0x00D3DD, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_D3DD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:80:15 [INFO] [stderr] | [INFO] [stderr] 80 | 12 => 0x0083C7, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_83C7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:81:15 [INFO] [stderr] | [INFO] [stderr] 81 | 13 => 0x0000EA, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00EA` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:82:15 [INFO] [stderr] | [INFO] [stderr] 82 | 14 => 0xCF6EE4, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00CF_6EE4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:83:15 [INFO] [stderr] | [INFO] [stderr] 83 | 15 => 0x820080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0082_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:68:15 [INFO] [stderr] | [INFO] [stderr] 68 | 0 => 0xFFFFFF, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:69:15 [INFO] [stderr] | [INFO] [stderr] 69 | 1 => 0xE4E4E4, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E4_E4E4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:70:15 [INFO] [stderr] | [INFO] [stderr] 70 | 2 => 0x888888, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0088_8888` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:71:15 [INFO] [stderr] | [INFO] [stderr] 71 | 3 => 0x222222, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0022_2222` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:72:15 [INFO] [stderr] | [INFO] [stderr] 72 | 4 => 0xFFA7D1, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_A7D1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:73:15 [INFO] [stderr] | [INFO] [stderr] 73 | 5 => 0xE50000, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E5_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:74:15 [INFO] [stderr] | [INFO] [stderr] 74 | 6 => 0xE59500, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E5_9500` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:75:15 [INFO] [stderr] | [INFO] [stderr] 75 | 7 => 0xA06A42, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00A0_6A42` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:76:15 [INFO] [stderr] | [INFO] [stderr] 76 | 8 => 0xE5D900, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00E5_D900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:77:15 [INFO] [stderr] | [INFO] [stderr] 77 | 9 => 0x94E044, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0094_E044` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:78:15 [INFO] [stderr] | [INFO] [stderr] 78 | 10 => 0x02BE01, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0002_BE01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:79:15 [INFO] [stderr] | [INFO] [stderr] 79 | 11 => 0x00D3DD, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_D3DD` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:80:15 [INFO] [stderr] | [INFO] [stderr] 80 | 12 => 0x0083C7, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_83C7` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:81:15 [INFO] [stderr] | [INFO] [stderr] 81 | 13 => 0x0000EA, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00EA` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:82:15 [INFO] [stderr] | [INFO] [stderr] 82 | 14 => 0xCF6EE4, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00CF_6EE4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:83:15 [INFO] [stderr] | [INFO] [stderr] 83 | 15 => 0x820080, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0082_0080` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | Err(_) => panic!("read fail"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:118:24 [INFO] [stderr] | [INFO] [stderr] 118 | if rest.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | Err(_) => panic!("read fail"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:118:24 [INFO] [stderr] | [INFO] [stderr] 118 | if rest.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `rest.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "a02a4b71330215259815dc960fd26d7d4b7e496c2a1f5d58e0418e0a87d31291"` [INFO] running `"docker" "rm" "-f" "a02a4b71330215259815dc960fd26d7d4b7e496c2a1f5d58e0418e0a87d31291"` [INFO] [stdout] a02a4b71330215259815dc960fd26d7d4b7e496c2a1f5d58e0418e0a87d31291