[INFO] updating cached repository simontoft/r8080 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/simontoft/r8080 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/simontoft/r8080" "work/ex/clippy-test-run/sources/stable/gh/simontoft/r8080"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simontoft/r8080'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/simontoft/r8080" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simontoft/r8080"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simontoft/r8080'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 034243373cc6d04ca80c68cdb797f1f7540a7865 [INFO] sha for GitHub repo simontoft/r8080: 034243373cc6d04ca80c68cdb797f1f7540a7865 [INFO] validating manifest of simontoft/r8080 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simontoft/r8080 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simontoft/r8080 [INFO] finished frobbing simontoft/r8080 [INFO] frobbed toml for simontoft/r8080 written to work/ex/clippy-test-run/sources/stable/gh/simontoft/r8080/Cargo.toml [INFO] started frobbing simontoft/r8080 [INFO] finished frobbing simontoft/r8080 [INFO] frobbed toml for simontoft/r8080 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simontoft/r8080/Cargo.toml [INFO] crate simontoft/r8080 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simontoft/r8080 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/simontoft/r8080:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] babbbdf83a3dad86ccddcec6cb6f3be154419781a7d85e82d5aa13509da1659c [INFO] running `"docker" "start" "-a" "babbbdf83a3dad86ccddcec6cb6f3be154419781a7d85e82d5aa13509da1659c"` [INFO] [stderr] Checking text_io v0.1.7 [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Compiling minifb v0.10.3 [INFO] [stderr] Checking r8080 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ram.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opcode.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | ram: ram, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ram.rs:16:13 [INFO] [stderr] | [INFO] [stderr] 16 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/opcode.rs:10:19 [INFO] [stderr] | [INFO] [stderr] 10 | opcode: opcode, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `opcode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | ram: ram, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ram` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cpu.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | window: window, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `window` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] extern crate text_io; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ram.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return self.bytes[address as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bytes[address as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ram.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return u8_to_u16(self.bytes[address as usize], self.bytes[address as usize + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `u8_to_u16(self.bytes[address as usize], self.bytes[address as usize + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cpu.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | value [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cpu.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | let value = u8_to_u16(self.ram.read_byte(self.sp + 1), self.ram.read_byte(self.sp)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:332:27 [INFO] [stderr] | [INFO] [stderr] 332 | let needed: u64 = 1000000000/120; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/cpu.rs:411:22 [INFO] [stderr] | [INFO] [stderr] 411 | for x in (0..WIDTH) { [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/cpu.rs:421:20 [INFO] [stderr] | [INFO] [stderr] 421 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/cpu.rs:427:26 [INFO] [stderr] | [INFO] [stderr] 427 | self.inp1 |= (1 << 5); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/cpu.rs:432:26 [INFO] [stderr] | [INFO] [stderr] 432 | self.inp1 |= (1 << 6); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/cpu.rs:437:26 [INFO] [stderr] | [INFO] [stderr] 437 | self.inp1 |= (1 << 0); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/cpu.rs:442:26 [INFO] [stderr] | [INFO] [stderr] 442 | self.inp1 |= (1 << 2); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/cpu.rs:447:26 [INFO] [stderr] | [INFO] [stderr] 447 | self.inp1 |= (1 << 4); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `util::*` [INFO] [stderr] --> src/instructions.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use util::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] extern crate text_io; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ram.rs:37:9 [INFO] [stderr] | [INFO] [stderr] 37 | return self.bytes[address as usize]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.bytes[address as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ram.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | return u8_to_u16(self.bytes[address as usize], self.bytes[address as usize + 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `u8_to_u16(self.bytes[address as usize], self.bytes[address as usize + 1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/cpu.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | value [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/cpu.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | let value = u8_to_u16(self.ram.read_byte(self.sp + 1), self.ram.read_byte(self.sp)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/cpu.rs:332:27 [INFO] [stderr] | [INFO] [stderr] 332 | let needed: u64 = 1000000000/120; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `for` head expression [INFO] [stderr] --> src/cpu.rs:411:22 [INFO] [stderr] | [INFO] [stderr] 411 | for x in (0..WIDTH) { [INFO] [stderr] | ^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded `()` [INFO] [stderr] --> src/cpu.rs:421:20 [INFO] [stderr] | [INFO] [stderr] 421 | return (); [INFO] [stderr] | ^^ help: remove the `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/cpu.rs:427:26 [INFO] [stderr] | [INFO] [stderr] 427 | self.inp1 |= (1 << 5); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/cpu.rs:432:26 [INFO] [stderr] | [INFO] [stderr] 432 | self.inp1 |= (1 << 6); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/cpu.rs:437:26 [INFO] [stderr] | [INFO] [stderr] 437 | self.inp1 |= (1 << 0); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/cpu.rs:442:26 [INFO] [stderr] | [INFO] [stderr] 442 | self.inp1 |= (1 << 2); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around assigned value [INFO] [stderr] --> src/cpu.rs:447:26 [INFO] [stderr] | [INFO] [stderr] 447 | self.inp1 |= (1 << 4); [INFO] [stderr] | ^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused import: `util::*` [INFO] [stderr] --> src/instructions.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use util::*; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/instructions.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn nop(state: &mut Cpu) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lhs` [INFO] [stderr] --> src/instructions.rs:667:9 [INFO] [stderr] | [INFO] [stderr] 667 | let lhs = state.a as u16; [INFO] [stderr] | ^^^ help: consider using `_lhs` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lhs` [INFO] [stderr] --> src/instructions.rs:696:9 [INFO] [stderr] | [INFO] [stderr] 696 | let lhs = state.a as u16; [INFO] [stderr] | ^^^ help: consider using `_lhs` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/cpu.rs:395:14 [INFO] [stderr] | [INFO] [stderr] 395 | for (i, byte) in self.get_vram().iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `state` [INFO] [stderr] --> src/instructions.rs:21:12 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn nop(state: &mut Cpu) { [INFO] [stderr] | ^^^^^ help: consider using `_state` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lhs` [INFO] [stderr] --> src/instructions.rs:667:9 [INFO] [stderr] | [INFO] [stderr] 667 | let lhs = state.a as u16; [INFO] [stderr] | ^^^ help: consider using `_lhs` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `lhs` [INFO] [stderr] --> src/instructions.rs:696:9 [INFO] [stderr] | [INFO] [stderr] 696 | let lhs = state.a as u16; [INFO] [stderr] | ^^^ help: consider using `_lhs` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/cpu.rs:395:14 [INFO] [stderr] | [INFO] [stderr] 395 | for (i, byte) in self.get_vram().iter().enumerate() { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_BC` [INFO] [stderr] --> src/cpu.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const REG_BC: u8 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_DE` [INFO] [stderr] --> src/cpu.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | const REG_DE: u8 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_AF` [INFO] [stderr] --> src/cpu.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | const REG_AF: u8 = 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_A` [INFO] [stderr] --> src/cpu.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | const REG_A: u8 = 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_M` [INFO] [stderr] --> src/cpu.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | const REG_M: u8 = 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `move_pc` [INFO] [stderr] --> src/cpu.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | pub fn move_pc(&mut self, address: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_BC` [INFO] [stderr] --> src/instructions.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | const REG_BC: u8 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_AF` [INFO] [stderr] --> src/instructions.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const REG_AF: u8 = 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_rom` [INFO] [stderr] --> src/main.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | fn test_rom() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `baloon_bomber` [INFO] [stderr] --> src/main.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | fn baloon_bomber() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lunar_rescue` [INFO] [stderr] --> src/main.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | fn lunar_rescue() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | const FLAG_C: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_BC` [INFO] [stderr] --> src/cpu.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const REG_BC: u8 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/cpu.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | / if res != 0 { [INFO] [stderr] 316 | | true [INFO] [stderr] 317 | | } else { [INFO] [stderr] 318 | | false [INFO] [stderr] 319 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `res != 0` [INFO] [stderr] warning: constant item is never used: `REG_DE` [INFO] [stderr] --> src/cpu.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | const REG_DE: u8 = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_AF` [INFO] [stderr] --> src/cpu.rs:15:1 [INFO] [stderr] | [INFO] [stderr] 15 | const REG_AF: u8 = 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_A` [INFO] [stderr] --> src/cpu.rs:17:1 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 17 | const REG_A: u8 = 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_M` [INFO] [stderr] --> src/cpu.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | const REG_M: u8 = 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: method is never used: `move_pc` [INFO] [stderr] --> src/cpu.rs:322:5 [INFO] [stderr] | [INFO] [stderr] 322 | pub fn move_pc(&mut self, address: u16) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_BC` [INFO] [stderr] --> src/instructions.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | const REG_BC: u8 = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `REG_AF` [INFO] [stderr] --> src/instructions.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const REG_AF: u8 = 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_rom` [INFO] [stderr] --> src/main.rs:24:1 [INFO] [stderr] | [INFO] [stderr] 24 | fn test_rom() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `baloon_bomber` [INFO] [stderr] --> src/main.rs:46:1 [INFO] [stderr] | [INFO] [stderr] 46 | fn baloon_bomber() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `lunar_rescue` [INFO] [stderr] --> src/main.rs:62:1 [INFO] [stderr] | [INFO] [stderr] 62 | fn lunar_rescue() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(dead_code)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(dead_code)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:329:21 [INFO] [stderr] | [INFO] [stderr] 329 | let nanos = elapsed.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cpu.rs:424:9 [INFO] [stderr] | [INFO] [stderr] 424 | / let mut input_received = false; [INFO] [stderr] 425 | | [INFO] [stderr] 426 | | if self.window.is_key_down(Key::Left) { [INFO] [stderr] 427 | | self.inp1 |= (1 << 5); [INFO] [stderr] 428 | | input_received = true; [INFO] [stderr] 429 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let input_received = if self.window.is_key_down(Key::Left) { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu.rs:437:26 [INFO] [stderr] | [INFO] [stderr] 437 | self.inp1 |= (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | const FLAG_C: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/cpu.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | / if res != 0 { [INFO] [stderr] 316 | | true [INFO] [stderr] 317 | | } else { [INFO] [stderr] 318 | | false [INFO] [stderr] 319 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `res != 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/cpu.rs:329:21 [INFO] [stderr] | [INFO] [stderr] 329 | let nanos = elapsed.subsec_nanos() as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | (upper as u16) << 8 | lower as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | (upper as u16) << 8 | lower as u16 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/util.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / if parity_table[index as usize] == 1 { [INFO] [stderr] 32 | | true [INFO] [stderr] 33 | | } else { false} [INFO] [stderr] | |___________________^ help: you can reduce it to: `parity_table[index as usize] == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/instructions.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | const FLAG_C: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | let port4hi = state.port4hi as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.port4hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | let port4lo = state.port4lo as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.port4lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | let port2 = state.port2 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.port2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/cpu.rs:424:9 [INFO] [stderr] | [INFO] [stderr] 424 | / let mut input_received = false; [INFO] [stderr] 425 | | [INFO] [stderr] 426 | | if self.window.is_key_down(Key::Left) { [INFO] [stderr] 427 | | self.inp1 |= (1 << 5); [INFO] [stderr] 428 | | input_received = true; [INFO] [stderr] 429 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let input_received = if self.window.is_key_down(Key::Left) { ..; true } else { false };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/cpu.rs:437:26 [INFO] [stderr] | [INFO] [stderr] 437 | self.inp1 |= (1 << 0); [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | (upper as u16) << 8 | lower as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(upper)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:2:27 [INFO] [stderr] | [INFO] [stderr] 2 | (upper as u16) << 8 | lower as u16 [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(lower)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/util.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / if parity_table[index as usize] == 1 { [INFO] [stderr] 32 | | true [INFO] [stderr] 33 | | } else { false} [INFO] [stderr] | |___________________^ help: you can reduce it to: `parity_table[index as usize] == 1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:406:16 [INFO] [stderr] | [INFO] [stderr] 406 | let curr = state.read_byte(dst) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(dst))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/instructions.rs:12:20 [INFO] [stderr] | [INFO] [stderr] 12 | const FLAG_C: u8 = 1 << 0; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:428:15 [INFO] [stderr] | [INFO] [stderr] 428 | let rhs = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:429:15 [INFO] [stderr] | [INFO] [stderr] 429 | let lhs = state.read_byte(REG_A) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(REG_A))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:440:17 [INFO] [stderr] | [INFO] [stderr] 440 | let value = state.read_dword(src) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(state.read_dword(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:442:42 [INFO] [stderr] | [INFO] [stderr] 442 | let result: u32 = value.wrapping_add(state.read_dword(REG_HL) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(state.read_dword(REG_HL))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:46:27 [INFO] [stderr] | [INFO] [stderr] 46 | let port4hi = state.port4hi as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.port4hi)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:47:27 [INFO] [stderr] | [INFO] [stderr] 47 | let port4lo = state.port4lo as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.port4lo)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:48:25 [INFO] [stderr] | [INFO] [stderr] 48 | let port2 = state.port2 as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.port2)` [INFO] [stderr] | [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:455:16 [INFO] [stderr] | [INFO] [stderr] 455 | let curr = state.read_byte(dst) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(dst))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:480:14 [INFO] [stderr] | [INFO] [stderr] 480 | let im = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:481:13 [INFO] [stderr] | [INFO] [stderr] 481 | let a = state.read_byte(REG_A) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(REG_A))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:490:14 [INFO] [stderr] | [INFO] [stderr] 490 | let im = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | let a = state.read_byte(REG_A) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(REG_A))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:501:17 [INFO] [stderr] | [INFO] [stderr] 501 | let value = state.read_byte(src) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:502:13 [INFO] [stderr] | [INFO] [stderr] 502 | let a = state.read_byte(REG_A) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(REG_A))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:509:41 [INFO] [stderr] | [INFO] [stderr] 509 | let result = im_result.wrapping_add(state.f as u16 & FLAG_C as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:509:58 [INFO] [stderr] | [INFO] [stderr] 509 | let result = im_result.wrapping_add(state.f as u16 & FLAG_C as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(FLAG_C)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:517:17 [INFO] [stderr] | [INFO] [stderr] 517 | let value = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:518:13 [INFO] [stderr] | [INFO] [stderr] 518 | let a = state.read_byte(REG_A) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(REG_A))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:521:41 [INFO] [stderr] | [INFO] [stderr] 521 | let result = im_result.wrapping_add(state.f as u16 & FLAG_C as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:521:58 [INFO] [stderr] | [INFO] [stderr] 521 | let result = im_result.wrapping_add(state.f as u16 & FLAG_C as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(FLAG_C)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:532:13 [INFO] [stderr] | [INFO] [stderr] 532 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:533:18 [INFO] [stderr] | [INFO] [stderr] 533 | let result = state.a as u16 ^ value as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:533:35 [INFO] [stderr] | [INFO] [stderr] 533 | let result = state.a as u16 ^ value as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:547:15 [INFO] [stderr] | [INFO] [stderr] 547 | let result = value as u16 & state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:547:30 [INFO] [stderr] | [INFO] [stderr] 547 | let result = value as u16 & state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:565:18 [INFO] [stderr] | [INFO] [stderr] 565 | let result = value as u16 | state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:565:33 [INFO] [stderr] | [INFO] [stderr] 565 | let result = value as u16 | state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:406:16 [INFO] [stderr] | [INFO] [stderr] 406 | let curr = state.read_byte(dst) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(dst))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:428:15 [INFO] [stderr] | [INFO] [stderr] 428 | let rhs = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:429:15 [INFO] [stderr] | [INFO] [stderr] 429 | let lhs = state.read_byte(REG_A) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(REG_A))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:623:18 [INFO] [stderr] | [INFO] [stderr] 623 | let result = value as u16 | state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:623:33 [INFO] [stderr] | [INFO] [stderr] 623 | let result = value as u16 | state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:440:17 [INFO] [stderr] | [INFO] [stderr] 440 | let value = state.read_dword(src) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(state.read_dword(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:626:66 [INFO] [stderr] | [INFO] [stderr] 626 | state.set_flags(FLAG_S | FLAG_AC | FLAG_Z | FLAG_P | FLAG_C, a as u16, result); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:442:42 [INFO] [stderr] | [INFO] [stderr] 442 | let result: u32 = value.wrapping_add(state.read_dword(REG_HL) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(state.read_dword(REG_HL))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:631:22 [INFO] [stderr] | [INFO] [stderr] 631 | let mut result = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:455:16 [INFO] [stderr] | [INFO] [stderr] 455 | let curr = state.read_byte(dst) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(dst))` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:651:13 [INFO] [stderr] | [INFO] [stderr] 651 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:480:14 [INFO] [stderr] | [INFO] [stderr] 480 | let im = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:481:13 [INFO] [stderr] | [INFO] [stderr] 481 | let a = state.read_byte(REG_A) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(REG_A))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:490:14 [INFO] [stderr] | [INFO] [stderr] 490 | let im = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:491:13 [INFO] [stderr] | [INFO] [stderr] 491 | let a = state.read_byte(REG_A) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(REG_A))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:501:17 [INFO] [stderr] | [INFO] [stderr] 501 | let value = state.read_byte(src) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:502:13 [INFO] [stderr] | [INFO] [stderr] 502 | let a = state.read_byte(REG_A) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(REG_A))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:509:41 [INFO] [stderr] | [INFO] [stderr] 509 | let result = im_result.wrapping_add(state.f as u16 & FLAG_C as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:509:58 [INFO] [stderr] | [INFO] [stderr] 509 | let result = im_result.wrapping_add(state.f as u16 & FLAG_C as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(FLAG_C)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:517:17 [INFO] [stderr] | [INFO] [stderr] 517 | let value = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] [INFO] [stderr] --> src/instructions.rs:670:5 [INFO] [stderr] | [INFO] [stderr] 670 | / let carry; [INFO] [stderr] 671 | | [INFO] [stderr] 672 | | if state.read_flag(FLAG_C) { [INFO] [stderr] 673 | | carry = 1; [INFO] [stderr] 674 | | } else { [INFO] [stderr] 675 | | carry = 0; [INFO] [stderr] 676 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let carry = if state.read_flag(FLAG_C) { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:667:15 [INFO] [stderr] | [INFO] [stderr] 667 | let lhs = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:668:19 [INFO] [stderr] | [INFO] [stderr] 668 | let mut rhs = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:680:18 [INFO] [stderr] | [INFO] [stderr] 680 | let answer = (state.a as u16).wrapping_sub(rhs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:518:13 [INFO] [stderr] | [INFO] [stderr] 518 | let a = state.read_byte(REG_A) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(REG_A))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:681:13 [INFO] [stderr] | [INFO] [stderr] 681 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:521:41 [INFO] [stderr] | [INFO] [stderr] 521 | let result = im_result.wrapping_add(state.f as u16 & FLAG_C as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.f)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:521:58 [INFO] [stderr] | [INFO] [stderr] 521 | let result = im_result.wrapping_add(state.f as u16 & FLAG_C as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(FLAG_C)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/instructions.rs:699:5 [INFO] [stderr] | [INFO] [stderr] 699 | / let carry; [INFO] [stderr] 700 | | [INFO] [stderr] 701 | | if state.read_flag(FLAG_C) { [INFO] [stderr] 702 | | carry = 1; [INFO] [stderr] 703 | | } else { [INFO] [stderr] 704 | | carry = 0; [INFO] [stderr] 705 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let carry = if state.read_flag(FLAG_C) { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:532:13 [INFO] [stderr] | [INFO] [stderr] 532 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:696:15 [INFO] [stderr] | [INFO] [stderr] 696 | let lhs = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:697:19 [INFO] [stderr] | [INFO] [stderr] 697 | let mut rhs = state.read_byte(src) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:709:18 [INFO] [stderr] | [INFO] [stderr] 709 | let answer = (state.a as u16).wrapping_sub(rhs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:710:13 [INFO] [stderr] | [INFO] [stderr] 710 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:533:18 [INFO] [stderr] | [INFO] [stderr] 533 | let result = state.a as u16 ^ value as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:718:17 [INFO] [stderr] | [INFO] [stderr] 718 | let value = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:533:35 [INFO] [stderr] | [INFO] [stderr] 533 | let result = state.a as u16 ^ value as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:719:13 [INFO] [stderr] | [INFO] [stderr] 719 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:546:13 [INFO] [stderr] | [INFO] [stderr] 546 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:735:17 [INFO] [stderr] | [INFO] [stderr] 735 | let value = state.read_byte(src) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:736:13 [INFO] [stderr] | [INFO] [stderr] 736 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:547:15 [INFO] [stderr] | [INFO] [stderr] 547 | let result = value as u16 & state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:547:30 [INFO] [stderr] | [INFO] [stderr] 547 | let result = value as u16 & state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:752:17 [INFO] [stderr] | [INFO] [stderr] 752 | let value = state.read_byte(src) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:753:13 [INFO] [stderr] | [INFO] [stderr] 753 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:564:13 [INFO] [stderr] | [INFO] [stderr] 564 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:565:18 [INFO] [stderr] | [INFO] [stderr] 565 | let result = value as u16 | state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:565:33 [INFO] [stderr] | [INFO] [stderr] 565 | let result = value as u16 | state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:623:18 [INFO] [stderr] | [INFO] [stderr] 623 | let result = value as u16 | state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u16::from(value)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:623:33 [INFO] [stderr] | [INFO] [stderr] 623 | let result = value as u16 | state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:626:66 [INFO] [stderr] | [INFO] [stderr] 626 | state.set_flags(FLAG_S | FLAG_AC | FLAG_Z | FLAG_P | FLAG_C, a as u16, result); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:631:22 [INFO] [stderr] | [INFO] [stderr] 631 | let mut result = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:651:13 [INFO] [stderr] | [INFO] [stderr] 651 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:775:17 [INFO] [stderr] | [INFO] [stderr] 775 | let value = state.read_byte(src) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:776:13 [INFO] [stderr] | [INFO] [stderr] 776 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/instructions.rs:670:5 [INFO] [stderr] | [INFO] [stderr] 670 | / let carry; [INFO] [stderr] 671 | | [INFO] [stderr] 672 | | if state.read_flag(FLAG_C) { [INFO] [stderr] 673 | | carry = 1; [INFO] [stderr] 674 | | } else { [INFO] [stderr] 675 | | carry = 0; [INFO] [stderr] 676 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let carry = if state.read_flag(FLAG_C) { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:667:15 [INFO] [stderr] | [INFO] [stderr] 667 | let lhs = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:668:19 [INFO] [stderr] | [INFO] [stderr] 668 | let mut rhs = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:799:47 [INFO] [stderr] | [INFO] [stderr] 799 | state.set_flags(FLAG_S | FLAG_Z | FLAG_P, a as u16, result as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:680:18 [INFO] [stderr] | [INFO] [stderr] 680 | let answer = (state.a as u16).wrapping_sub(rhs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:799:57 [INFO] [stderr] | [INFO] [stderr] 799 | state.set_flags(FLAG_S | FLAG_Z | FLAG_P, a as u16, result as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:681:13 [INFO] [stderr] | [INFO] [stderr] 681 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/instructions.rs:699:5 [INFO] [stderr] | [INFO] [stderr] 699 | / let carry; [INFO] [stderr] 700 | | [INFO] [stderr] 701 | | if state.read_flag(FLAG_C) { [INFO] [stderr] 702 | | carry = 1; [INFO] [stderr] 703 | | } else { [INFO] [stderr] 704 | | carry = 0; [INFO] [stderr] 705 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let carry = if state.read_flag(FLAG_C) { 1 } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:696:15 [INFO] [stderr] | [INFO] [stderr] 696 | let lhs = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:697:19 [INFO] [stderr] | [INFO] [stderr] 697 | let mut rhs = state.read_byte(src) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:709:18 [INFO] [stderr] | [INFO] [stderr] 709 | let answer = (state.a as u16).wrapping_sub(rhs); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:710:13 [INFO] [stderr] | [INFO] [stderr] 710 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:718:17 [INFO] [stderr] | [INFO] [stderr] 718 | let value = state.read_im_byte() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_im_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:719:13 [INFO] [stderr] | [INFO] [stderr] 719 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:735:17 [INFO] [stderr] | [INFO] [stderr] 735 | let value = state.read_byte(src) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:736:13 [INFO] [stderr] | [INFO] [stderr] 736 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:752:17 [INFO] [stderr] | [INFO] [stderr] 752 | let value = state.read_byte(src) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:753:13 [INFO] [stderr] | [INFO] [stderr] 753 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:775:17 [INFO] [stderr] | [INFO] [stderr] 775 | let value = state.read_byte(src) as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(state.read_byte(src))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:776:13 [INFO] [stderr] | [INFO] [stderr] 776 | let a = state.a as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `u16::from(state.a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:799:47 [INFO] [stderr] | [INFO] [stderr] 799 | state.set_flags(FLAG_S | FLAG_Z | FLAG_P, a as u16, result as u16); [INFO] [stderr] | ^^^^^^^^ help: try: `u16::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/instructions.rs:799:57 [INFO] [stderr] | [INFO] [stderr] 799 | state.set_flags(FLAG_S | FLAG_Z | FLAG_P, a as u16, result as u16); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(result)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `r8080`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `r8080`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "babbbdf83a3dad86ccddcec6cb6f3be154419781a7d85e82d5aa13509da1659c"` [INFO] running `"docker" "rm" "-f" "babbbdf83a3dad86ccddcec6cb6f3be154419781a7d85e82d5aa13509da1659c"` [INFO] [stdout] babbbdf83a3dad86ccddcec6cb6f3be154419781a7d85e82d5aa13509da1659c