[INFO] updating cached repository simonmnash/RustChess
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/simonmnash/RustChess
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/simonmnash/RustChess" "work/ex/clippy-test-run/sources/stable/gh/simonmnash/RustChess"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simonmnash/RustChess'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/simonmnash/RustChess" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simonmnash/RustChess"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simonmnash/RustChess'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3b8e817bca2333bc3e3d0157f00d165f7eed96ce
[INFO] sha for GitHub repo simonmnash/RustChess: 3b8e817bca2333bc3e3d0157f00d165f7eed96ce
[INFO] validating manifest of simonmnash/RustChess on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of simonmnash/RustChess on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing simonmnash/RustChess
[INFO] finished frobbing simonmnash/RustChess
[INFO] frobbed toml for simonmnash/RustChess written to work/ex/clippy-test-run/sources/stable/gh/simonmnash/RustChess/Cargo.toml
[INFO] started frobbing simonmnash/RustChess
[INFO] finished frobbing simonmnash/RustChess
[INFO] frobbed toml for simonmnash/RustChess written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simonmnash/RustChess/Cargo.toml
[INFO] crate simonmnash/RustChess has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting simonmnash/RustChess against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/simonmnash/RustChess:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 0be6f7a65f19cfcd82461ef42c0208f70cc9e731cd41b0c7b8ded2f933bfdfa2
[INFO] running `"docker" "start" "-a" "0be6f7a65f19cfcd82461ef42c0208f70cc9e731cd41b0c7b8ded2f933bfdfa2"`
[INFO] [stderr]    Compiling libc v0.2.29
[INFO] [stderr]    Compiling serde_json v0.9.10
[INFO] [stderr]     Checking shared_library v0.1.7
[INFO] [stderr]     Checking deflate v0.7.14
[INFO] [stderr]     Checking tempfile v2.1.6
[INFO] [stderr]     Checking rayon-core v1.2.1
[INFO] [stderr]     Checking pistoncore-input v0.18.0
[INFO] [stderr]     Checking piston2d-graphics v0.21.1
[INFO] [stderr]     Checking x11-dl v2.14.0
[INFO] [stderr]    Compiling gl v0.6.3
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]     Checking rusttype v0.2.1
[INFO] [stderr]     Checking fs2 v0.2.5
[INFO] [stderr]    Compiling rand v0.3.16
[INFO] [stderr]     Checking rayon v0.8.2
[INFO] [stderr]     Checking png v0.9.0
[INFO] [stderr]     Checking memmap v0.4.0
[INFO] [stderr]     Checking pistoncore-window v0.27.0
[INFO] [stderr]    Compiling phf_generator v0.7.21
[INFO] [stderr]    Compiling phf_codegen v0.7.21
[INFO] [stderr]     Checking pistoncore-event_loop v0.32.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]    Compiling target_build_utils v0.3.1
[INFO] [stderr]     Checking piston v0.32.0
[INFO] [stderr]     Checking image v0.15.0
[INFO] [stderr]     Checking piston2d-opengl_graphics v0.46.0
[INFO] [stderr]    Compiling libloading v0.3.4
[INFO] [stderr]     Checking dlib v0.3.1
[INFO] [stderr]     Checking wayland-sys v0.9.9
[INFO] [stderr]     Checking wayland-client v0.9.9
[INFO] [stderr]     Checking wayland-window v0.6.1
[INFO] [stderr]     Checking wayland-kbd v0.9.1
[INFO] [stderr]     Checking winit v0.7.5
[INFO] [stderr]     Checking glutin v0.9.2
[INFO] [stderr]     Checking pistoncore-glutin_window v0.38.0
[INFO] [stderr]     Checking chess v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gameboard_controller.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             gameboard: gameboard,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gameboard`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gameboard_view.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             settings: settings,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gameboard_controller.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             gameboard: gameboard,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gameboard`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/gameboard_view.rs:72:13
[INFO] [stderr]    |
[INFO] [stderr] 72 |             settings: settings,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/gameboard.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 | /                 if ind[1] == 6 {
[INFO] [stderr] 92 | |                     if self.check_against_board_edge(ind[0] as i32, (ind[1] as i32) - 2) {
[INFO] [stderr] 93 | |                         let two_forward = [ind[0], ind[1] - 2];
[INFO] [stderr] 94 | |                         vec.push(two_forward);
[INFO] [stderr] 95 | |                     }
[INFO] [stderr] 96 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 91 |                 if ind[1] == 6 && self.check_against_board_edge(ind[0] as i32, (ind[1] as i32) - 2) {
[INFO] [stderr] 92 |     let two_forward = [ind[0], ind[1] - 2];
[INFO] [stderr] 93 |     vec.push(two_forward);
[INFO] [stderr] 94 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]   --> src/gameboard.rs:91:17
[INFO] [stderr]    |
[INFO] [stderr] 91 | /                 if ind[1] == 6 {
[INFO] [stderr] 92 | |                     if self.check_against_board_edge(ind[0] as i32, (ind[1] as i32) - 2) {
[INFO] [stderr] 93 | |                         let two_forward = [ind[0], ind[1] - 2];
[INFO] [stderr] 94 | |                         vec.push(two_forward);
[INFO] [stderr] 95 | |                     }
[INFO] [stderr] 96 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 91 |                 if ind[1] == 6 && self.check_against_board_edge(ind[0] as i32, (ind[1] as i32) - 2) {
[INFO] [stderr] 92 |     let two_forward = [ind[0], ind[1] - 2];
[INFO] [stderr] 93 |     vec.push(two_forward);
[INFO] [stderr] 94 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tile_ownership`
[INFO] [stderr]   --> src/gameboard_controller.rs:60:21
[INFO] [stderr]    |
[INFO] [stderr] 60 |                 let tile_ownership = self.gameboard.check_tile_ownership([cell_x, cell_y]);
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^ help: consider using `_tile_ownership` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard::Gameboard`
[INFO] [stderr]   --> src/gameboard.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() ->Gameboard {
[INFO] [stderr] 17 | |         Gameboard {
[INFO] [stderr] 18 | |             perspective: false,
[INFO] [stderr] 19 | |             cells: [[7, 3, 5, 9, 11, 2, 3, 7],
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |         }
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/gameboard.rs:61:14
[INFO] [stderr]    |
[INFO] [stderr] 61 |           else if value % 2 ==0 {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 62 | |             true
[INFO] [stderr] 63 | |         }
[INFO] [stderr] 64 | |         else {
[INFO] [stderr] 65 | |             false
[INFO] [stderr] 66 | |         }
[INFO] [stderr]    | |_________^ help: you can reduce it to: `value % 2 ==0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/gameboard.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 | /         if x>7 || y>7 || x<0 || y<0 {
[INFO] [stderr] 71 | |             false
[INFO] [stderr] 72 | |         }
[INFO] [stderr] 73 | |         else {
[INFO] [stderr] 74 | |             true
[INFO] [stderr] 75 | |         }
[INFO] [stderr]    | |_________^ help: you can reduce it to: `!(x>7 || y>7 || x<0 || y<0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(ind[1] as i32)`
[INFO] [stderr]    --> src/gameboard.rs:130:71
[INFO] [stderr]     |
[INFO] [stderr] 130 |                 if self.check_against_board_edge((ind[0] as i32) + 1, (ind[1] as i32) + 0) {
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ind[1]`
[INFO] [stderr]    --> src/gameboard.rs:131:43
[INFO] [stderr]     |
[INFO] [stderr] 131 |                     vec.push([ind[0] + 1, ind[1] + 0]);
[INFO] [stderr]     |                                           ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(ind[0] as i32)`
[INFO] [stderr]    --> src/gameboard.rs:136:50
[INFO] [stderr]     |
[INFO] [stderr] 136 |                 if self.check_against_board_edge((ind[0] as i32) + 0, (ind[1] as i32) + 1) {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ind[0]`
[INFO] [stderr]    --> src/gameboard.rs:137:31
[INFO] [stderr]     |
[INFO] [stderr] 137 |                     vec.push([ind[0] + 0, ind[1] + 1]);
[INFO] [stderr]     |                               ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(ind[0] as i32)`
[INFO] [stderr]    --> src/gameboard.rs:139:50
[INFO] [stderr]     |
[INFO] [stderr] 139 |                 if self.check_against_board_edge((ind[0] as i32) + 0, (ind[1] as i32) - 1) {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ind[0]`
[INFO] [stderr]    --> src/gameboard.rs:140:31
[INFO] [stderr]     |
[INFO] [stderr] 140 |                     vec.push([ind[0] + 0, ind[1] - 1]);
[INFO] [stderr]     |                               ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(ind[1] as i32)`
[INFO] [stderr]    --> src/gameboard.rs:145:70
[INFO] [stderr]     |
[INFO] [stderr] 145 |                 if self.check_against_board_edge((ind[0] as i32) -1, (ind[1] as i32) + 0) {
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ind[1]`
[INFO] [stderr]    --> src/gameboard.rs:146:43
[INFO] [stderr]     |
[INFO] [stderr] 146 |                     vec.push([ind[0] - 1, ind[1] + 0]);
[INFO] [stderr]     |                                           ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/gameboard_controller.rs:46:20
[INFO] [stderr]    |
[INFO] [stderr] 46 |                 if self.legal_moves.len()>0{
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.legal_moves.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: variable `A` should have a snake case name such as `a`
[INFO] [stderr]   --> src/gameboard_controller.rs:49:42
[INFO] [stderr]    |
[INFO] [stderr] 49 |                             if let Some (A) = self.selected_cell{
[INFO] [stderr]    |                                          ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard_view::GameboardViewSettings`
[INFO] [stderr]   --> src/gameboard_view.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 | /     pub fn new() -> GameboardViewSettings {
[INFO] [stderr] 43 | |         GameboardViewSettings {
[INFO] [stderr] 44 | |             position: [10.0; 2],
[INFO] [stderr] 45 | |             size: 400.0,
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |         }
[INFO] [stderr] 59 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/gameboard_view.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let ref settings = self.settings;
[INFO] [stderr]    |         ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/gameboard_view.rs:103:61
[INFO] [stderr]     |
[INFO] [stderr] 103 |                     settings.position[0]+(settings.size/8.0*j as f64), settings.position[1]+(settings.size/8.0*i as f64),
[INFO] [stderr]     |                                                             ^^^^^^^^ help: try: `f64::from(j)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/gameboard_view.rs:103:112
[INFO] [stderr]     |
[INFO] [stderr] 103 |                     settings.position[0]+(settings.size/8.0*j as f64), settings.position[1]+(settings.size/8.0*i as f64),
[INFO] [stderr]     |                                                                                                                ^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/gameboard_view.rs:158:44
[INFO] [stderr]     |
[INFO] [stderr] 158 |             let x = settings.position[0] + i as f64 / 8.0 * settings.size;
[INFO] [stderr]     |                                            ^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/gameboard_view.rs:159:44
[INFO] [stderr]     |
[INFO] [stderr] 159 |             let y = settings.position[1] + i as f64 / 8.0 * settings.size;
[INFO] [stderr]     |                                            ^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let ref mut glyphs = GlyphCache::new("assets/FiraSans-Regular.ttf", texture_settings)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let glyphs = &mut GlyphCache::new("assets/FiraSans-Regular.ttf", texture_settings)
[INFO] [stderr] 37 |         .expect("Could not load font");
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `tile_ownership`
[INFO] [stderr]   --> src/gameboard_controller.rs:60:21
[INFO] [stderr]    |
[INFO] [stderr] 60 |                 let tile_ownership = self.gameboard.check_tile_ownership([cell_x, cell_y]);
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^ help: consider using `_tile_ownership` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard::Gameboard`
[INFO] [stderr]   --> src/gameboard.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 | /     pub fn new() ->Gameboard {
[INFO] [stderr] 17 | |         Gameboard {
[INFO] [stderr] 18 | |             perspective: false,
[INFO] [stderr] 19 | |             cells: [[7, 3, 5, 9, 11, 2, 3, 7],
[INFO] [stderr] ...  |
[INFO] [stderr] 28 | |         }
[INFO] [stderr] 29 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 6  | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/gameboard.rs:61:14
[INFO] [stderr]    |
[INFO] [stderr] 61 |           else if value % 2 ==0 {
[INFO] [stderr]    |  ______________^
[INFO] [stderr] 62 | |             true
[INFO] [stderr] 63 | |         }
[INFO] [stderr] 64 | |         else {
[INFO] [stderr] 65 | |             false
[INFO] [stderr] 66 | |         }
[INFO] [stderr]    | |_________^ help: you can reduce it to: `value % 2 ==0`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]   --> src/gameboard.rs:70:9
[INFO] [stderr]    |
[INFO] [stderr] 70 | /         if x>7 || y>7 || x<0 || y<0 {
[INFO] [stderr] 71 | |             false
[INFO] [stderr] 72 | |         }
[INFO] [stderr] 73 | |         else {
[INFO] [stderr] 74 | |             true
[INFO] [stderr] 75 | |         }
[INFO] [stderr]    | |_________^ help: you can reduce it to: `!(x>7 || y>7 || x<0 || y<0)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(ind[1] as i32)`
[INFO] [stderr]    --> src/gameboard.rs:130:71
[INFO] [stderr]     |
[INFO] [stderr] 130 |                 if self.check_against_board_edge((ind[0] as i32) + 1, (ind[1] as i32) + 0) {
[INFO] [stderr]     |                                                                       ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_op)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ind[1]`
[INFO] [stderr]    --> src/gameboard.rs:131:43
[INFO] [stderr]     |
[INFO] [stderr] 131 |                     vec.push([ind[0] + 1, ind[1] + 0]);
[INFO] [stderr]     |                                           ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(ind[0] as i32)`
[INFO] [stderr]    --> src/gameboard.rs:136:50
[INFO] [stderr]     |
[INFO] [stderr] 136 |                 if self.check_against_board_edge((ind[0] as i32) + 0, (ind[1] as i32) + 1) {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ind[0]`
[INFO] [stderr]    --> src/gameboard.rs:137:31
[INFO] [stderr]     |
[INFO] [stderr] 137 |                     vec.push([ind[0] + 0, ind[1] + 1]);
[INFO] [stderr]     |                               ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(ind[0] as i32)`
[INFO] [stderr]    --> src/gameboard.rs:139:50
[INFO] [stderr]     |
[INFO] [stderr] 139 |                 if self.check_against_board_edge((ind[0] as i32) + 0, (ind[1] as i32) - 1) {
[INFO] [stderr]     |                                                  ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ind[0]`
[INFO] [stderr]    --> src/gameboard.rs:140:31
[INFO] [stderr]     |
[INFO] [stderr] 140 |                     vec.push([ind[0] + 0, ind[1] - 1]);
[INFO] [stderr]     |                               ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(ind[1] as i32)`
[INFO] [stderr]    --> src/gameboard.rs:145:70
[INFO] [stderr]     |
[INFO] [stderr] 145 |                 if self.check_against_board_edge((ind[0] as i32) -1, (ind[1] as i32) + 0) {
[INFO] [stderr]     |                                                                      ^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `ind[1]`
[INFO] [stderr]    --> src/gameboard.rs:146:43
[INFO] [stderr]     |
[INFO] [stderr] 146 |                     vec.push([ind[0] - 1, ind[1] + 0]);
[INFO] [stderr]     |                                           ^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/gameboard_controller.rs:46:20
[INFO] [stderr]    |
[INFO] [stderr] 46 |                 if self.legal_moves.len()>0{
[INFO] [stderr]    |                    ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.legal_moves.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: variable `A` should have a snake case name such as `a`
[INFO] [stderr]   --> src/gameboard_controller.rs:49:42
[INFO] [stderr]    |
[INFO] [stderr] 49 |                             if let Some (A) = self.selected_cell{
[INFO] [stderr]    |                                          ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_snake_case)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard_view::GameboardViewSettings`
[INFO] [stderr]   --> src/gameboard_view.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 | /     pub fn new() -> GameboardViewSettings {
[INFO] [stderr] 43 | |         GameboardViewSettings {
[INFO] [stderr] 44 | |             position: [10.0; 2],
[INFO] [stderr] 45 | |             size: 400.0,
[INFO] [stderr] ...  |
[INFO] [stderr] 58 | |         }
[INFO] [stderr] 59 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 10 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/gameboard_view.rs:87:13
[INFO] [stderr]    |
[INFO] [stderr] 87 |         let ref settings = self.settings;
[INFO] [stderr]    |         ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/gameboard_view.rs:103:61
[INFO] [stderr]     |
[INFO] [stderr] 103 |                     settings.position[0]+(settings.size/8.0*j as f64), settings.position[1]+(settings.size/8.0*i as f64),
[INFO] [stderr]     |                                                             ^^^^^^^^ help: try: `f64::from(j)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/gameboard_view.rs:103:112
[INFO] [stderr]     |
[INFO] [stderr] 103 |                     settings.position[0]+(settings.size/8.0*j as f64), settings.position[1]+(settings.size/8.0*i as f64),
[INFO] [stderr]     |                                                                                                                ^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/gameboard_view.rs:158:44
[INFO] [stderr]     |
[INFO] [stderr] 158 |             let x = settings.position[0] + i as f64 / 8.0 * settings.size;
[INFO] [stderr]     |                                            ^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/gameboard_view.rs:159:44
[INFO] [stderr]     |
[INFO] [stderr] 159 |             let y = settings.position[1] + i as f64 / 8.0 * settings.size;
[INFO] [stderr]     |                                            ^^^^^^^^ help: try: `f64::from(i)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/main.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let ref mut glyphs = GlyphCache::new("assets/FiraSans-Regular.ttf", texture_settings)
[INFO] [stderr]    |         ^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 36 |     let glyphs = &mut GlyphCache::new("assets/FiraSans-Regular.ttf", texture_settings)
[INFO] [stderr] 37 |         .expect("Could not load font");
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 36.18s
[INFO] running `"docker" "inspect" "0be6f7a65f19cfcd82461ef42c0208f70cc9e731cd41b0c7b8ded2f933bfdfa2"`
[INFO] running `"docker" "rm" "-f" "0be6f7a65f19cfcd82461ef42c0208f70cc9e731cd41b0c7b8ded2f933bfdfa2"`
[INFO] [stdout] 0be6f7a65f19cfcd82461ef42c0208f70cc9e731cd41b0c7b8ded2f933bfdfa2