[INFO] updating cached repository simonhdickson/rcc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/simonhdickson/rcc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/simonhdickson/rcc" "work/ex/clippy-test-run/sources/stable/gh/simonhdickson/rcc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simonhdickson/rcc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/simonhdickson/rcc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simonhdickson/rcc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simonhdickson/rcc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f922176836ce4f549f62f26863002d42de06670b [INFO] sha for GitHub repo simonhdickson/rcc: f922176836ce4f549f62f26863002d42de06670b [INFO] validating manifest of simonhdickson/rcc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simonhdickson/rcc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simonhdickson/rcc [INFO] finished frobbing simonhdickson/rcc [INFO] frobbed toml for simonhdickson/rcc written to work/ex/clippy-test-run/sources/stable/gh/simonhdickson/rcc/Cargo.toml [INFO] started frobbing simonhdickson/rcc [INFO] finished frobbing simonhdickson/rcc [INFO] frobbed toml for simonhdickson/rcc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simonhdickson/rcc/Cargo.toml [INFO] crate simonhdickson/rcc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simonhdickson/rcc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/simonhdickson/rcc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1a0e9c800cc027368d99546b11b8e481275d53cdde94f3063edd7c85815e6898 [INFO] running `"docker" "start" "-a" "1a0e9c800cc027368d99546b11b8e481275d53cdde94f3063edd7c85815e6898"` [INFO] [stderr] Checking rcc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/integration_test.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | f.write_all($content.as_bytes()).expect("something went wrong writing the file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 73 | / compiler_test_valid!(constant_only, r" [INFO] [stderr] 74 | | int main() { [INFO] [stderr] 75 | | return 2; [INFO] [stderr] 76 | | }"); [INFO] [stderr] | |____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 19 | f.write_all(br" [INFO] [stderr] 20 | int main() { [INFO] [stderr] 21 | return 2; [INFO] [stderr] 22 | }").expect("something went wrong writing the file"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/integration_test.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | f.write_all($content.as_bytes()).expect("something went wrong writing the file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `br"int main() { return 0; }"` [INFO] [stderr] ... [INFO] [stderr] 79 | compiler_test_valid!(one_line, r"int main() { return 0; }"); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/integration_test.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | f.write_all($content.as_bytes()).expect("something went wrong writing the file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 81 | / compiler_test_valid!(not_zero, r"int main() { [INFO] [stderr] 82 | | return !5; [INFO] [stderr] 83 | | }"); [INFO] [stderr] | |____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 19 | f.write_all(br"int main() { [INFO] [stderr] 20 | return !5; [INFO] [stderr] 21 | }").expect("something went wrong writing the file"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/integration_test.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | f.write_all($content.as_bytes()).expect("something went wrong writing the file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 85 | / compiler_test_valid!(bitwise, r"int main() { [INFO] [stderr] 86 | | return !12; [INFO] [stderr] 87 | | }"); [INFO] [stderr] | |____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 19 | f.write_all(br"int main() { [INFO] [stderr] 20 | return !12; [INFO] [stderr] 21 | }").expect("something went wrong writing the file"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> tests/integration_test.rs:19:25 [INFO] [stderr] | [INFO] [stderr] 19 | f.write_all($content.as_bytes()).expect("something went wrong writing the file"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 89 | / compiler_test_valid!(nested_ops, r"int main() { [INFO] [stderr] 90 | | return !-3; [INFO] [stderr] 91 | | }"); [INFO] [stderr] | |____- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] help: consider using a byte string literal instead [INFO] [stderr] | [INFO] [stderr] 19 | f.write_all(br"int main() { [INFO] [stderr] 20 | return !-3; [INFO] [stderr] 21 | }").expect("something went wrong writing the file"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/ast.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | fn parse_statement<'a>(tokens: &mut Iterator) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/ast.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | fn parse_expression<'a>(tokens: &mut Iterator) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lex.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | Some(ch @ _) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `ident @ _` pattern can be written as just `ident` [INFO] [stderr] --> src/lex.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | ident @ _ => Token::Ident(ident.to_owned()) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/ast.rs:78:20 [INFO] [stderr] | [INFO] [stderr] 78 | fn parse_statement<'a>(tokens: &mut Iterator) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/ast.rs:93:21 [INFO] [stderr] | [INFO] [stderr] 93 | fn parse_expression<'a>(tokens: &mut Iterator) -> Result { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: the `ch @ _` pattern can be written as just `ch` [INFO] [stderr] --> src/lex.rs:46:14 [INFO] [stderr] | [INFO] [stderr] 46 | Some(ch @ _) => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `ident @ _` pattern can be written as just `ident` [INFO] [stderr] --> src/lex.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | ident @ _ => Token::Ident(ident.to_owned()) [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.37s [INFO] running `"docker" "inspect" "1a0e9c800cc027368d99546b11b8e481275d53cdde94f3063edd7c85815e6898"` [INFO] running `"docker" "rm" "-f" "1a0e9c800cc027368d99546b11b8e481275d53cdde94f3063edd7c85815e6898"` [INFO] [stdout] 1a0e9c800cc027368d99546b11b8e481275d53cdde94f3063edd7c85815e6898