[INFO] updating cached repository simongibbons/efficient_route_planning [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/simongibbons/efficient_route_planning [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/simongibbons/efficient_route_planning" "work/ex/clippy-test-run/sources/stable/gh/simongibbons/efficient_route_planning"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simongibbons/efficient_route_planning'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/simongibbons/efficient_route_planning" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simongibbons/efficient_route_planning"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simongibbons/efficient_route_planning'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2b8705f30a8a214e50c0de056a50ff576c7b9632 [INFO] sha for GitHub repo simongibbons/efficient_route_planning: 2b8705f30a8a214e50c0de056a50ff576c7b9632 [INFO] validating manifest of simongibbons/efficient_route_planning on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simongibbons/efficient_route_planning on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simongibbons/efficient_route_planning [INFO] finished frobbing simongibbons/efficient_route_planning [INFO] frobbed toml for simongibbons/efficient_route_planning written to work/ex/clippy-test-run/sources/stable/gh/simongibbons/efficient_route_planning/Cargo.toml [INFO] started frobbing simongibbons/efficient_route_planning [INFO] finished frobbing simongibbons/efficient_route_planning [INFO] frobbed toml for simongibbons/efficient_route_planning written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simongibbons/efficient_route_planning/Cargo.toml [INFO] crate simongibbons/efficient_route_planning has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simongibbons/efficient_route_planning against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/simongibbons/efficient_route_planning:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37d4c946b5a2f25da7be52c93b57597a02f137bc22d4ce40eff846ec4c0c398c [INFO] running `"docker" "start" "-a" "37d4c946b5a2f25da7be52c93b57597a02f137bc22d4ce40eff846ec4c0c398c"` [INFO] [stderr] Compiling cgmath v0.16.0 [INFO] [stderr] Checking pdqselect v0.1.0 [INFO] [stderr] Checking clamp v0.1.0 [INFO] [stderr] Checking smallvec v0.3.3 [INFO] [stderr] Checking serde v1.0.27 [INFO] [stderr] Checking xml-rs v0.3.6 [INFO] [stderr] Checking alga v0.5.2 [INFO] [stderr] Checking num-bigint v0.1.41 [INFO] [stderr] Checking generic-array v0.8.3 [INFO] [stderr] Checking num-rational v0.1.41 [INFO] [stderr] Checking num v0.1.41 [INFO] [stderr] Checking nalgebra v0.13.1 [INFO] [stderr] Checking serde-xml-rs v0.2.1 [INFO] [stderr] Checking spade v1.3.0 [INFO] [stderr] Checking geo v0.7.1 [INFO] [stderr] Checking efficient_route_planning v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connected_components.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return state.result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `state.result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/connected_components.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | return state.result; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `state.result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/osm_reader.rs:184:20 [INFO] [stderr] | [INFO] [stderr] 184 | assert_eq!(470558, osm_node.id); [INFO] [stderr] | ^^^^^^ help: consider: `470_558` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/osm_reader.rs:200:20 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(26659127, osm_way.id); [INFO] [stderr] | ^^^^^^^^ help: consider: `26_659_127` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/osm_reader.rs:203:20 [INFO] [stderr] | [INFO] [stderr] 203 | assert_eq!(292403538, osm_way.nodes[0].ref_); [INFO] [stderr] | ^^^^^^^^^ help: consider: `292_403_538` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/connected_components.rs:73:11 [INFO] [stderr] | [INFO] [stderr] 73 | while stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `road_network::RoadNetwork` [INFO] [stderr] --> src/road_network.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> Self { [INFO] [stderr] 55 | | RoadNetwork {nodes: HashMap::new()} [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/road_network.rs:122:27 [INFO] [stderr] | [INFO] [stderr] 122 | .map(|(k, _)| k.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/road_network_builder.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | nodes: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[OsmNode]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/road_network_builder.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | ways: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[OsmWay]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/osm_reader.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 36 | | use self::HighwayType::*; [INFO] [stderr] 37 | | match s { [INFO] [stderr] 38 | | "motorway" => Some(Motorway), [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/shortest_path.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | current_node = *previous_nodes.get(¤t_node.unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&previous_nodes[¤t_node.unwrap()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/connected_components.rs:73:11 [INFO] [stderr] | [INFO] [stderr] 73 | while stack.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!stack.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `road_network::RoadNetwork` [INFO] [stderr] --> src/road_network.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | / pub fn new() -> Self { [INFO] [stderr] 55 | | RoadNetwork {nodes: HashMap::new()} [INFO] [stderr] 56 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 47 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/road_network.rs:122:27 [INFO] [stderr] | [INFO] [stderr] 122 | .map(|(k, _)| k.clone()) [INFO] [stderr] | ^^^^^^^^^ help: try dereferencing it: `*k` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/road_network_builder.rs:22:32 [INFO] [stderr] | [INFO] [stderr] 22 | nodes: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[OsmNode]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/road_network_builder.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | ways: &Vec) -> Result> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[OsmWay]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/osm_reader.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | / pub fn from_str(s: &str) -> Option { [INFO] [stderr] 36 | | use self::HighwayType::*; [INFO] [stderr] 37 | | match s { [INFO] [stderr] 38 | | "motorway" => Some(Motorway), [INFO] [stderr] ... | [INFO] [stderr] 54 | | } [INFO] [stderr] 55 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/shortest_path.rs:98:25 [INFO] [stderr] | [INFO] [stderr] 98 | current_node = *previous_nodes.get(¤t_node.unwrap()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&previous_nodes[¤t_node.unwrap()]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 55.99s [INFO] running `"docker" "inspect" "37d4c946b5a2f25da7be52c93b57597a02f137bc22d4ce40eff846ec4c0c398c"` [INFO] running `"docker" "rm" "-f" "37d4c946b5a2f25da7be52c93b57597a02f137bc22d4ce40eff846ec4c0c398c"` [INFO] [stdout] 37d4c946b5a2f25da7be52c93b57597a02f137bc22d4ce40eff846ec4c0c398c