[INFO] updating cached repository simongibbons/advent_of_code_2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/simongibbons/advent_of_code_2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/simongibbons/advent_of_code_2018" "work/ex/clippy-test-run/sources/stable/gh/simongibbons/advent_of_code_2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simongibbons/advent_of_code_2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/simongibbons/advent_of_code_2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simongibbons/advent_of_code_2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simongibbons/advent_of_code_2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd42e1da658ee84a02dd67ec1762cab70b726004 [INFO] sha for GitHub repo simongibbons/advent_of_code_2018: bd42e1da658ee84a02dd67ec1762cab70b726004 [INFO] validating manifest of simongibbons/advent_of_code_2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simongibbons/advent_of_code_2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simongibbons/advent_of_code_2018 [INFO] finished frobbing simongibbons/advent_of_code_2018 [INFO] frobbed toml for simongibbons/advent_of_code_2018 written to work/ex/clippy-test-run/sources/stable/gh/simongibbons/advent_of_code_2018/Cargo.toml [INFO] started frobbing simongibbons/advent_of_code_2018 [INFO] finished frobbing simongibbons/advent_of_code_2018 [INFO] frobbed toml for simongibbons/advent_of_code_2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simongibbons/advent_of_code_2018/Cargo.toml [INFO] crate simongibbons/advent_of_code_2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simongibbons/advent_of_code_2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/simongibbons/advent_of_code_2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 513925c4876419a9a8b1cfc84b76e490b4109e6f7dc80dc08eca1e769de7e42a [INFO] running `"docker" "start" "-a" "513925c4876419a9a8b1cfc84b76e490b4109e6f7dc80dc08eca1e769de7e42a"` [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Checking memchr v2.1.1 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking advent_of_code_2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day2.rs:13:30 [INFO] [stderr] | [INFO] [stderr] 13 | fn get_matching_ids(box_ids: &Vec) -> Option<(String, String)> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/day2.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | fn count_differences(s1: &String, s2: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/day2.rs:34:39 [INFO] [stderr] | [INFO] [stderr] 34 | fn count_differences(s1: &String, s2: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day2.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | fn checksum(box_ids: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day2.rs:13:30 [INFO] [stderr] | [INFO] [stderr] 13 | fn get_matching_ids(box_ids: &Vec) -> Option<(String, String)> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/day2.rs:34:26 [INFO] [stderr] | [INFO] [stderr] 34 | fn count_differences(s1: &String, s2: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/day2.rs:34:39 [INFO] [stderr] | [INFO] [stderr] 34 | fn count_differences(s1: &String, s2: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day2.rs:47:22 [INFO] [stderr] | [INFO] [stderr] 47 | fn checksum(box_ids: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day1.rs:34:57 [INFO] [stderr] | [INFO] [stderr] 34 | fn find_first_frequency_visited_twice(frequency_shifts: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/day5.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | fn _react(polymer: &String) -> (String, bool) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/bin/day5.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | fn _react(polymer: &String) -> (String, bool) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/day5.rs:63:8 [INFO] [stderr] | [INFO] [stderr] 63 | if polymer.len() > 0 && !skip { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!polymer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/day5.rs:63:8 [INFO] [stderr] | [INFO] [stderr] 63 | if polymer.len() > 0 && !skip { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!polymer.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day1.rs:34:57 [INFO] [stderr] | [INFO] [stderr] 34 | fn find_first_frequency_visited_twice(frequency_shifts: &Vec) -> Option { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[i64]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day3.rs:24:37 [INFO] [stderr] | [INFO] [stderr] 24 | fn multiply_claimed_squares(claims: &Vec) -> HashSet<(u32, u32)> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/day3.rs:24:37 [INFO] [stderr] | [INFO] [stderr] 24 | fn multiply_claimed_squares(claims: &Vec) -> HashSet<(u32, u32)> { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Claim]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 10.25s [INFO] running `"docker" "inspect" "513925c4876419a9a8b1cfc84b76e490b4109e6f7dc80dc08eca1e769de7e42a"` [INFO] running `"docker" "rm" "-f" "513925c4876419a9a8b1cfc84b76e490b4109e6f7dc80dc08eca1e769de7e42a"` [INFO] [stdout] 513925c4876419a9a8b1cfc84b76e490b4109e6f7dc80dc08eca1e769de7e42a