[INFO] updating cached repository simmons/webrtc-demo-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/simmons/webrtc-demo-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/simmons/webrtc-demo-server" "work/ex/clippy-test-run/sources/stable/gh/simmons/webrtc-demo-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simmons/webrtc-demo-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/simmons/webrtc-demo-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simmons/webrtc-demo-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simmons/webrtc-demo-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ebb53e1f87abd4e680b68b304078cc681c539826 [INFO] sha for GitHub repo simmons/webrtc-demo-server: ebb53e1f87abd4e680b68b304078cc681c539826 [INFO] validating manifest of simmons/webrtc-demo-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simmons/webrtc-demo-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simmons/webrtc-demo-server [INFO] finished frobbing simmons/webrtc-demo-server [INFO] frobbed toml for simmons/webrtc-demo-server written to work/ex/clippy-test-run/sources/stable/gh/simmons/webrtc-demo-server/Cargo.toml [INFO] started frobbing simmons/webrtc-demo-server [INFO] finished frobbing simmons/webrtc-demo-server [INFO] frobbed toml for simmons/webrtc-demo-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simmons/webrtc-demo-server/Cargo.toml [INFO] crate simmons/webrtc-demo-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simmons/webrtc-demo-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/simmons/webrtc-demo-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c0b491345390167ee8bbe0e18e4b5b2240b5658fa35262738b3da596ad2e22a [INFO] running `"docker" "start" "-a" "9c0b491345390167ee8bbe0e18e4b5b2240b5658fa35262738b3da596ad2e22a"` [INFO] [stderr] Compiling woothee v0.8.0 [INFO] [stderr] Checking termcolor v1.0.2 [INFO] [stderr] Checking lazycell v1.0.0 [INFO] [stderr] Compiling actix-web v0.7.4 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Compiling ring v0.13.2 [INFO] [stderr] Compiling miniz-sys v0.1.10 [INFO] [stderr] Compiling rand v0.4.3 [INFO] [stderr] Checking mio v0.6.15 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking tokio-io v0.1.8 [INFO] [stderr] Checking serde_json v1.0.26 [INFO] [stderr] Checking serde_urlencoded v0.5.3 [INFO] [stderr] Checking regex v1.0.4 [INFO] [stderr] Compiling serde_derive v1.0.75 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking tokio-threadpool v0.1.6 [INFO] [stderr] Checking mio-uds v0.6.6 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking tokio-reactor v0.1.4 [INFO] [stderr] Checking h2 v0.1.12 [INFO] [stderr] Compiling phf_generator v0.7.22 [INFO] [stderr] Checking flate2 v1.0.2 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Compiling phf_codegen v0.7.22 [INFO] [stderr] Checking tokio-uds v0.2.1 [INFO] [stderr] Checking tokio-tcp v0.1.1 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-signal v0.2.4 [INFO] [stderr] Checking env_logger v0.5.12 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio v0.1.8 [INFO] [stderr] Checking trust-dns-proto v0.4.0 [INFO] [stderr] Checking cookie v0.11.0 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Compiling derive-error-chain v0.10.1 [INFO] [stderr] Checking trust-dns-resolver v0.9.1 [INFO] [stderr] Checking dotenv v0.10.1 [INFO] [stderr] Checking actix v0.7.3 [INFO] [stderr] Checking webrtc-demo-server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: cannot find type `ConnectResponse` in this scope [INFO] [stderr] --> src/lobby.rs:78:10 [INFO] [stderr] | [INFO] [stderr] 78 | #[derive(Message)] [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = note: #[warn(proc_macro_derive_resolution_fallback)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: cannot find type `ConnectResponse` in this scope [INFO] [stderr] --> src/lobby.rs:78:10 [INFO] [stderr] | [INFO] [stderr] 78 | #[derive(Message)] [INFO] [stderr] | ^^^^^^^ names from parent modules are not accessible without an explicit import [INFO] [stderr] | [INFO] [stderr] = note: #[warn(proc_macro_derive_resolution_fallback)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #50504 [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | .map(|s| simplify_user_agent(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `simplify_user_agent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/client.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | / fn simplify_user_agent<'a>(user_agent: Cow<'a,str>) -> Cow<'a,str>{ [INFO] [stderr] 67 | | let parser = ::woothee::parser::Parser::new(); [INFO] [stderr] 68 | | if let Some(ua) = parser.parse(&user_agent) { [INFO] [stderr] 69 | | Cow::Owned(format!("{} {} {}\n{} {}", ua.vendor, ua.name, ua.version, ua.os, ua.os_version)) [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lobby.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | for (_, client) in &self.clients { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 40 | for client in self.clients.values() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/names.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | if word.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | if let Err(_) = ::std::env::var("RUST_LOG") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 53 | | ::std::env::set_var( [INFO] [stderr] 54 | | "RUST_LOG", [INFO] [stderr] 55 | | "actix=info,actix_web=info,webrtc_demo_server=trace", [INFO] [stderr] 56 | | ); [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____- help: try this: `if ::std::env::var("RUST_LOG").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/client.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | .map(|s| simplify_user_agent(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `simplify_user_agent` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/client.rs:66:1 [INFO] [stderr] | [INFO] [stderr] 66 | / fn simplify_user_agent<'a>(user_agent: Cow<'a,str>) -> Cow<'a,str>{ [INFO] [stderr] 67 | | let parser = ::woothee::parser::Parser::new(); [INFO] [stderr] 68 | | if let Some(ua) = parser.parse(&user_agent) { [INFO] [stderr] 69 | | Cow::Owned(format!("{} {} {}\n{} {}", ua.vendor, ua.name, ua.version, ua.os, ua.os_version)) [INFO] [stderr] ... | [INFO] [stderr] 72 | | } [INFO] [stderr] 73 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/lobby.rs:40:28 [INFO] [stderr] | [INFO] [stderr] 40 | for (_, client) in &self.clients { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 40 | for client in self.clients.values() { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/names.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | if word.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `word.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/main.rs:52:12 [INFO] [stderr] | [INFO] [stderr] 52 | if let Err(_) = ::std::env::var("RUST_LOG") { [INFO] [stderr] | _____- ^^^^^^ [INFO] [stderr] 53 | | ::std::env::set_var( [INFO] [stderr] 54 | | "RUST_LOG", [INFO] [stderr] 55 | | "actix=info,actix_web=info,webrtc_demo_server=trace", [INFO] [stderr] 56 | | ); [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____- help: try this: `if ::std::env::var("RUST_LOG").is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 29s [INFO] running `"docker" "inspect" "9c0b491345390167ee8bbe0e18e4b5b2240b5658fa35262738b3da596ad2e22a"` [INFO] running `"docker" "rm" "-f" "9c0b491345390167ee8bbe0e18e4b5b2240b5658fa35262738b3da596ad2e22a"` [INFO] [stdout] 9c0b491345390167ee8bbe0e18e4b5b2240b5658fa35262738b3da596ad2e22a