[INFO] updating cached repository simmel/git-shell-enforce-directory [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/simmel/git-shell-enforce-directory [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/simmel/git-shell-enforce-directory" "work/ex/clippy-test-run/sources/stable/gh/simmel/git-shell-enforce-directory"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simmel/git-shell-enforce-directory'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/simmel/git-shell-enforce-directory" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simmel/git-shell-enforce-directory"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simmel/git-shell-enforce-directory'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f79c7a0c2ed9b590bda63050dfedd72a9c56407 [INFO] sha for GitHub repo simmel/git-shell-enforce-directory: 9f79c7a0c2ed9b590bda63050dfedd72a9c56407 [INFO] validating manifest of simmel/git-shell-enforce-directory on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simmel/git-shell-enforce-directory on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simmel/git-shell-enforce-directory [INFO] finished frobbing simmel/git-shell-enforce-directory [INFO] frobbed toml for simmel/git-shell-enforce-directory written to work/ex/clippy-test-run/sources/stable/gh/simmel/git-shell-enforce-directory/Cargo.toml [INFO] started frobbing simmel/git-shell-enforce-directory [INFO] finished frobbing simmel/git-shell-enforce-directory [INFO] frobbed toml for simmel/git-shell-enforce-directory written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simmel/git-shell-enforce-directory/Cargo.toml [INFO] crate simmel/git-shell-enforce-directory has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simmel/git-shell-enforce-directory against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/simmel/git-shell-enforce-directory:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ef444d8512b2905436049d40488183adcf1bf9649e9f27da2631dc6505796c7c [INFO] running `"docker" "start" "-a" "ef444d8512b2905436049d40488183adcf1bf9649e9f27da2631dc6505796c7c"` [INFO] [stderr] Checking errno v0.2.3 [INFO] [stderr] Checking atty v0.2.8 [INFO] [stderr] Checking env_logger v0.5.6 [INFO] [stderr] Checking clap v2.31.1 [INFO] [stderr] Checking exec v0.3.1 [INFO] [stderr] Checking git-shell-enforce-directory v1.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/main.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | include_str!("../Cargo.toml"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let cmd = match args.is_present("cmd") { [INFO] [stderr] | _____________^ [INFO] [stderr] 64 | | false => { [INFO] [stderr] 65 | | fatal!("SSH_ORIGINAL_COMMAND environment variable isn't set"); [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | true => args.value_of("cmd").unwrap(), [INFO] [stderr] 68 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 63 | let cmd = if args.is_present("cmd") { args.value_of("cmd").unwrap() } else { [INFO] [stderr] 64 | fatal!("SSH_ORIGINAL_COMMAND environment variable isn't set"); [INFO] [stderr] 65 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/main.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | include_str!("../Cargo.toml"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:63:13 [INFO] [stderr] | [INFO] [stderr] 63 | let cmd = match args.is_present("cmd") { [INFO] [stderr] | _____________^ [INFO] [stderr] 64 | | false => { [INFO] [stderr] 65 | | fatal!("SSH_ORIGINAL_COMMAND environment variable isn't set"); [INFO] [stderr] 66 | | } [INFO] [stderr] 67 | | true => args.value_of("cmd").unwrap(), [INFO] [stderr] 68 | | }; [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 63 | let cmd = if args.is_present("cmd") { args.value_of("cmd").unwrap() } else { [INFO] [stderr] 64 | fatal!("SSH_ORIGINAL_COMMAND environment variable isn't set"); [INFO] [stderr] 65 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.79s [INFO] running `"docker" "inspect" "ef444d8512b2905436049d40488183adcf1bf9649e9f27da2631dc6505796c7c"` [INFO] running `"docker" "rm" "-f" "ef444d8512b2905436049d40488183adcf1bf9649e9f27da2631dc6505796c7c"` [INFO] [stdout] ef444d8512b2905436049d40488183adcf1bf9649e9f27da2631dc6505796c7c