[INFO] updating cached repository simicic/project_euler [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/simicic/project_euler [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/simicic/project_euler" "work/ex/clippy-test-run/sources/stable/gh/simicic/project_euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simicic/project_euler'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/simicic/project_euler" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simicic/project_euler"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simicic/project_euler'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2962c693cbd77d7a56698677b3aac0423b4cba02 [INFO] sha for GitHub repo simicic/project_euler: 2962c693cbd77d7a56698677b3aac0423b4cba02 [INFO] validating manifest of simicic/project_euler on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of simicic/project_euler on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing simicic/project_euler [INFO] finished frobbing simicic/project_euler [INFO] frobbed toml for simicic/project_euler written to work/ex/clippy-test-run/sources/stable/gh/simicic/project_euler/Cargo.toml [INFO] started frobbing simicic/project_euler [INFO] finished frobbing simicic/project_euler [INFO] frobbed toml for simicic/project_euler written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simicic/project_euler/Cargo.toml [INFO] crate simicic/project_euler has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting simicic/project_euler against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/simicic/project_euler:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] af524b48c1402688e198e0510a95ff8eb09b267e92c208506cd81a7197599848 [INFO] running `"docker" "start" "-a" "af524b48c1402688e198e0510a95ff8eb09b267e92c208506cd81a7197599848"` [INFO] [stderr] Checking project_euler v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/assignments/simple_euler.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | if future_number > 4000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/assignments/simple_euler.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | / if is_palindrome(potential_palindrome) { [INFO] [stderr] 72 | | if potential_palindrome > biggest_palindrome { [INFO] [stderr] 73 | | biggest_palindrome = potential_palindrome; [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | if is_palindrome(potential_palindrome) && potential_palindrome > biggest_palindrome { [INFO] [stderr] 72 | biggest_palindrome = potential_palindrome; [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/assignments/simple_euler.rs:124:3 [INFO] [stderr] | [INFO] [stderr] 124 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/assignments/simple_euler.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | result = result + current_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += current_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/assignments/simple_euler.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | result = result + future_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += future_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/assignments/simple_euler.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | divided_number = divided_number / latest_divisable; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `divided_number /= latest_divisable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner` [INFO] [stderr] --> src/assignments/simple_euler.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / 'inner: for second_factor in (first_factor..999).rev() { [INFO] [stderr] 69 | | let potential_palindrome = first_factor * second_factor; [INFO] [stderr] 70 | | [INFO] [stderr] 71 | | if is_palindrome(potential_palindrome) { [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/assignments/simple_euler.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | / 'outer: for first_factor in (100..999).rev() { [INFO] [stderr] 68 | | 'inner: for second_factor in (first_factor..999).rev() { [INFO] [stderr] 69 | | let potential_palindrome = first_factor * second_factor; [INFO] [stderr] 70 | | [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/assignments/simple_euler.rs:88:7 [INFO] [stderr] | [INFO] [stderr] 88 | increment = increment * prime; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `increment *= prime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/assignments/simple_euler.rs:29:24 [INFO] [stderr] | [INFO] [stderr] 29 | if future_number > 4000000 { [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/assignments/simple_euler.rs:71:7 [INFO] [stderr] | [INFO] [stderr] 71 | / if is_palindrome(potential_palindrome) { [INFO] [stderr] 72 | | if potential_palindrome > biggest_palindrome { [INFO] [stderr] 73 | | biggest_palindrome = potential_palindrome; [INFO] [stderr] 74 | | } [INFO] [stderr] 75 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 71 | if is_palindrome(potential_palindrome) && potential_palindrome > biggest_palindrome { [INFO] [stderr] 72 | biggest_palindrome = potential_palindrome; [INFO] [stderr] 73 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/assignments/simple_euler.rs:124:3 [INFO] [stderr] | [INFO] [stderr] 124 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/assignments/simple_euler.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | result = result + current_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += current_number` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/assignments/simple_euler.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | result = result + future_number; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result += future_number` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/assignments/simple_euler.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | divided_number = divided_number / latest_divisable; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `divided_number /= latest_divisable` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner` [INFO] [stderr] --> src/assignments/simple_euler.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | / 'inner: for second_factor in (first_factor..999).rev() { [INFO] [stderr] 69 | | let potential_palindrome = first_factor * second_factor; [INFO] [stderr] 70 | | [INFO] [stderr] 71 | | if is_palindrome(potential_palindrome) { [INFO] [stderr] ... | [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/assignments/simple_euler.rs:67:3 [INFO] [stderr] | [INFO] [stderr] 67 | / 'outer: for first_factor in (100..999).rev() { [INFO] [stderr] 68 | | 'inner: for second_factor in (first_factor..999).rev() { [INFO] [stderr] 69 | | let potential_palindrome = first_factor * second_factor; [INFO] [stderr] 70 | | [INFO] [stderr] ... | [INFO] [stderr] 76 | | } [INFO] [stderr] 77 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/assignments/simple_euler.rs:88:7 [INFO] [stderr] | [INFO] [stderr] 88 | increment = increment * prime; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `increment *= prime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:24:65 [INFO] [stderr] | [INFO] [stderr] 24 | "3" => lib::assignments::simple_euler::largest_prime_factor(600851475143), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | / io::stdin().read_line(&mut challenge_code) [INFO] [stderr] 16 | | .ok() [INFO] [stderr] 17 | | .expect("Couldn't read the line!"); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:24:65 [INFO] [stderr] | [INFO] [stderr] 24 | "3" => lib::assignments::simple_euler::largest_prime_factor(600851475143), [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `600_851_475_143` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: called `ok().expect()` on a Result value. You can call `expect` directly on the `Result` [INFO] [stderr] --> src/main.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | / io::stdin().read_line(&mut challenge_code) [INFO] [stderr] 16 | | .ok() [INFO] [stderr] 17 | | .expect("Couldn't read the line!"); [INFO] [stderr] | |________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ok_expect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ok_expect [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.50s [INFO] running `"docker" "inspect" "af524b48c1402688e198e0510a95ff8eb09b267e92c208506cd81a7197599848"` [INFO] running `"docker" "rm" "-f" "af524b48c1402688e198e0510a95ff8eb09b267e92c208506cd81a7197599848"` [INFO] [stdout] af524b48c1402688e198e0510a95ff8eb09b267e92c208506cd81a7197599848