[INFO] updating cached repository simeg/commentective
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/simeg/commentective
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/simeg/commentective" "work/ex/clippy-test-run/sources/stable/gh/simeg/commentective"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/simeg/commentective'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/simeg/commentective" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simeg/commentective"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simeg/commentective'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] dd39f594b65c5041ba7afbe8440a2ae1036b76fa
[INFO] sha for GitHub repo simeg/commentective: dd39f594b65c5041ba7afbe8440a2ae1036b76fa
[INFO] validating manifest of simeg/commentective on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of simeg/commentective on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing simeg/commentective
[INFO] finished frobbing simeg/commentective
[INFO] frobbed toml for simeg/commentective written to work/ex/clippy-test-run/sources/stable/gh/simeg/commentective/Cargo.toml
[INFO] started frobbing simeg/commentective
[INFO] finished frobbing simeg/commentective
[INFO] frobbed toml for simeg/commentective written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/simeg/commentective/Cargo.toml
[INFO] crate simeg/commentective has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting simeg/commentective against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/simeg/commentective:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 430e13576ea9b5bfd419c739e94ecd66bcb9bc69ed4798e3574b31c02bb9c765
[INFO] running `"docker" "start" "-a" "430e13576ea9b5bfd419c739e94ecd66bcb9bc69ed4798e3574b31c02bb9c765"`
[INFO] [stderr]     Checking colored v1.6.1
[INFO] [stderr]     Checking parking_lot v0.6.2
[INFO] [stderr]     Checking regex v0.2.11
[INFO] [stderr]     Checking console v0.6.1
[INFO] [stderr]     Checking commentective v0.3.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/language/lua.rs:96:5
[INFO] [stderr]    |
[INFO] [stderr] 96 |     return LuaCommentType::None;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LuaCommentType::None`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/utils.rs:122:20
[INFO] [stderr]     |
[INFO] [stderr] 122 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 123 | |                 if is_multi {
[INFO] [stderr] 124 | |                     comments.push(line.index);
[INFO] [stderr] 125 | |                 }
[INFO] [stderr] 126 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 122 |             } else if is_multi {
[INFO] [stderr] 123 |     comments.push(line.index);
[INFO] [stderr] 124 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/language/lua.rs:96:5
[INFO] [stderr]    |
[INFO] [stderr] 96 |     return LuaCommentType::None;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `LuaCommentType::None`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/utils.rs:122:20
[INFO] [stderr]     |
[INFO] [stderr] 122 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 123 | |                 if is_multi {
[INFO] [stderr] 124 | |                     comments.push(line.index);
[INFO] [stderr] 125 | |                 }
[INFO] [stderr] 126 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 122 |             } else if is_multi {
[INFO] [stderr] 123 |     comments.push(line.index);
[INFO] [stderr] 124 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/language/golang.rs:40:25
[INFO] [stderr]    |
[INFO] [stderr] 40 |                         Err(_) => panic!("Could not read line"),
[INFO] [stderr]    |                         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/language/golang.rs:42:21
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     counter = counter + 1;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/language/lua.rs:63:25
[INFO] [stderr]    |
[INFO] [stderr] 63 |                         Err(_) => panic!("Could not read line"),
[INFO] [stderr]    |                         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/language/lua.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     counter = counter + 1;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/language/lua.rs:79:27
[INFO] [stderr]    |
[INFO] [stderr] 79 | fn get_comment_type(line: &String) -> LuaCommentType {
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/language/python.rs:40:25
[INFO] [stderr]    |
[INFO] [stderr] 40 |                         Err(_) => panic!("Could not read line"),
[INFO] [stderr]    |                         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/language/python.rs:42:21
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     counter = counter + 1;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/printer.rs:78:46
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn print_file_name(&mut self, file_name: &String) {
[INFO] [stderr]    |                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/printer.rs:85:63
[INFO] [stderr]    |
[INFO] [stderr] 85 |     fn print_comments(&mut self, line_number: u32, file_name: &String) {
[INFO] [stderr]    |                                                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/utils.rs:77:28
[INFO] [stderr]    |
[INFO] [stderr] 77 |     pub fn in_list(needle: &String, haystack: Vec<String>) -> bool {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/utils.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 | /         match haystack.into_iter().rfind(|ele| needle.contains(ele)) {
[INFO] [stderr] 79 | |             None => false,
[INFO] [stderr] 80 | |             Some(_) => true,
[INFO] [stderr] 81 | |         }
[INFO] [stderr]    | |_________^ help: try this: `haystack.into_iter().rfind(|ele| needle.contains(ele)).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/utils.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 | /         BufReader::new(file)
[INFO] [stderr] 135 | |             .lines()
[INFO] [stderr] 136 | |             .into_iter()
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]     |
[INFO] [stderr] 134 |         BufReader::new(file)
[INFO] [stderr] 135 |             .lines()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/utils.rs:146:17
[INFO] [stderr]     |
[INFO] [stderr] 146 |                 Err(_) => panic!("Could not read line"),
[INFO] [stderr]     |                 ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/utils.rs:143:21
[INFO] [stderr]     |
[INFO] [stderr] 143 |                     counter = counter + 1;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:106:17
[INFO] [stderr]     |
[INFO] [stderr] 106 | /                 if ext_options == &ext_file {
[INFO] [stderr] 107 | |                     false
[INFO] [stderr] 108 | |                 } else {
[INFO] [stderr] 109 | |                     true
[INFO] [stderr] 110 | |                 }
[INFO] [stderr]     | |_________________^ help: you can reduce it to: `!(ext_options == &ext_file)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/language/golang.rs:40:25
[INFO] [stderr]    |
[INFO] [stderr] 40 |                         Err(_) => panic!("Could not read line"),
[INFO] [stderr]    |                         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_wild_err_arm)] on by default
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/language/golang.rs:42:21
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     counter = counter + 1;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::assign_op_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/language/lua.rs:63:25
[INFO] [stderr]    |
[INFO] [stderr] 63 |                         Err(_) => panic!("Could not read line"),
[INFO] [stderr]    |                         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/language/lua.rs:65:21
[INFO] [stderr]    |
[INFO] [stderr] 65 |                     counter = counter + 1;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/language/lua.rs:79:27
[INFO] [stderr]    |
[INFO] [stderr] 79 | fn get_comment_type(line: &String) -> LuaCommentType {
[INFO] [stderr]    |                           ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]   --> src/language/python.rs:40:25
[INFO] [stderr]    |
[INFO] [stderr] 40 |                         Err(_) => panic!("Could not read line"),
[INFO] [stderr]    |                         ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]   --> src/language/python.rs:42:21
[INFO] [stderr]    |
[INFO] [stderr] 42 |                     counter = counter + 1;
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/printer.rs:78:46
[INFO] [stderr]    |
[INFO] [stderr] 78 |     fn print_file_name(&mut self, file_name: &String) {
[INFO] [stderr]    |                                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/printer.rs:85:63
[INFO] [stderr]    |
[INFO] [stderr] 85 |     fn print_comments(&mut self, line_number: u32, file_name: &String) {
[INFO] [stderr]    |                                                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/utils.rs:77:28
[INFO] [stderr]    |
[INFO] [stderr] 77 |     pub fn in_list(needle: &String, haystack: Vec<String>) -> bool {
[INFO] [stderr]    |                            ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/utils.rs:78:9
[INFO] [stderr]    |
[INFO] [stderr] 78 | /         match haystack.into_iter().rfind(|ele| needle.contains(ele)) {
[INFO] [stderr] 79 | |             None => false,
[INFO] [stderr] 80 | |             Some(_) => true,
[INFO] [stderr] 81 | |         }
[INFO] [stderr]    | |_________^ help: try this: `haystack.into_iter().rfind(|ele| needle.contains(ele)).is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/utils.rs:134:9
[INFO] [stderr]     |
[INFO] [stderr] 134 | /         BufReader::new(file)
[INFO] [stderr] 135 | |             .lines()
[INFO] [stderr] 136 | |             .into_iter()
[INFO] [stderr]     | |________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] help: consider removing `.into_iter()`
[INFO] [stderr]     |
[INFO] [stderr] 134 |         BufReader::new(file)
[INFO] [stderr] 135 |             .lines()
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea
[INFO] [stderr]    --> src/utils.rs:146:17
[INFO] [stderr]     |
[INFO] [stderr] 146 |                 Err(_) => panic!("Could not read line"),
[INFO] [stderr]     |                 ^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: to remove this warning, match each error separately or use unreachable macro
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm
[INFO] [stderr] 
[INFO] [stderr] warning: manual implementation of an assign operation
[INFO] [stderr]    --> src/utils.rs:143:21
[INFO] [stderr]     |
[INFO] [stderr] 143 |                     counter = counter + 1;
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `counter += 1`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: this if-then-else expression returns a bool literal
[INFO] [stderr]    --> src/lib.rs:106:17
[INFO] [stderr]     |
[INFO] [stderr] 106 | /                 if ext_options == &ext_file {
[INFO] [stderr] 107 | |                     false
[INFO] [stderr] 108 | |                 } else {
[INFO] [stderr] 109 | |                     true
[INFO] [stderr] 110 | |                 }
[INFO] [stderr]     | |_________________^ help: you can reduce it to: `!(ext_options == &ext_file)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_bool)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> tests/lib.rs:26:24
[INFO] [stderr]    |
[INFO] [stderr] 26 |     const IRRELEVANT: &'static str = "irrelevant";
[INFO] [stderr]    |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> tests/lib.rs:485:31
[INFO] [stderr]     |
[INFO] [stderr] 485 |     const NON_EXISTING_FILE: &'static str = "I_DO_NOT_EXIST";
[INFO] [stderr]     |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> tests/lib.rs:486:27
[INFO] [stderr]     |
[INFO] [stderr] 486 |     const EXISTING_FILE: &'static str = "tests/resources/javascript/with-comments.js";
[INFO] [stderr]     |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> tests/lib.rs:487:24
[INFO] [stderr]     |
[INFO] [stderr] 487 |     const EMPTY_FILE: &'static str = "tests/resources/empty.foo";
[INFO] [stderr]     |                       -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]    --> tests/lib.rs:488:30
[INFO] [stderr]     |
[INFO] [stderr] 488 |     const UNSUPPORTED_FILE: &'static str = "tests/resources/empty.foo";
[INFO] [stderr]     |                             -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 9.40s
[INFO] running `"docker" "inspect" "430e13576ea9b5bfd419c739e94ecd66bcb9bc69ed4798e3574b31c02bb9c765"`
[INFO] running `"docker" "rm" "-f" "430e13576ea9b5bfd419c739e94ecd66bcb9bc69ed4798e3574b31c02bb9c765"`
[INFO] [stdout] 430e13576ea9b5bfd419c739e94ecd66bcb9bc69ed4798e3574b31c02bb9c765