[INFO] updating cached repository silverweed/ecsde
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/silverweed/ecsde
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/silverweed/ecsde" "work/ex/clippy-test-run/sources/stable/gh/silverweed/ecsde"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/silverweed/ecsde'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/silverweed/ecsde" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/silverweed/ecsde"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/silverweed/ecsde'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d2c6cf4340eb507fd249c22ad81906ec8418e337
[INFO] sha for GitHub repo silverweed/ecsde: d2c6cf4340eb507fd249c22ad81906ec8418e337
[INFO] validating manifest of silverweed/ecsde on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of silverweed/ecsde on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing silverweed/ecsde
[INFO] finished frobbing silverweed/ecsde
[INFO] frobbed toml for silverweed/ecsde written to work/ex/clippy-test-run/sources/stable/gh/silverweed/ecsde/Cargo.toml
[INFO] started frobbing silverweed/ecsde
[INFO] finished frobbing silverweed/ecsde
[INFO] frobbed toml for silverweed/ecsde written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/silverweed/ecsde/Cargo.toml
[INFO] crate silverweed/ecsde has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting silverweed/ecsde against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/silverweed/ecsde:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 9f0c3744cdec9408be1e62dda84db88ce2e582590be74a45fdbbfa8522ff8624
[INFO] running `"docker" "start" "-a" "9f0c3744cdec9408be1e62dda84db88ce2e582590be74a45fdbbfa8522ff8624"`
[INFO] [stderr]     Checking anymap v0.12.1
[INFO] [stderr]     Checking ecs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/entity_manager.rs:30:3
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return alloc;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `alloc`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/entity_manager.rs:34:3
[INFO] [stderr]    |
[INFO] [stderr] 34 |         return self.alive.len();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.alive.len()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/entity_manager.rs:49:3
[INFO] [stderr]    |
[INFO] [stderr] 49 |           return Generational_Index {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 50 | |             index: i,
[INFO] [stderr] 51 | |             gen: self.gens[i],
[INFO] [stderr] 52 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 49 |         Generational_Index {
[INFO] [stderr] 50 |             index: i,
[INFO] [stderr] 51 |             gen: self.gens[i],
[INFO] [stderr] 52 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/entity_manager.rs:62:3
[INFO] [stderr]    |
[INFO] [stderr] 62 |         return i;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entity_manager.rs:193:3
[INFO] [stderr]     |
[INFO] [stderr] 193 |           return Entity_Manager {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 194 | |             allocator: Generational_Allocator::new(4),
[INFO] [stderr] 195 | |             components: AnyMap::new(),
[INFO] [stderr] 196 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 193 |         Entity_Manager {
[INFO] [stderr] 194 |             allocator: Generational_Allocator::new(4),
[INFO] [stderr] 195 |             components: AnyMap::new(),
[INFO] [stderr] 196 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entity_manager.rs:201:3
[INFO] [stderr]     |
[INFO] [stderr] 201 |         return entity;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `entity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entity_manager.rs:206:3
[INFO] [stderr]     |
[INFO] [stderr] 206 |         return e.index < a.size() && e.gen == a.gens[e.index] && a.alive[e.index];
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `e.index < a.size() && e.gen == a.gens[e.index] && a.alive[e.index]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entity_manager.rs:246:5
[INFO] [stderr]     |
[INFO] [stderr] 246 |                 return None;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entity_manager.rs:261:5
[INFO] [stderr]     |
[INFO] [stderr] 261 |                 return None;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/entity_manager.rs:30:3
[INFO] [stderr]    |
[INFO] [stderr] 30 |         return alloc;
[INFO] [stderr]    |         ^^^^^^^^^^^^^ help: remove `return` as shown: `alloc`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/entity_manager.rs:34:3
[INFO] [stderr]    |
[INFO] [stderr] 34 |         return self.alive.len();
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.alive.len()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/entity_manager.rs:49:3
[INFO] [stderr]    |
[INFO] [stderr] 49 |           return Generational_Index {
[INFO] [stderr]    |  _________^
[INFO] [stderr] 50 | |             index: i,
[INFO] [stderr] 51 | |             gen: self.gens[i],
[INFO] [stderr] 52 | |         };
[INFO] [stderr]    | |__________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]    |
[INFO] [stderr] 49 |         Generational_Index {
[INFO] [stderr] 50 |             index: i,
[INFO] [stderr] 51 |             gen: self.gens[i],
[INFO] [stderr] 52 |         }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/entity_manager.rs:62:3
[INFO] [stderr]    |
[INFO] [stderr] 62 |         return i;
[INFO] [stderr]    |         ^^^^^^^^^ help: remove `return` as shown: `i`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entity_manager.rs:193:3
[INFO] [stderr]     |
[INFO] [stderr] 193 |           return Entity_Manager {
[INFO] [stderr]     |  _________^
[INFO] [stderr] 194 | |             allocator: Generational_Allocator::new(4),
[INFO] [stderr] 195 | |             components: AnyMap::new(),
[INFO] [stderr] 196 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 193 |         Entity_Manager {
[INFO] [stderr] 194 |             allocator: Generational_Allocator::new(4),
[INFO] [stderr] 195 |             components: AnyMap::new(),
[INFO] [stderr] 196 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entity_manager.rs:201:3
[INFO] [stderr]     |
[INFO] [stderr] 201 |         return entity;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^ help: remove `return` as shown: `entity`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entity_manager.rs:206:3
[INFO] [stderr]     |
[INFO] [stderr] 206 |         return e.index < a.size() && e.gen == a.gens[e.index] && a.alive[e.index];
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `e.index < a.size() && e.gen == a.gens[e.index] && a.alive[e.index]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entity_manager.rs:246:5
[INFO] [stderr]     |
[INFO] [stderr] 246 |                 return None;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/entity_manager.rs:261:5
[INFO] [stderr]     |
[INFO] [stderr] 261 |                 return None;
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e2`
[INFO] [stderr]    --> src/entity_manager.rs:139:7
[INFO] [stderr]     |
[INFO] [stderr] 139 |         let e2 = alloc.allocate();
[INFO] [stderr]     |             ^^ help: consider using `_e2` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e1`
[INFO] [stderr]    --> src/entity_manager.rs:148:7
[INFO] [stderr]     |
[INFO] [stderr] 148 |         let e1 = alloc.allocate();
[INFO] [stderr]     |             ^^ help: consider using `_e1` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `e2`
[INFO] [stderr]    --> src/entity_manager.rs:165:7
[INFO] [stderr]     |
[INFO] [stderr] 165 |         let e2 = alloc.allocate();
[INFO] [stderr]     |             ^^ help: consider using `_e2` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `v`
[INFO] [stderr]    --> src/entity_manager.rs:176:11
[INFO] [stderr]     |
[INFO] [stderr] 176 |         let mut v : Vec<Generational_Index> = Vec::new();
[INFO] [stderr]     |                 ^ help: consider using `_v` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]    --> src/entity_manager.rs:177:7
[INFO] [stderr]     |
[INFO] [stderr] 177 |         for i in 0..3 * n {
[INFO] [stderr]     |             ^ help: consider using `_i` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i1`
[INFO] [stderr]    --> src/entity_manager.rs:178:8
[INFO] [stderr]     |
[INFO] [stderr] 178 |             let i1 = alloc.allocate();
[INFO] [stderr]     |                 ^^ help: consider using `_i1` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]   --> src/main.rs:75:7
[INFO] [stderr]    |
[INFO] [stderr] 75 |         for i in 0..(x as i32 + self.width / 2) {
[INFO] [stderr]    |             ^ help: consider using `_i` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `i`
[INFO] [stderr]   --> src/main.rs:75:7
[INFO] [stderr]    |
[INFO] [stderr] 75 |         for i in 0..(x as i32 + self.width / 2) {
[INFO] [stderr]    |             ^ help: consider using `_i` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:122:6
[INFO] [stderr]     |
[INFO] [stderr] 122 |     let mut sine_wave = em.get_component_mut::<C_Sine_Wave>(wave).unwrap();
[INFO] [stderr]     |         ----^^^^^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/main.rs:122:6
[INFO] [stderr]     |
[INFO] [stderr] 122 |     let mut sine_wave = em.get_component_mut::<C_Sine_Wave>(wave).unwrap();
[INFO] [stderr]     |         ----^^^^^^^^^
[INFO] [stderr]     |         |
[INFO] [stderr]     |         help: remove this `mut`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_mut)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/entity_manager.rs:176:7
[INFO] [stderr]     |
[INFO] [stderr] 176 |         let mut v : Vec<Generational_Index> = Vec::new();
[INFO] [stderr]     |             ----^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/entity_manager.rs:217:7
[INFO] [stderr]     |
[INFO] [stderr] 217 |         let mut v: Vec<Option<C>> = Vec::new();
[INFO] [stderr]     |             ----^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/entity_manager.rs:217:7
[INFO] [stderr]     |
[INFO] [stderr] 217 |         let mut v: Vec<Option<C>> = Vec::new();
[INFO] [stderr]     |             ----^
[INFO] [stderr]     |             |
[INFO] [stderr]     |             help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `deallocate`
[INFO] [stderr]   --> src/entity_manager.rs:65:2
[INFO] [stderr]    |
[INFO] [stderr] 65 |     fn deallocate(&mut self, idx: Generational_Index) {
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `destroy_entity`
[INFO] [stderr]    --> src/entity_manager.rs:209:2
[INFO] [stderr]     |
[INFO] [stderr] 209 |     pub fn destroy_entity(&mut self, e: Entity) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: type `Generational_Index` should have a camel case name such as `GenerationalIndex`
[INFO] [stderr]   --> src/entity_manager.rs:9:1
[INFO] [stderr]    |
[INFO] [stderr] 9  | / pub struct Generational_Index {
[INFO] [stderr] 10 | |     pub index: usize,
[INFO] [stderr] 11 | |     pub gen: u64
[INFO] [stderr] 12 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_camel_case_types)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type `Generational_Allocator` should have a camel case name such as `GenerationalAllocator`
[INFO] [stderr]   --> src/entity_manager.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | / struct Generational_Allocator {
[INFO] [stderr] 15 | |     // true if i-th slot is in use, false otherwise
[INFO] [stderr] 16 | |     alive: Vec<bool>,
[INFO] [stderr] 17 | |     // generation of i-th slot
[INFO] [stderr] 18 | |     gens: Vec<u64>,
[INFO] [stderr] 19 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: variable does not need to be mutable
[INFO] [stderr]    --> src/entity_manager.rs:318:8
[INFO] [stderr]     |
[INFO] [stderr] 318 |             let mut c = em.get_component_mut::<C_Test>(e).unwrap();
[INFO] [stderr]     |                 ----^
[INFO] [stderr]     |                 |
[INFO] [stderr]     |                 help: remove this `mut`
[INFO] [stderr] 
[INFO] [stderr] warning: type `Entity_Manager` should have a camel case name such as `EntityManager`
[INFO] [stderr]    --> src/entity_manager.rs:183:1
[INFO] [stderr]     |
[INFO] [stderr] 183 | / pub struct Entity_Manager {
[INFO] [stderr] 184 | |     allocator: Generational_Allocator,
[INFO] [stderr] 185 | |     // { CompType => Vec<CompType> }
[INFO] [stderr] 186 | |     components: AnyMap,
[INFO] [stderr] 187 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `destroy_entity`
[INFO] [stderr]    --> src/entity_manager.rs:209:2
[INFO] [stderr]     |
[INFO] [stderr] 209 |     pub fn destroy_entity(&mut self, e: Entity) {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: type `Generational_Index` should have a camel case name such as `GenerationalIndex`
[INFO] [stderr]   --> src/entity_manager.rs:9:1
[INFO] [stderr]    |
[INFO] [stderr] 9  | / pub struct Generational_Index {
[INFO] [stderr] 10 | |     pub index: usize,
[INFO] [stderr] 11 | |     pub gen: u64
[INFO] [stderr] 12 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(non_camel_case_types)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/entity_manager.rs:214:10
[INFO] [stderr]     |
[INFO] [stderr] 214 |           if let Some(_) = self.components.get::<Vec<Option<C>>>() {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 215 | |             panic!("Tried to register the same component twice!"); // @Clarity: add component type name to err msg
[INFO] [stderr] 216 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.components.get::<Vec<Option<C>>>().is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: type `Generational_Allocator` should have a camel case name such as `GenerationalAllocator`
[INFO] [stderr]   --> src/entity_manager.rs:14:1
[INFO] [stderr]    |
[INFO] [stderr] 14 | / struct Generational_Allocator {
[INFO] [stderr] 15 | |     // true if i-th slot is in use, false otherwise
[INFO] [stderr] 16 | |     alive: Vec<bool>,
[INFO] [stderr] 17 | |     // generation of i-th slot
[INFO] [stderr] 18 | |     gens: Vec<u64>,
[INFO] [stderr] 19 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/entity_manager.rs:237:2
[INFO] [stderr]     |
[INFO] [stderr] 237 |       pub fn get_component<'a, C: Component + 'static>(&'a self, e: Entity) -> Option<&'a C> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 238 | |         if !self.is_valid_entity(e) {
[INFO] [stderr] 239 | |             panic!("Tried to get component of invalid entity {:?}", e);
[INFO] [stderr] 240 | |         }
[INFO] [stderr] ...   |
[INFO] [stderr] 249 | |         }
[INFO] [stderr] 250 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/entity_manager.rs:253:2
[INFO] [stderr]     |
[INFO] [stderr] 253 |       pub fn get_component_mut<'a, C: Component + 'static>(&'a mut self, e: Entity) -> Option<&'a mut C> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 254 | |         if !self.is_valid_entity(e) {
[INFO] [stderr] 255 | |             panic!("Tried to get component of invalid entity {:?}", e);
[INFO] [stderr] 256 | |         }
[INFO] [stderr] ...   |
[INFO] [stderr] 264 | |         }
[INFO] [stderr] 265 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: type `C_Position` should have a camel case name such as `CPosition`
[INFO] [stderr]   --> src/components.rs:7:1
[INFO] [stderr]    |
[INFO] [stderr] 7  | / pub struct C_Position {
[INFO] [stderr] 8  | |     pub x: f32,
[INFO] [stderr] 9  | |     pub y: f32,
[INFO] [stderr] 10 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/systems.rs:4:67
[INFO] [stderr]   |
[INFO] [stderr] 4 |     fn update(&mut self, dt: f32, em: &mut Entity_Manager, entities: &Vec<Entity>);
[INFO] [stderr]   |                                                                      ^^^^^^^^^^^^ help: change this to: `&[Entity]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: type `C_Horiz_Pos` should have a camel case name such as `CHorizPos`
[INFO] [stderr]   --> src/main.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | / struct C_Horiz_Pos {
[INFO] [stderr] 13 | |     x: i8
[INFO] [stderr] 14 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: type `C_Sine_Wave` should have a camel case name such as `CSineWave`
[INFO] [stderr]   --> src/main.rs:17:1
[INFO] [stderr]    |
[INFO] [stderr] 17 | / struct C_Sine_Wave {
[INFO] [stderr] 18 | |     ampl: u8,
[INFO] [stderr] 19 | |     freq: f32,
[INFO] [stderr] 20 | |     phase: f32,
[INFO] [stderr] 21 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: type `S_Sine_Update` should have a camel case name such as `SSineUpdate`
[INFO] [stderr]   --> src/main.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | / struct S_Sine_Update {
[INFO] [stderr] 25 | |     t: f32
[INFO] [stderr] 26 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:48:22
[INFO] [stderr]    |
[INFO] [stderr] 48 |             pos.unwrap().x = ((sine_wave.ampl as f32) * (sine_wave.freq * self.t + sine_wave.phase).sin()) as i8;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(sine_wave.ampl)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: type `S_Particle_Draw` should have a camel case name such as `SParticleDraw`
[INFO] [stderr]   --> src/main.rs:53:1
[INFO] [stderr]    |
[INFO] [stderr] 53 | / struct S_Particle_Draw {
[INFO] [stderr] 54 | |     width: i32
[INFO] [stderr] 55 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:75:16
[INFO] [stderr]    |
[INFO] [stderr] 75 |         for i in 0..(x as i32 + self.width / 2) {
[INFO] [stderr]    |                      ^^^^^^^^ help: try: `i32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f32::consts::PI` found. Consider using it directly
[INFO] [stderr]    --> src/main.rs:101:49
[INFO] [stderr]     |
[INFO] [stderr] 101 |         init_components(&mut em, e, 0f32 + i as f32 * 3.1415f32 / (n as f32));
[INFO] [stderr]     |                                                       ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::approx_constant)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `i` is only used to index `v`.
[INFO] [stderr]    --> src/entity_manager.rs:119:12
[INFO] [stderr]     |
[INFO] [stderr] 119 |         for i in 0..n {
[INFO] [stderr]     |                  ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 119 |         for <item> in v.iter().take(n) {
[INFO] [stderr]     |             ^^^^^^    ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `ecs`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: type `Entity_Manager` should have a camel case name such as `EntityManager`
[INFO] [stderr]    --> src/entity_manager.rs:183:1
[INFO] [stderr]     |
[INFO] [stderr] 183 | / pub struct Entity_Manager {
[INFO] [stderr] 184 | |     allocator: Generational_Allocator,
[INFO] [stderr] 185 | |     // { CompType => Vec<CompType> }
[INFO] [stderr] 186 | |     components: AnyMap,
[INFO] [stderr] 187 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]    --> src/entity_manager.rs:214:10
[INFO] [stderr]     |
[INFO] [stderr] 214 |           if let Some(_) = self.components.get::<Vec<Option<C>>>() {
[INFO] [stderr]     |  _________-      ^^^^^^^
[INFO] [stderr] 215 | |             panic!("Tried to register the same component twice!"); // @Clarity: add component type name to err msg
[INFO] [stderr] 216 | |         }
[INFO] [stderr]     | |_________- help: try this: `if self.components.get::<Vec<Option<C>>>().is_some()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/entity_manager.rs:237:2
[INFO] [stderr]     |
[INFO] [stderr] 237 |       pub fn get_component<'a, C: Component + 'static>(&'a self, e: Entity) -> Option<&'a C> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 238 | |         if !self.is_valid_entity(e) {
[INFO] [stderr] 239 | |             panic!("Tried to get component of invalid entity {:?}", e);
[INFO] [stderr] 240 | |         }
[INFO] [stderr] ...   |
[INFO] [stderr] 249 | |         }
[INFO] [stderr] 250 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/entity_manager.rs:253:2
[INFO] [stderr]     |
[INFO] [stderr] 253 |       pub fn get_component_mut<'a, C: Component + 'static>(&'a mut self, e: Entity) -> Option<&'a mut C> {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 254 | |         if !self.is_valid_entity(e) {
[INFO] [stderr] 255 | |             panic!("Tried to get component of invalid entity {:?}", e);
[INFO] [stderr] 256 | |         }
[INFO] [stderr] ...   |
[INFO] [stderr] 264 | |         }
[INFO] [stderr] 265 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: type `C_Test` should have a camel case name such as `CTest`
[INFO] [stderr]    --> src/entity_manager.rs:273:2
[INFO] [stderr]     |
[INFO] [stderr] 273 |       struct C_Test {
[INFO] [stderr]     |  _____^
[INFO] [stderr] 274 | |         foo: i32
[INFO] [stderr] 275 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr] 
[INFO] [stderr] warning: type `C_Position` should have a camel case name such as `CPosition`
[INFO] [stderr]   --> src/components.rs:7:1
[INFO] [stderr]    |
[INFO] [stderr] 7  | / pub struct C_Position {
[INFO] [stderr] 8  | |     pub x: f32,
[INFO] [stderr] 9  | |     pub y: f32,
[INFO] [stderr] 10 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/systems.rs:4:67
[INFO] [stderr]   |
[INFO] [stderr] 4 |     fn update(&mut self, dt: f32, em: &mut Entity_Manager, entities: &Vec<Entity>);
[INFO] [stderr]   |                                                                      ^^^^^^^^^^^^ help: change this to: `&[Entity]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: type `C_Horiz_Pos` should have a camel case name such as `CHorizPos`
[INFO] [stderr]   --> src/main.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | / struct C_Horiz_Pos {
[INFO] [stderr] 13 | |     x: i8
[INFO] [stderr] 14 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: type `C_Sine_Wave` should have a camel case name such as `CSineWave`
[INFO] [stderr]   --> src/main.rs:17:1
[INFO] [stderr]    |
[INFO] [stderr] 17 | / struct C_Sine_Wave {
[INFO] [stderr] 18 | |     ampl: u8,
[INFO] [stderr] 19 | |     freq: f32,
[INFO] [stderr] 20 | |     phase: f32,
[INFO] [stderr] 21 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: type `S_Sine_Update` should have a camel case name such as `SSineUpdate`
[INFO] [stderr]   --> src/main.rs:24:1
[INFO] [stderr]    |
[INFO] [stderr] 24 | / struct S_Sine_Update {
[INFO] [stderr] 25 | |     t: f32
[INFO] [stderr] 26 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:48:22
[INFO] [stderr]    |
[INFO] [stderr] 48 |             pos.unwrap().x = ((sine_wave.ampl as f32) * (sine_wave.freq * self.t + sine_wave.phase).sin()) as i8;
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(sine_wave.ampl)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: type `S_Particle_Draw` should have a camel case name such as `SParticleDraw`
[INFO] [stderr]   --> src/main.rs:53:1
[INFO] [stderr]    |
[INFO] [stderr] 53 | / struct S_Particle_Draw {
[INFO] [stderr] 54 | |     width: i32
[INFO] [stderr] 55 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr] 
[INFO] [stderr] warning: casting i8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:75:16
[INFO] [stderr]    |
[INFO] [stderr] 75 |         for i in 0..(x as i32 + self.width / 2) {
[INFO] [stderr]    |                      ^^^^^^^^ help: try: `i32::from(x)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: approximate value of `f32::consts::PI` found. Consider using it directly
[INFO] [stderr]    --> src/main.rs:101:49
[INFO] [stderr]     |
[INFO] [stderr] 101 |         init_components(&mut em, e, 0f32 + i as f32 * 3.1415f32 / (n as f32));
[INFO] [stderr]     |                                                       ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::approx_constant)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `ecs`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "9f0c3744cdec9408be1e62dda84db88ce2e582590be74a45fdbbfa8522ff8624"`
[INFO] running `"docker" "rm" "-f" "9f0c3744cdec9408be1e62dda84db88ce2e582590be74a45fdbbfa8522ff8624"`
[INFO] [stdout] 9f0c3744cdec9408be1e62dda84db88ce2e582590be74a45fdbbfa8522ff8624