[INFO] updating cached repository sile/wstcp [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sile/wstcp [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sile/wstcp" "work/ex/clippy-test-run/sources/stable/gh/sile/wstcp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sile/wstcp'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sile/wstcp" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sile/wstcp"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sile/wstcp'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ef918ca20b371378fbd6aa9e52a0f30d8f980120 [INFO] sha for GitHub repo sile/wstcp: ef918ca20b371378fbd6aa9e52a0f30d8f980120 [INFO] validating manifest of sile/wstcp on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sile/wstcp on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sile/wstcp [INFO] finished frobbing sile/wstcp [INFO] frobbed toml for sile/wstcp written to work/ex/clippy-test-run/sources/stable/gh/sile/wstcp/Cargo.toml [INFO] started frobbing sile/wstcp [INFO] finished frobbing sile/wstcp [INFO] frobbed toml for sile/wstcp written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sile/wstcp/Cargo.toml [INFO] crate sile/wstcp has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sile/wstcp against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sile/wstcp:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b55699ca6ec6300f542c40ee760bc61479e80f579a4b35c156a2d94dba274a4d [INFO] running `"docker" "start" "-a" "b55699ca6ec6300f542c40ee760bc61479e80f579a4b35c156a2d94dba274a4d"` [INFO] [stderr] Checking slog v2.2.3 [INFO] [stderr] Compiling serde v1.0.57 [INFO] [stderr] Checking trackable v0.2.16 [INFO] [stderr] Checking splay_tree v0.2.10 [INFO] [stderr] Checking nbchan v0.1.2 [INFO] [stderr] Checking isatty v0.1.7 [INFO] [stderr] Compiling syn v0.13.10 [INFO] [stderr] Checking chrono v0.4.2 [INFO] [stderr] Checking sha-1 v0.7.0 [INFO] [stderr] Checking slog-scope v4.0.1 [INFO] [stderr] Checking slog-async v2.3.0 [INFO] [stderr] Checking bytecodec v0.4.2 [INFO] [stderr] Checking slog-stdlog v3.0.2 [INFO] [stderr] Checking fibers v0.1.10 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking httpcodec v0.2.2 [INFO] [stderr] Compiling serde_derive v1.0.57 [INFO] [stderr] Checking sloggers v0.2.6 [INFO] [stderr] Checking wstcp v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/channel.rs:327:5 [INFO] [stderr] | [INFO] [stderr] 327 | RecvRequest(RequestDecoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 327 | RecvRequest(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/opcode.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn is_control(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/channel.rs:327:5 [INFO] [stderr] | [INFO] [stderr] 327 | RecvRequest(RequestDecoder), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 327 | RecvRequest(Box>), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/opcode.rs:25:23 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn is_control(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 47.62s [INFO] running `"docker" "inspect" "b55699ca6ec6300f542c40ee760bc61479e80f579a4b35c156a2d94dba274a4d"` [INFO] running `"docker" "rm" "-f" "b55699ca6ec6300f542c40ee760bc61479e80f579a4b35c156a2d94dba274a4d"` [INFO] [stdout] b55699ca6ec6300f542c40ee760bc61479e80f579a4b35c156a2d94dba274a4d