[INFO] updating cached repository sile/dg [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sile/dg [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sile/dg" "work/ex/clippy-test-run/sources/stable/gh/sile/dg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sile/dg'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sile/dg" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sile/dg"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sile/dg'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0ba3f6e789448c0c02fd7b8d4dbcdb3faf74603a [INFO] sha for GitHub repo sile/dg: 0ba3f6e789448c0c02fd7b8d4dbcdb3faf74603a [INFO] validating manifest of sile/dg on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sile/dg on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sile/dg [INFO] finished frobbing sile/dg [INFO] frobbed toml for sile/dg written to work/ex/clippy-test-run/sources/stable/gh/sile/dg/Cargo.toml [INFO] started frobbing sile/dg [INFO] finished frobbing sile/dg [INFO] frobbed toml for sile/dg written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sile/dg/Cargo.toml [INFO] crate sile/dg has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sile/dg against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sile/dg:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 355d90f170acc1e83acbe51306e8ef48b7ae650335b02429e2e76c6b5fdee0cf [INFO] running `"docker" "start" "-a" "355d90f170acc1e83acbe51306e8ef48b7ae650335b02429e2e76c6b5fdee0cf"` [INFO] [stderr] Checking inotify-sys v0.1.2 [INFO] [stderr] Checking rand v0.5.1 [INFO] [stderr] Checking slog-stdlog v3.0.2 [INFO] [stderr] Checking chrono v0.4.3 [INFO] [stderr] Checking tasque v0.1.4 [INFO] [stderr] Checking inotify v0.5.1 [INFO] [stderr] Checking fibers_tasque v0.1.1 [INFO] [stderr] Checking fibers_inotify v0.1.1 [INFO] [stderr] Checking scalable_cuckoo_filter v0.1.2 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking sloggers v0.2.7 [INFO] [stderr] Checking dg v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokenize.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | .unwrap_or(self.bytes.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.bytes.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/watch/fs/file.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Plain(PlainFileWatcher), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 21 | Plain(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tokenize.rs:38:14 [INFO] [stderr] | [INFO] [stderr] 38 | .unwrap_or(self.bytes.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| self.bytes.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/watch/fs/file.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | Plain(PlainFileWatcher), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 21 | Plain(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.94s [INFO] running `"docker" "inspect" "355d90f170acc1e83acbe51306e8ef48b7ae650335b02429e2e76c6b5fdee0cf"` [INFO] running `"docker" "rm" "-f" "355d90f170acc1e83acbe51306e8ef48b7ae650335b02429e2e76c6b5fdee0cf"` [INFO] [stdout] 355d90f170acc1e83acbe51306e8ef48b7ae650335b02429e2e76c6b5fdee0cf