[INFO] updating cached repository siiptuo/lambda [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/siiptuo/lambda [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/siiptuo/lambda" "work/ex/clippy-test-run/sources/stable/gh/siiptuo/lambda"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/siiptuo/lambda'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/siiptuo/lambda" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/siiptuo/lambda"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/siiptuo/lambda'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 91420bdd99be25c1eaa705f71f914cb1799f5585 [INFO] sha for GitHub repo siiptuo/lambda: 91420bdd99be25c1eaa705f71f914cb1799f5585 [INFO] validating manifest of siiptuo/lambda on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of siiptuo/lambda on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing siiptuo/lambda [INFO] finished frobbing siiptuo/lambda [INFO] frobbed toml for siiptuo/lambda written to work/ex/clippy-test-run/sources/stable/gh/siiptuo/lambda/Cargo.toml [INFO] started frobbing siiptuo/lambda [INFO] finished frobbing siiptuo/lambda [INFO] frobbed toml for siiptuo/lambda written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/siiptuo/lambda/Cargo.toml [INFO] crate siiptuo/lambda has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting siiptuo/lambda against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/siiptuo/lambda:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4e84c402d572c6521a23cb9e906e33c1565b808fb8a8656e1f658c4d88988038 [INFO] running `"docker" "start" "-a" "4e84c402d572c6521a23cb9e906e33c1565b808fb8a8656e1f658c4d88988038"` [INFO] [stderr] Checking nix v0.5.1 [INFO] [stderr] Checking rustyline v1.0.0 [INFO] [stderr] Checking lambda v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lexer.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | match self.0.peek().map(|c| *c) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.0.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match lexer.peek().ok_or("eof".to_string())? { [INFO] [stderr] 43 | | // Parse abstraction [INFO] [stderr] 44 | | &Token::Lambda => { [INFO] [stderr] 45 | | lexer.next().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *(lexer.peek().ok_or("eof".to_string())?) { [INFO] [stderr] 43 | // Parse abstraction [INFO] [stderr] 44 | Token::Lambda => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | match lexer.peek().ok_or("eof".to_string())? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "eof".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/substitute.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | App(M, N) => free(M).union(&free(N)).map(|x| x.clone()).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `free(M).union(&free(N)).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lexer.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | match self.0.peek().map(|c| *c) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `self.0.peek().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match lexer.peek().ok_or("eof".to_string())? { [INFO] [stderr] 43 | | // Parse abstraction [INFO] [stderr] 44 | | &Token::Lambda => { [INFO] [stderr] 45 | | lexer.next().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 56 | | } [INFO] [stderr] 57 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 42 | match *(lexer.peek().ok_or("eof".to_string())?) { [INFO] [stderr] 43 | // Parse abstraction [INFO] [stderr] 44 | Token::Lambda => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/parser.rs:42:24 [INFO] [stderr] | [INFO] [stderr] 42 | match lexer.peek().ok_or("eof".to_string())? { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| "eof".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/substitute.rs:17:22 [INFO] [stderr] | [INFO] [stderr] 17 | App(M, N) => free(M).union(&free(N)).map(|x| x.clone()).collect(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `free(M).union(&free(N)).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.28s [INFO] running `"docker" "inspect" "4e84c402d572c6521a23cb9e906e33c1565b808fb8a8656e1f658c4d88988038"` [INFO] running `"docker" "rm" "-f" "4e84c402d572c6521a23cb9e906e33c1565b808fb8a8656e1f658c4d88988038"` [INFO] [stdout] 4e84c402d572c6521a23cb9e906e33c1565b808fb8a8656e1f658c4d88988038