[INFO] updating cached repository sighol/clock-server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sighol/clock-server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sighol/clock-server" "work/ex/clippy-test-run/sources/stable/gh/sighol/clock-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sighol/clock-server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sighol/clock-server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sighol/clock-server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sighol/clock-server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1ecffd3280f86197117eacf0b75abffcff609bc6 [INFO] sha for GitHub repo sighol/clock-server: 1ecffd3280f86197117eacf0b75abffcff609bc6 [INFO] validating manifest of sighol/clock-server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sighol/clock-server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sighol/clock-server [INFO] finished frobbing sighol/clock-server [INFO] frobbed toml for sighol/clock-server written to work/ex/clippy-test-run/sources/stable/gh/sighol/clock-server/Cargo.toml [INFO] started frobbing sighol/clock-server [INFO] finished frobbing sighol/clock-server [INFO] frobbed toml for sighol/clock-server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sighol/clock-server/Cargo.toml [INFO] crate sighol/clock-server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sighol/clock-server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sighol/clock-server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 63264ba33fe731c354143f179192e72a63951b799b0cfeb9acc9f4e8bff24985 [INFO] running `"docker" "start" "-a" "63264ba33fe731c354143f179192e72a63951b799b0cfeb9acc9f4e8bff24985"` [INFO] [stderr] Checking clock-server v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | let nanos: f64 = dur.subsec_nanos() as f64 / 1_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ntp.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | (dt.timestamp_subsec_nanos() as f64 * (u32::MAX as f64 / 1_000_000_000.0)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dt.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ntp.rs:26:52 [INFO] [stderr] | [INFO] [stderr] 26 | (dt.timestamp_subsec_nanos() as f64 * (u32::MAX as f64 / 1_000_000_000.0)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ntp.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | let nanos = (self.fraction as f64 * (1_000_000_000.0 / u32::MAX as f64)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.fraction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ntp.rs:36:64 [INFO] [stderr] | [INFO] [stderr] 36 | let nanos = (self.fraction as f64 * (1_000_000_000.0 / u32::MAX as f64)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ntp.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | let seconds = self.seconds as i64 - NTP_TO_UNIX_EPOCH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | .unwrap_or(String::from("unknown")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("unknown"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/client.rs:101:22 [INFO] [stderr] | [INFO] [stderr] 101 | let nanos: f64 = dur.subsec_nanos() as f64 / 1_000_000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dur.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ntp.rs:26:14 [INFO] [stderr] | [INFO] [stderr] 26 | (dt.timestamp_subsec_nanos() as f64 * (u32::MAX as f64 / 1_000_000_000.0)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dt.timestamp_subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ntp.rs:26:52 [INFO] [stderr] | [INFO] [stderr] 26 | (dt.timestamp_subsec_nanos() as f64 * (u32::MAX as f64 / 1_000_000_000.0)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ntp.rs:36:22 [INFO] [stderr] | [INFO] [stderr] 36 | let nanos = (self.fraction as f64 * (1_000_000_000.0 / u32::MAX as f64)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.fraction)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/ntp.rs:36:64 [INFO] [stderr] | [INFO] [stderr] 36 | let nanos = (self.fraction as f64 * (1_000_000_000.0 / u32::MAX as f64)) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(u32::MAX)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/ntp.rs:37:23 [INFO] [stderr] | [INFO] [stderr] 37 | let seconds = self.seconds as i64 - NTP_TO_UNIX_EPOCH; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.seconds)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/server.rs:66:10 [INFO] [stderr] | [INFO] [stderr] 66 | .unwrap_or(String::from("unknown")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| String::from("unknown"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "63264ba33fe731c354143f179192e72a63951b799b0cfeb9acc9f4e8bff24985"` [INFO] running `"docker" "rm" "-f" "63264ba33fe731c354143f179192e72a63951b799b0cfeb9acc9f4e8bff24985"` [INFO] [stdout] 63264ba33fe731c354143f179192e72a63951b799b0cfeb9acc9f4e8bff24985