[INFO] updating cached repository sidred/redmart_challenge
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sidred/redmart_challenge
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sidred/redmart_challenge" "work/ex/clippy-test-run/sources/stable/gh/sidred/redmart_challenge"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sidred/redmart_challenge'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sidred/redmart_challenge" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sidred/redmart_challenge"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sidred/redmart_challenge'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 84d9216904c90845da4a7b74e8d2c38e612eef96
[INFO] sha for GitHub repo sidred/redmart_challenge: 84d9216904c90845da4a7b74e8d2c38e612eef96
[INFO] validating manifest of sidred/redmart_challenge on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sidred/redmart_challenge on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sidred/redmart_challenge
[INFO] finished frobbing sidred/redmart_challenge
[INFO] frobbed toml for sidred/redmart_challenge written to work/ex/clippy-test-run/sources/stable/gh/sidred/redmart_challenge/Cargo.toml
[INFO] started frobbing sidred/redmart_challenge
[INFO] finished frobbing sidred/redmart_challenge
[INFO] frobbed toml for sidred/redmart_challenge written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sidred/redmart_challenge/Cargo.toml
[INFO] crate sidred/redmart_challenge has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sidred/redmart_challenge against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sidred/redmart_challenge:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 7b69a346cfbffbab280547baf7fa712c6f6c75feaab7d9a7fb8ace33f2329a46
[INFO] running `"docker" "start" "-a" "7b69a346cfbffbab280547baf7fa712c6f6c75feaab7d9a7fb8ace33f2329a46"`
[INFO] [stderr]     Checking redmart_challenge v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:108:12
[INFO] [stderr]     |
[INFO] [stderr] 108 |       } else if p1.distance == p2.distance {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 109 | |         if p1.vertical_drop < p2.vertical_drop {
[INFO] [stderr] 110 | |             return p2;
[INFO] [stderr] 111 | |         }
[INFO] [stderr] 112 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 108 |     } else if p1.distance == p2.distance && p1.vertical_drop < p2.vertical_drop {
[INFO] [stderr] 109 |     return p2;
[INFO] [stderr] 110 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/main.rs:108:12
[INFO] [stderr]     |
[INFO] [stderr] 108 |       } else if p1.distance == p2.distance {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 109 | |         if p1.vertical_drop < p2.vertical_drop {
[INFO] [stderr] 110 | |             return p2;
[INFO] [stderr] 111 | |         }
[INFO] [stderr] 112 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 108 |     } else if p1.distance == p2.distance && p1.vertical_drop < p2.vertical_drop {
[INFO] [stderr] 109 |     return p2;
[INFO] [stderr] 110 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/main.rs:39:32
[INFO] [stderr]    |
[INFO] [stderr] 39 |         let mut longest_path = v.clone();
[INFO] [stderr]    |                                ^^^^^^^^^ help: try removing the `clone` call: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/main.rs:57:16
[INFO] [stderr]    |
[INFO] [stderr] 57 |         return v.clone();
[INFO] [stderr]    |                ^^^^^^^^^ help: try removing the `clone` call: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:97:21
[INFO] [stderr]    |
[INFO] [stderr] 97 |         .filter(|v| v.len() > 0)
[INFO] [stderr]    |                     ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/main.rs:39:32
[INFO] [stderr]    |
[INFO] [stderr] 39 |         let mut longest_path = v.clone();
[INFO] [stderr]    |                                ^^^^^^^^^ help: try removing the `clone` call: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/main.rs:57:16
[INFO] [stderr]    |
[INFO] [stderr] 57 |         return v.clone();
[INFO] [stderr]    |                ^^^^^^^^^ help: try removing the `clone` call: `v`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/main.rs:97:21
[INFO] [stderr]    |
[INFO] [stderr] 97 |         .filter(|v| v.len() > 0)
[INFO] [stderr]    |                     ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.40s
[INFO] running `"docker" "inspect" "7b69a346cfbffbab280547baf7fa712c6f6c75feaab7d9a7fb8ace33f2329a46"`
[INFO] running `"docker" "rm" "-f" "7b69a346cfbffbab280547baf7fa712c6f6c75feaab7d9a7fb8ace33f2329a46"`
[INFO] [stdout] 7b69a346cfbffbab280547baf7fa712c6f6c75feaab7d9a7fb8ace33f2329a46