[INFO] updating cached repository siabard/piston-tutorial [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/siabard/piston-tutorial [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/siabard/piston-tutorial" "work/ex/clippy-test-run/sources/stable/gh/siabard/piston-tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/siabard/piston-tutorial'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/siabard/piston-tutorial" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/siabard/piston-tutorial"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/siabard/piston-tutorial'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b709fc549e1a07ac4dc3215f72abc5f9aa4c8284 [INFO] sha for GitHub repo siabard/piston-tutorial: b709fc549e1a07ac4dc3215f72abc5f9aa4c8284 [INFO] validating manifest of siabard/piston-tutorial on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of siabard/piston-tutorial on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing siabard/piston-tutorial [INFO] finished frobbing siabard/piston-tutorial [INFO] frobbed toml for siabard/piston-tutorial written to work/ex/clippy-test-run/sources/stable/gh/siabard/piston-tutorial/Cargo.toml [INFO] started frobbing siabard/piston-tutorial [INFO] finished frobbing siabard/piston-tutorial [INFO] frobbed toml for siabard/piston-tutorial written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/siabard/piston-tutorial/Cargo.toml [INFO] crate siabard/piston-tutorial has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting siabard/piston-tutorial against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/siabard/piston-tutorial:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 574181b44b15b0e7d2d44f97daec62fc8a80ca45aecd39c99e1cefbd28fec073 [INFO] running `"docker" "start" "-a" "574181b44b15b0e7d2d44f97daec62fc8a80ca45aecd39c99e1cefbd28fec073"` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/src/bin/main.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Compiling libloading v0.5.0 [INFO] [stderr] Checking memmap v0.6.2 [INFO] [stderr] Checking shared_library v0.1.8 [INFO] [stderr] Compiling gl_generator v0.9.0 [INFO] [stderr] Checking alga v0.5.3 [INFO] [stderr] Compiling syn v0.12.14 [INFO] [stderr] Compiling gl_generator v0.8.0 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking gfx_core v0.8.2 [INFO] [stderr] Checking x11-dl v2.17.3 [INFO] [stderr] Checking rusttype v0.4.3 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking piston2d-graphics v0.26.0 [INFO] [stderr] Compiling glutin v0.12.2 [INFO] [stderr] Compiling gl v0.10.0 [INFO] [stderr] Compiling gfx_gl v0.5.0 [INFO] [stderr] Checking nalgebra v0.14.1 [INFO] [stderr] Compiling serde_derive_internals v0.21.0 [INFO] [stderr] Checking dlib v0.4.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking wayland-sys v0.12.5 [INFO] [stderr] Checking wayland-client v0.12.5 [INFO] [stderr] Compiling serde_derive v1.0.33 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking wayland-protocols v0.12.5 [INFO] [stderr] Checking wayland-kbd v0.13.1 [INFO] [stderr] Checking wayland-window v0.13.2 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking winit v0.10.0 [INFO] [stderr] Checking pistoncore-window v0.31.0 [INFO] [stderr] Checking pistoncore-event_loop v0.36.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.45.3 [INFO] [stderr] Checking piston v0.36.0 [INFO] [stderr] Checking gfx v0.17.1 [INFO] [stderr] Checking gfx_device_gl v0.15.2 [INFO] [stderr] Checking piston-gfx_texture v0.31.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.50.0 [INFO] [stderr] Checking piston_window v0.77.0 [INFO] [stderr] Checking ncollide_math v0.9.0 [INFO] [stderr] Checking ncollide_utils v0.9.0 [INFO] [stderr] Checking ncollide_geometry v0.6.2 [INFO] [stderr] Checking ncollide_procedural v0.9.0 [INFO] [stderr] Checking ncollide_transformation v0.9.0 [INFO] [stderr] Checking ncollide_pipeline v0.13.1 [INFO] [stderr] Checking ncollide v0.14.1 [INFO] [stderr] Checking piston-tutorial v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/object_v2.rs:135:16 [INFO] [stderr] | [INFO] [stderr] 135 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 136 | | if self.rot_tur - new_rot > rot_speed * dt { [INFO] [stderr] 137 | | self.rot_tur -= rot_speed * dt; [INFO] [stderr] 138 | | } else { [INFO] [stderr] 139 | | self.rot_tur = new_rot; [INFO] [stderr] 140 | | } [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 135 | } else if self.rot_tur - new_rot > rot_speed * dt { [INFO] [stderr] 136 | self.rot_tur -= rot_speed * dt; [INFO] [stderr] 137 | } else { [INFO] [stderr] 138 | self.rot_tur = new_rot; [INFO] [stderr] 139 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/object_v3.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 157 | | if self.turret.trans.rot - new_rot > rot_speed * dt { [INFO] [stderr] 158 | | self.turret.trans.rot -= rot_speed * dt; [INFO] [stderr] 159 | | } else { [INFO] [stderr] 160 | | self.turret.trans.rot = new_rot; [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 156 | } else if self.turret.trans.rot - new_rot > rot_speed * dt { [INFO] [stderr] 157 | self.turret.trans.rot -= rot_speed * dt; [INFO] [stderr] 158 | } else { [INFO] [stderr] 159 | self.turret.trans.rot = new_rot; [INFO] [stderr] 160 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/object_v2.rs:135:16 [INFO] [stderr] | [INFO] [stderr] 135 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 136 | | if self.rot_tur - new_rot > rot_speed * dt { [INFO] [stderr] 137 | | self.rot_tur -= rot_speed * dt; [INFO] [stderr] 138 | | } else { [INFO] [stderr] 139 | | self.rot_tur = new_rot; [INFO] [stderr] 140 | | } [INFO] [stderr] 141 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 135 | } else if self.rot_tur - new_rot > rot_speed * dt { [INFO] [stderr] 136 | self.rot_tur -= rot_speed * dt; [INFO] [stderr] 137 | } else { [INFO] [stderr] 138 | self.rot_tur = new_rot; [INFO] [stderr] 139 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/object_v3.rs:156:16 [INFO] [stderr] | [INFO] [stderr] 156 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 157 | | if self.turret.trans.rot - new_rot > rot_speed * dt { [INFO] [stderr] 158 | | self.turret.trans.rot -= rot_speed * dt; [INFO] [stderr] 159 | | } else { [INFO] [stderr] 160 | | self.turret.trans.rot = new_rot; [INFO] [stderr] 161 | | } [INFO] [stderr] 162 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 156 | } else if self.turret.trans.rot - new_rot > rot_speed * dt { [INFO] [stderr] 157 | self.turret.trans.rot -= rot_speed * dt; [INFO] [stderr] 158 | } else { [INFO] [stderr] 159 | self.turret.trans.rot = new_rot; [INFO] [stderr] 160 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `object::Object` [INFO] [stderr] --> src/object.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Object { [INFO] [stderr] 13 | | Object { [INFO] [stderr] 14 | | x: 0.0, [INFO] [stderr] 15 | | y: 0.0, [INFO] [stderr] 16 | | sprite: None, [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `object_v2::ObjectV2` [INFO] [stderr] --> src/object_v2.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> ObjectV2 { [INFO] [stderr] 19 | | ObjectV2 { [INFO] [stderr] 20 | | x: 0.0, [INFO] [stderr] 21 | | y: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v2.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v2.rs:64:48 [INFO] [stderr] | [INFO] [stderr] 64 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v2.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v2.rs:80:48 [INFO] [stderr] | [INFO] [stderr] 80 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/object_v2.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | if new_rot == self.rot_tur { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_rot - self.rot_tur).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/object_v2.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | if new_rot == self.rot_tur { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/object_v3.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | self.pos = self.pos + v; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.pos += v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/object_v3.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / match self.sprite { [INFO] [stderr] 79 | | Some(ref sprite) => { [INFO] [stderr] 80 | | let (spritex, spritey) = sprite.get_size(); [INFO] [stderr] 81 | | let (ocx, ocy) = (spritex / 2, spritey / 2); [INFO] [stderr] ... | [INFO] [stderr] 91 | | _ => {} [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let Some(ref sprite) = self.sprite { [INFO] [stderr] 79 | let (spritex, spritey) = sprite.get_size(); [INFO] [stderr] 80 | let (ocx, ocy) = (spritex / 2, spritey / 2); [INFO] [stderr] 81 | image( [INFO] [stderr] 82 | sprite, [INFO] [stderr] 83 | view.trans(t.pos.x, t.pos.y) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v3.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v3.rs:87:48 [INFO] [stderr] | [INFO] [stderr] 87 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `object_v3::Tank` [INFO] [stderr] --> src/object_v3.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> Tank { [INFO] [stderr] 116 | | Tank { [INFO] [stderr] 117 | | hull: Component::new(), [INFO] [stderr] 118 | | turret: Component::new(), [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | impl Default for object_v3::Tank { [INFO] [stderr] 115 | fn default() -> Self { [INFO] [stderr] 116 | Self::new() [INFO] [stderr] 117 | } [INFO] [stderr] 118 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/object_v3.rs:132:12 [INFO] [stderr] | [INFO] [stderr] 132 | if new_rot == self.turret.trans.rot { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_rot - self.turret.trans.rot).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/object_v3.rs:132:12 [INFO] [stderr] | [INFO] [stderr] 132 | if new_rot == self.turret.trans.rot { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/object_v3.rs:175:34 [INFO] [stderr] | [INFO] [stderr] 175 | let pos = Isometry2::new(self.hull.trans.pos.clone(), zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.hull.trans.pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `piston-tutorial`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `object::Object` [INFO] [stderr] --> src/object.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> Object { [INFO] [stderr] 13 | | Object { [INFO] [stderr] 14 | | x: 0.0, [INFO] [stderr] 15 | | y: 0.0, [INFO] [stderr] 16 | | sprite: None, [INFO] [stderr] 17 | | } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `object_v2::ObjectV2` [INFO] [stderr] --> src/object_v2.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> ObjectV2 { [INFO] [stderr] 19 | | ObjectV2 { [INFO] [stderr] 20 | | x: 0.0, [INFO] [stderr] 21 | | y: 0.0, [INFO] [stderr] ... | [INFO] [stderr] 28 | | } [INFO] [stderr] 29 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v2.rs:64:33 [INFO] [stderr] | [INFO] [stderr] 64 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocx)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v2.rs:64:48 [INFO] [stderr] | [INFO] [stderr] 64 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v2.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v2.rs:80:48 [INFO] [stderr] | [INFO] [stderr] 80 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/object_v2.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | if new_rot == self.rot_tur { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_rot - self.rot_tur).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/object_v2.rs:115:12 [INFO] [stderr] | [INFO] [stderr] 115 | if new_rot == self.rot_tur { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/object_v3.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | self.pos = self.pos + v; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.pos += v` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/object_v3.rs:78:9 [INFO] [stderr] | [INFO] [stderr] 78 | / match self.sprite { [INFO] [stderr] 79 | | Some(ref sprite) => { [INFO] [stderr] 80 | | let (spritex, spritey) = sprite.get_size(); [INFO] [stderr] 81 | | let (ocx, ocy) = (spritex / 2, spritey / 2); [INFO] [stderr] ... | [INFO] [stderr] 91 | | _ => {} [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 78 | if let Some(ref sprite) = self.sprite { [INFO] [stderr] 79 | let (spritex, spritey) = sprite.get_size(); [INFO] [stderr] 80 | let (ocx, ocy) = (spritex / 2, spritey / 2); [INFO] [stderr] 81 | image( [INFO] [stderr] 82 | sprite, [INFO] [stderr] 83 | view.trans(t.pos.x, t.pos.y) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v3.rs:87:33 [INFO] [stderr] | [INFO] [stderr] 87 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/object_v3.rs:87:48 [INFO] [stderr] | [INFO] [stderr] 87 | .trans(-(ocx as f64), -(ocy as f64)), [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(ocy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `object_v3::Tank` [INFO] [stderr] --> src/object_v3.rs:115:5 [INFO] [stderr] | [INFO] [stderr] 115 | / pub fn new() -> Tank { [INFO] [stderr] 116 | | Tank { [INFO] [stderr] 117 | | hull: Component::new(), [INFO] [stderr] 118 | | turret: Component::new(), [INFO] [stderr] ... | [INFO] [stderr] 122 | | } [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 114 | impl Default for object_v3::Tank { [INFO] [stderr] 115 | fn default() -> Self { [INFO] [stderr] 116 | Self::new() [INFO] [stderr] 117 | } [INFO] [stderr] 118 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/object_v3.rs:132:12 [INFO] [stderr] | [INFO] [stderr] 132 | if new_rot == self.turret.trans.rot { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(new_rot - self.turret.trans.rot).abs() < error` [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/object_v3.rs:132:12 [INFO] [stderr] | [INFO] [stderr] 132 | if new_rot == self.turret.trans.rot { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/object_v3.rs:175:34 [INFO] [stderr] | [INFO] [stderr] 175 | let pos = Isometry2::new(self.hull.trans.pos.clone(), zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.hull.trans.pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `piston-tutorial`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "574181b44b15b0e7d2d44f97daec62fc8a80ca45aecd39c99e1cefbd28fec073"` [INFO] running `"docker" "rm" "-f" "574181b44b15b0e7d2d44f97daec62fc8a80ca45aecd39c99e1cefbd28fec073"` [INFO] [stdout] 574181b44b15b0e7d2d44f97daec62fc8a80ca45aecd39c99e1cefbd28fec073