[INFO] updating cached repository shybyte/exercises-in-programming-style-rust
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/shybyte/exercises-in-programming-style-rust
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/shybyte/exercises-in-programming-style-rust" "work/ex/clippy-test-run/sources/stable/gh/shybyte/exercises-in-programming-style-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shybyte/exercises-in-programming-style-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/shybyte/exercises-in-programming-style-rust" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shybyte/exercises-in-programming-style-rust"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shybyte/exercises-in-programming-style-rust'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] eeb1242d7416b4a4b163f9be2fdb4c19984f436f
[INFO] sha for GitHub repo shybyte/exercises-in-programming-style-rust: eeb1242d7416b4a4b163f9be2fdb4c19984f436f
[INFO] validating manifest of shybyte/exercises-in-programming-style-rust on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of shybyte/exercises-in-programming-style-rust on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing shybyte/exercises-in-programming-style-rust
[INFO] finished frobbing shybyte/exercises-in-programming-style-rust
[INFO] frobbed toml for shybyte/exercises-in-programming-style-rust written to work/ex/clippy-test-run/sources/stable/gh/shybyte/exercises-in-programming-style-rust/Cargo.toml
[INFO] started frobbing shybyte/exercises-in-programming-style-rust
[INFO] finished frobbing shybyte/exercises-in-programming-style-rust
[INFO] frobbed toml for shybyte/exercises-in-programming-style-rust written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shybyte/exercises-in-programming-style-rust/Cargo.toml
[INFO] crate shybyte/exercises-in-programming-style-rust has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting shybyte/exercises-in-programming-style-rust against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shybyte/exercises-in-programming-style-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] c1855f7fd96a4512c48d4b8782fb58a105098c5a48d1f27d384f300108cf3794
[INFO] running `"docker" "start" "-a" "c1855f7fd96a4512c48d4b8782fb58a105098c5a48d1f27d384f300108cf3794"`
[INFO] [stderr]     Checking exercises_in_programming_style_rust v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &chars.enumerate()` or similar iterators
[INFO] [stderr]   --> src/bin/03-monolith.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |         for c in &chars {
[INFO] [stderr]    |                  ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/bin/03-monolith.rs:31:29
[INFO] [stderr]    |
[INFO] [stderr] 31 |                         for ref mut pair in &mut word_freqs {
[INFO] [stderr]    |                             ^^^^^^^^^^^^    --------------- help: try: `let pair = &mut &mut word_freqs;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in &chars.enumerate()` or similar iterators
[INFO] [stderr]   --> src/bin/03-monolith.rs:22:18
[INFO] [stderr]    |
[INFO] [stderr] 22 |         for c in &chars {
[INFO] [stderr]    |                  ^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/bin/03-monolith.rs:31:29
[INFO] [stderr]    |
[INFO] [stderr] 31 |                         for ref mut pair in &mut word_freqs {
[INFO] [stderr]    |                             ^^^^^^^^^^^^    --------------- help: try: `let pair = &mut &mut word_freqs;`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/bin/05-pipeline.rs:27:25
[INFO] [stderr]    |
[INFO] [stderr] 27 |         .filter(|&word| word.len() >= 1)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!word.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     /// Takes a path to a file and assigns the entire
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_doc_comments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     /// Replaces all nonalphanumeric chars in data with white space
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     /// Scans data for words, filling the global variable words
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     /// Scans data for words, filling the global variable words
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     /// Creates a list of pairs associating words with frequencies
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     /// Sorts word_freqs by frequency
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:16:5
[INFO] [stderr]    |
[INFO] [stderr] 16 |     /// Takes a path to a file and assigns the entire
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_doc_comments)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     /// Replaces all nonalphanumeric chars in data with white space
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:36:5
[INFO] [stderr]    |
[INFO] [stderr] 36 |     /// Scans data for words, filling the global variable words
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:42:5
[INFO] [stderr]    |
[INFO] [stderr] 42 |     /// Scans data for words, filling the global variable words
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:61:5
[INFO] [stderr]    |
[INFO] [stderr] 61 |     /// Creates a list of pairs associating words with frequencies
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: doc comment not used by rustdoc
[INFO] [stderr]   --> src/bin/04-cookbook.rs:73:5
[INFO] [stderr]    |
[INFO] [stderr] 73 |     /// Sorts word_freqs by frequency
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/bin/05-pipeline.rs:27:25
[INFO] [stderr]    |
[INFO] [stderr] 27 |         .filter(|&word| word.len() >= 1)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!word.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/bin/10-things.rs:42:29
[INFO] [stderr]    |
[INFO] [stderr] 42 |             .filter(|&word| word.len() >= 1)
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!word.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/bin/10-things.rs:42:29
[INFO] [stderr]    |
[INFO] [stderr] 42 |             .filter(|&word| word.len() >= 1)
[INFO] [stderr]    |                             ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!word.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/bin/09-the-one.rs:57:25
[INFO] [stderr]    |
[INFO] [stderr] 57 |         .filter(|&word| word.len() >= 1)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!word.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]   --> src/bin/09-the-one.rs:57:25
[INFO] [stderr]    |
[INFO] [stderr] 57 |         .filter(|&word| word.len() >= 1)
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!word.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.69s
[INFO] running `"docker" "inspect" "c1855f7fd96a4512c48d4b8782fb58a105098c5a48d1f27d384f300108cf3794"`
[INFO] running `"docker" "rm" "-f" "c1855f7fd96a4512c48d4b8782fb58a105098c5a48d1f27d384f300108cf3794"`
[INFO] [stdout] c1855f7fd96a4512c48d4b8782fb58a105098c5a48d1f27d384f300108cf3794