[INFO] updating cached repository shwcsmack/http_test [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shwcsmack/http_test [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shwcsmack/http_test" "work/ex/clippy-test-run/sources/stable/gh/shwcsmack/http_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shwcsmack/http_test'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shwcsmack/http_test" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shwcsmack/http_test"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shwcsmack/http_test'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b34f99fa3b5642a7a0c3c22ee8654bceafbc6bdb [INFO] sha for GitHub repo shwcsmack/http_test: b34f99fa3b5642a7a0c3c22ee8654bceafbc6bdb [INFO] validating manifest of shwcsmack/http_test on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shwcsmack/http_test on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shwcsmack/http_test [INFO] finished frobbing shwcsmack/http_test [INFO] frobbed toml for shwcsmack/http_test written to work/ex/clippy-test-run/sources/stable/gh/shwcsmack/http_test/Cargo.toml [INFO] started frobbing shwcsmack/http_test [INFO] finished frobbing shwcsmack/http_test [INFO] frobbed toml for shwcsmack/http_test written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shwcsmack/http_test/Cargo.toml [INFO] crate shwcsmack/http_test has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shwcsmack/http_test against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shwcsmack/http_test:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 880aa9a7c7cfb00e0aa63cfced4d49e92e9375ef7d5cd5d72daf91359e0d648c [INFO] running `"docker" "start" "-a" "880aa9a7c7cfb00e0aa63cfced4d49e92e9375ef7d5cd5d72daf91359e0d648c"` [INFO] [stderr] Checking http_test v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:77:16 [INFO] [stderr] | [INFO] [stderr] 77 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 78 | | if byte != 10 { [INFO] [stderr] 79 | | temp.push(byte); [INFO] [stderr] 80 | | } else if byte == 10 && temp[0] == 13 { [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | } else if byte != 10 { [INFO] [stderr] 78 | temp.push(byte); [INFO] [stderr] 79 | } else if byte == 10 && temp[0] == 13 { [INFO] [stderr] 80 | //Should be the start of the data [INFO] [stderr] 81 | data_flag = true; [INFO] [stderr] 82 | temp.drain(..); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:77:16 [INFO] [stderr] | [INFO] [stderr] 77 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 78 | | if byte != 10 { [INFO] [stderr] 79 | | temp.push(byte); [INFO] [stderr] 80 | | } else if byte == 10 && temp[0] == 13 { [INFO] [stderr] ... | [INFO] [stderr] 90 | | } [INFO] [stderr] 91 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 77 | } else if byte != 10 { [INFO] [stderr] 78 | temp.push(byte); [INFO] [stderr] 79 | } else if byte == 10 && temp[0] == 13 { [INFO] [stderr] 80 | //Should be the start of the data [INFO] [stderr] 81 | data_flag = true; [INFO] [stderr] 82 | temp.drain(..); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/lib.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | stream.write(&req.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | if headerin.contains("\r"){ [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `http_test`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/lib.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | stream.write(&req.as_bytes())?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:111:26 [INFO] [stderr] | [INFO] [stderr] 111 | if headerin.contains("\r"){ [INFO] [stderr] | ^^^^ help: try using a char instead: `'\r'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `http_test`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "880aa9a7c7cfb00e0aa63cfced4d49e92e9375ef7d5cd5d72daf91359e0d648c"` [INFO] running `"docker" "rm" "-f" "880aa9a7c7cfb00e0aa63cfced4d49e92e9375ef7d5cd5d72daf91359e0d648c"` [INFO] [stdout] 880aa9a7c7cfb00e0aa63cfced4d49e92e9375ef7d5cd5d72daf91359e0d648c