[INFO] updating cached repository shuhei/colortty [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shuhei/colortty [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shuhei/colortty" "work/ex/clippy-test-run/sources/stable/gh/shuhei/colortty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shuhei/colortty'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shuhei/colortty" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shuhei/colortty"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shuhei/colortty'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c75171850e36ed83f2b1045dd10f1cb947824819 [INFO] sha for GitHub repo shuhei/colortty: c75171850e36ed83f2b1045dd10f1cb947824819 [INFO] validating manifest of shuhei/colortty on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shuhei/colortty on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shuhei/colortty [INFO] finished frobbing shuhei/colortty [INFO] frobbed toml for shuhei/colortty written to work/ex/clippy-test-run/sources/stable/gh/shuhei/colortty/Cargo.toml [INFO] started frobbing shuhei/colortty [INFO] finished frobbing shuhei/colortty [INFO] frobbed toml for shuhei/colortty written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shuhei/colortty/Cargo.toml [INFO] crate shuhei/colortty has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shuhei/colortty against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shuhei/colortty:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 648cb24976a2dec73b2f002775e6a897aa795724e0ef29c5bb536be282ef9921 [INFO] running `"docker" "start" "-a" "648cb24976a2dec73b2f002775e6a897aa795724e0ef29c5bb536be282ef9921"` [INFO] [stderr] Compiling error-chain v0.7.2 [INFO] [stderr] Checking unicode-normalization v0.1.3 [INFO] [stderr] Checking libc v0.2.19 [INFO] [stderr] Checking httparse v1.2.1 [INFO] [stderr] Checking json v0.11.4 [INFO] [stderr] Checking RustyXML v0.1.1 [INFO] [stderr] Checking unicase v1.4.0 [INFO] [stderr] Compiling metadeps v1.1.1 [INFO] [stderr] Checking num_cpus v1.2.1 [INFO] [stderr] Checking time v0.1.36 [INFO] [stderr] Compiling openssl-sys v0.9.6 [INFO] [stderr] Checking idna v0.1.0 [INFO] [stderr] Compiling openssl v0.9.6 [INFO] [stderr] Checking url v1.2.4 [INFO] [stderr] Checking hyper v0.10.0 [INFO] [stderr] Checking hyper-openssl v0.2.1 [INFO] [stderr] Checking colortty v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | let color = Color { red: red, green: green, blue: blue }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `red` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:54:39 [INFO] [stderr] | [INFO] [stderr] 54 | let color = Color { red: red, green: green, blue: blue }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `green` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:54:53 [INFO] [stderr] | [INFO] [stderr] 54 | let color = Color { red: red, green: green, blue: blue }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `blue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:54:29 [INFO] [stderr] | [INFO] [stderr] 54 | let color = Color { red: red, green: green, blue: blue }; [INFO] [stderr] | ^^^^^^^^ help: replace it with: `red` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:54:39 [INFO] [stderr] | [INFO] [stderr] 54 | let color = Color { red: red, green: green, blue: blue }; [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `green` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/color.rs:54:53 [INFO] [stderr] | [INFO] [stderr] 54 | let color = Color { red: red, green: green, blue: blue }; [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `blue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/color.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | return Some(ColorSchemeFormat::ITerm); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ColorSchemeFormat::ITerm)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/color.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | return Some(ColorSchemeFormat::Mintty); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ColorSchemeFormat::Mintty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/color.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/color.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | return Some(ColorSchemeFormat::ITerm); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ColorSchemeFormat::ITerm)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/color.rs:24:13 [INFO] [stderr] | [INFO] [stderr] 24 | return Some(ColorSchemeFormat::Mintty); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(ColorSchemeFormat::Mintty)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/color.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/color.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | let rgb: Vec<_> = s.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/color.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / match first { [INFO] [stderr] 70 | | &Xml::CharacterNode(ref text) => text, [INFO] [stderr] 71 | | _ => panic!("Not an chracter node: {}", first), [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *first { [INFO] [stderr] 70 | Xml::CharacterNode(ref text) => text, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/color.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | let components: Vec<&str> = line.split("=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/color.rs:47:35 [INFO] [stderr] | [INFO] [stderr] 47 | let rgb: Vec<_> = s.split(",").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/color.rs:69:5 [INFO] [stderr] | [INFO] [stderr] 69 | / match first { [INFO] [stderr] 70 | | &Xml::CharacterNode(ref text) => text, [INFO] [stderr] 71 | | _ => panic!("Not an chracter node: {}", first), [INFO] [stderr] 72 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 69 | match *first { [INFO] [stderr] 70 | Xml::CharacterNode(ref text) => text, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/color.rs:103:52 [INFO] [stderr] | [INFO] [stderr] 103 | let components: Vec<&str> = line.split("=").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> tests/color.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | return fixture; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `fixture` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | _ => panic!(format!("{}", args[1])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `args[1].to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return buffer; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `buffer` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | _ => panic!(format!("{}", args[1])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `args[1].to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.92s [INFO] running `"docker" "inspect" "648cb24976a2dec73b2f002775e6a897aa795724e0ef29c5bb536be282ef9921"` [INFO] running `"docker" "rm" "-f" "648cb24976a2dec73b2f002775e6a897aa795724e0ef29c5bb536be282ef9921"` [INFO] [stdout] 648cb24976a2dec73b2f002775e6a897aa795724e0ef29c5bb536be282ef9921