[INFO] updating cached repository shqld/rust-git
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/shqld/rust-git
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/shqld/rust-git" "work/ex/clippy-test-run/sources/stable/gh/shqld/rust-git"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shqld/rust-git'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/shqld/rust-git" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shqld/rust-git"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shqld/rust-git'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 64d7eb7e50fe0ec4702731cb0eedddfa8110d1b1
[INFO] sha for GitHub repo shqld/rust-git: 64d7eb7e50fe0ec4702731cb0eedddfa8110d1b1
[INFO] validating manifest of shqld/rust-git on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of shqld/rust-git on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing shqld/rust-git
[INFO] finished frobbing shqld/rust-git
[INFO] frobbed toml for shqld/rust-git written to work/ex/clippy-test-run/sources/stable/gh/shqld/rust-git/Cargo.toml
[INFO] started frobbing shqld/rust-git
[INFO] finished frobbing shqld/rust-git
[INFO] frobbed toml for shqld/rust-git written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shqld/rust-git/Cargo.toml
[INFO] crate shqld/rust-git has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting shqld/rust-git against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shqld/rust-git:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bee9135705cfdf822c49a56854ad015b28c818ebba21cd434df411d96bb8fe36
[INFO] running `"docker" "start" "-a" "bee9135705cfdf822c49a56854ad015b28c818ebba21cd434df411d96bb8fe36"`
[INFO] [stderr]    Compiling libz-sys v1.0.18
[INFO] [stderr]     Checking digest v0.7.2
[INFO] [stderr]     Checking sha-1 v0.7.0
[INFO] [stderr]     Checking flate2 v1.0.1
[INFO] [stderr]     Checking rust-git v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/objects/file_mode.rs:15:14
[INFO] [stderr]    |
[INFO] [stderr] 15 |       NEW => 0000000,
[INFO] [stderr]    |              ^^^^^^^ help: consider: `0_000_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]   --> src/objects/file_mode.rs:16:15
[INFO] [stderr]    |
[INFO] [stderr] 16 |       TREE => 0040000,
[INFO] [stderr]    |               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::zero_prefixed_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]    |
[INFO] [stderr] 16 |       TREE => 40000,
[INFO] [stderr]    |               ^^^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]    |
[INFO] [stderr] 16 |       TREE => 0o40000,
[INFO] [stderr]    |               ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/objects/file_mode.rs:16:15
[INFO] [stderr]    |
[INFO] [stderr] 16 |       TREE => 0040000,
[INFO] [stderr]    |               ^^^^^^^ help: consider: `0_040_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]   --> src/objects/file_mode.rs:17:15
[INFO] [stderr]    |
[INFO] [stderr] 17 |       BLOB => 0100644,
[INFO] [stderr]    |               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]    |
[INFO] [stderr] 17 |       BLOB => 100644,
[INFO] [stderr]    |               ^^^^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]    |
[INFO] [stderr] 17 |       BLOB => 0o100644,
[INFO] [stderr]    |               ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/objects/file_mode.rs:17:15
[INFO] [stderr]    |
[INFO] [stderr] 17 |       BLOB => 0100644,
[INFO] [stderr]    |               ^^^^^^^ help: consider: `0_100_644`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]   --> src/objects/file_mode.rs:20:17
[INFO] [stderr]    |
[INFO] [stderr] 20 |       COMMIT => 0160000,
[INFO] [stderr]    |                 ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]    |
[INFO] [stderr] 20 |       COMMIT => 160000,
[INFO] [stderr]    |                 ^^^^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]    |
[INFO] [stderr] 20 |       COMMIT => 0o160000,
[INFO] [stderr]    |                 ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/objects/file_mode.rs:20:17
[INFO] [stderr]    |
[INFO] [stderr] 20 |       COMMIT => 0160000,
[INFO] [stderr]    |                 ^^^^^^^ help: consider: `0_160_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/objects/file_mode.rs:15:14
[INFO] [stderr]    |
[INFO] [stderr] 15 |       NEW => 0000000,
[INFO] [stderr]    |              ^^^^^^^ help: consider: `0_000_000`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]   --> src/objects/file_mode.rs:16:15
[INFO] [stderr]    |
[INFO] [stderr] 16 |       TREE => 0040000,
[INFO] [stderr]    |               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::zero_prefixed_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]    |
[INFO] [stderr] 16 |       TREE => 40000,
[INFO] [stderr]    |               ^^^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]    |
[INFO] [stderr] 16 |       TREE => 0o40000,
[INFO] [stderr]    |               ^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/objects/file_mode.rs:16:15
[INFO] [stderr]    |
[INFO] [stderr] 16 |       TREE => 0040000,
[INFO] [stderr]    |               ^^^^^^^ help: consider: `0_040_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]   --> src/objects/file_mode.rs:17:15
[INFO] [stderr]    |
[INFO] [stderr] 17 |       BLOB => 0100644,
[INFO] [stderr]    |               ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]    |
[INFO] [stderr] 17 |       BLOB => 100644,
[INFO] [stderr]    |               ^^^^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]    |
[INFO] [stderr] 17 |       BLOB => 0o100644,
[INFO] [stderr]    |               ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/objects/file_mode.rs:17:15
[INFO] [stderr]    |
[INFO] [stderr] 17 |       BLOB => 0100644,
[INFO] [stderr]    |               ^^^^^^^ help: consider: `0_100_644`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: this is a decimal constant
[INFO] [stderr]   --> src/objects/file_mode.rs:20:17
[INFO] [stderr]    |
[INFO] [stderr] 20 |       COMMIT => 0160000,
[INFO] [stderr]    |                 ^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal
[INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion
[INFO] [stderr]    |
[INFO] [stderr] 20 |       COMMIT => 160000,
[INFO] [stderr]    |                 ^^^^^^
[INFO] [stderr] help: if you mean to use an octal constant, use `0o`
[INFO] [stderr]    |
[INFO] [stderr] 20 |       COMMIT => 0o160000,
[INFO] [stderr]    |                 ^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/objects/file_mode.rs:20:17
[INFO] [stderr]    |
[INFO] [stderr] 20 |       COMMIT => 0160000,
[INFO] [stderr]    |                 ^^^^^^^ help: consider: `0_160_000`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/objects/blob.rs:15:19
[INFO] [stderr]    |
[INFO] [stderr] 15 |     pub fn new(s: &String) -> Blob {
[INFO] [stderr]    |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/objects/blob.rs:25:34
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn create_store(content: &String) -> String {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/objects/file_mode.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 |   pub fn from_string(s: &String) -> FileMode {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/objects/object.rs:10:22
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub fn get_object(s: &String) -> impl Object {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/utils/digest.rs:4:23
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn digest(string: &String) -> String {
[INFO] [stderr]   |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils/fs.rs:29:41
[INFO] [stderr]    |
[INFO] [stderr] 29 | pub fn write_file(path: &Path, content: &Vec<u8>) -> io::Result<()> {
[INFO] [stderr]    |                                         ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/utils/zlib.rs:10:20
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub fn compress(s: &String) -> Vec<u8> {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/utils/zlib.rs:12:3
[INFO] [stderr]    |
[INFO] [stderr] 12 |   e.write_all(s.as_bytes());
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/utils/zlib.rs:19:3
[INFO] [stderr]    |
[INFO] [stderr] 19 |   z.read_to_string(&mut s);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/utils/mod.rs:5:31
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn get_bytes_size(string: &String) -> usize {
[INFO] [stderr]   |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/utils/mod.rs:9:30
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn get_file_path(hashed: &String) -> String {
[INFO] [stderr]   |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:16:22
[INFO] [stderr]    |
[INFO] [stderr] 16 | fn rit_add(path_str: &String) {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     fs::write_file(&Path::new(&path), &compressed);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:28:25
[INFO] [stderr]    |
[INFO] [stderr] 28 | fn rit_cat_file_p(hash: &String) {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:42:39
[INFO] [stderr]    |
[INFO] [stderr] 42 |         "cat-file" => rit_cat_file_p(&args.get(2).unwrap()),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:43:27
[INFO] [stderr]    |
[INFO] [stderr] 43 |         "add" => rit_add(&args.get(2).unwrap()),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/objects/blob.rs:15:19
[INFO] [stderr]    |
[INFO] [stderr] 15 |     pub fn new(s: &String) -> Blob {
[INFO] [stderr]    |                   ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/objects/blob.rs:25:34
[INFO] [stderr]    |
[INFO] [stderr] 25 |     pub fn create_store(content: &String) -> String {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/objects/file_mode.rs:25:25
[INFO] [stderr]    |
[INFO] [stderr] 25 |   pub fn from_string(s: &String) -> FileMode {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/objects/object.rs:10:22
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub fn get_object(s: &String) -> impl Object {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/utils/digest.rs:4:23
[INFO] [stderr]   |
[INFO] [stderr] 4 | pub fn digest(string: &String) -> String {
[INFO] [stderr]   |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/utils/fs.rs:29:41
[INFO] [stderr]    |
[INFO] [stderr] 29 | pub fn write_file(path: &Path, content: &Vec<u8>) -> io::Result<()> {
[INFO] [stderr]    |                                         ^^^^^^^^ help: change this to: `&[u8]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/utils/zlib.rs:10:20
[INFO] [stderr]    |
[INFO] [stderr] 10 | pub fn compress(s: &String) -> Vec<u8> {
[INFO] [stderr]    |                    ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/utils/zlib.rs:12:3
[INFO] [stderr]    |
[INFO] [stderr] 12 |   e.write_all(s.as_bytes());
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/utils/zlib.rs:19:3
[INFO] [stderr]    |
[INFO] [stderr] 19 |   z.read_to_string(&mut s);
[INFO] [stderr]    |   ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/utils/mod.rs:5:31
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn get_bytes_size(string: &String) -> usize {
[INFO] [stderr]   |                               ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]  --> src/utils/mod.rs:9:30
[INFO] [stderr]   |
[INFO] [stderr] 9 | pub fn get_file_path(hashed: &String) -> String {
[INFO] [stderr]   |                              ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:16:22
[INFO] [stderr]    |
[INFO] [stderr] 16 | fn rit_add(path_str: &String) {
[INFO] [stderr]    |                      ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]   --> src/main.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 |     fs::write_file(&Path::new(&path), &compressed);
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/main.rs:28:25
[INFO] [stderr]    |
[INFO] [stderr] 28 | fn rit_cat_file_p(hash: &String) {
[INFO] [stderr]    |                         ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:42:39
[INFO] [stderr]    |
[INFO] [stderr] 42 |         "cat-file" => rit_cat_file_p(&args.get(2).unwrap()),
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise
[INFO] [stderr]   --> src/main.rs:43:27
[INFO] [stderr]    |
[INFO] [stderr] 43 |         "add" => rit_add(&args.get(2).unwrap()),
[INFO] [stderr]    |                           ^^^^^^^^^^^^^^^^^^^^ help: try this: `&args[2]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.41s
[INFO] running `"docker" "inspect" "bee9135705cfdf822c49a56854ad015b28c818ebba21cd434df411d96bb8fe36"`
[INFO] running `"docker" "rm" "-f" "bee9135705cfdf822c49a56854ad015b28c818ebba21cd434df411d96bb8fe36"`
[INFO] [stdout] bee9135705cfdf822c49a56854ad015b28c818ebba21cd434df411d96bb8fe36