[INFO] updating cached repository shousper/rust_bucket [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shousper/rust_bucket [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shousper/rust_bucket" "work/ex/clippy-test-run/sources/stable/gh/shousper/rust_bucket"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shousper/rust_bucket'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shousper/rust_bucket" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shousper/rust_bucket"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shousper/rust_bucket'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a88e6b39bb1ad91459545709aa70043f9e30f69e [INFO] sha for GitHub repo shousper/rust_bucket: a88e6b39bb1ad91459545709aa70043f9e30f69e [INFO] validating manifest of shousper/rust_bucket on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shousper/rust_bucket on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shousper/rust_bucket [INFO] finished frobbing shousper/rust_bucket [INFO] frobbed toml for shousper/rust_bucket written to work/ex/clippy-test-run/sources/stable/gh/shousper/rust_bucket/Cargo.toml [INFO] started frobbing shousper/rust_bucket [INFO] finished frobbing shousper/rust_bucket [INFO] frobbed toml for shousper/rust_bucket written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shousper/rust_bucket/Cargo.toml [INFO] crate shousper/rust_bucket has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shousper/rust_bucket against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shousper/rust_bucket:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 67132376437b7c735b5addfc0531680c96bf58de7a575b390c44d6bb4b34ec8e [INFO] running `"docker" "start" "-a" "67132376437b7c735b5addfc0531680c96bf58de7a575b390c44d6bb4b34ec8e"` [INFO] [stderr] Checking num-traits v0.2.3 [INFO] [stderr] Checking serde v0.9.15 [INFO] [stderr] Checking utf-8 v0.7.2 [INFO] [stderr] Checking rand_core v0.2.0 [INFO] [stderr] Checking base64 v0.9.2 [INFO] [stderr] Checking input_buffer v0.1.1 [INFO] [stderr] Checking serde_json v1.0.19 [INFO] [stderr] Checking hyper v0.10.13 [INFO] [stderr] Checking env_logger v0.5.10 [INFO] [stderr] Checking rand v0.5.0 [INFO] [stderr] Checking tungstenite v0.5.3 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking hyper-native-tls v0.2.4 [INFO] [stderr] Checking serde_urlencoded v0.4.3 [INFO] [stderr] Checking serde_json v0.9.10 [INFO] [stderr] Checking reqwest v0.4.0 [INFO] [stderr] Checking slack_api v0.19.0 [INFO] [stderr] Checking slack v0.20.0 [INFO] [stderr] Checking rust_bucket v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/handlers/corey_hotline.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | const RESPONSES: &'static [&str] = &[ [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handlers/corey_hotline.rs:361:9 [INFO] [stderr] | [INFO] [stderr] 361 | return String::from("CoreyHotline") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("CoreyHotline")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handlers/corey_hotline.rs:364:9 [INFO] [stderr] | [INFO] [stderr] 364 | return command == "corey" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `command == "corey"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/handlers/corey_hotline.rs:5:19 [INFO] [stderr] | [INFO] [stderr] 5 | const RESPONSES: &'static [&str] = &[ [INFO] [stderr] | -^^^^^^^------- help: consider removing `'static`: `&[&str]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handlers/corey_hotline.rs:361:9 [INFO] [stderr] | [INFO] [stderr] 361 | return String::from("CoreyHotline") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `String::from("CoreyHotline")` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handlers/corey_hotline.rs:364:9 [INFO] [stderr] | [INFO] [stderr] 364 | return command == "corey" [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `command == "corey"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:63:49 [INFO] [stderr] | [INFO] [stderr] 63 | info!("Discovered slf: {}", slf.name.unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `slf.name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:69:54 [INFO] [stderr] | [INFO] [stderr] 69 | info!("Discovered user: {}", v.name.unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v.name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:76:54 [INFO] [stderr] | [INFO] [stderr] 76 | info!("Discovered mpim: {}", v.name.unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v.name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:83:57 [INFO] [stderr] | [INFO] [stderr] 83 | info!("Discovered channel: {}", v.name.unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v.name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:90:55 [INFO] [stderr] | [INFO] [stderr] 90 | info!("Discovered group: {}", v.name.unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v.name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:111:42 [INFO] [stderr] | [INFO] [stderr] 111 | let channel_id = msg.channel.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.channel.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:112:36 [INFO] [stderr] | [INFO] [stderr] 112 | let text = msg.text.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | Err(_) => panic!("Failed to get SLACK_BOT_TOKEN from env"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:63:49 [INFO] [stderr] | [INFO] [stderr] 63 | info!("Discovered slf: {}", slf.name.unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `slf.name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:69:54 [INFO] [stderr] | [INFO] [stderr] 69 | info!("Discovered user: {}", v.name.unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v.name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:76:54 [INFO] [stderr] | [INFO] [stderr] 76 | info!("Discovered mpim: {}", v.name.unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v.name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:83:57 [INFO] [stderr] | [INFO] [stderr] 83 | info!("Discovered channel: {}", v.name.unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v.name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:90:55 [INFO] [stderr] | [INFO] [stderr] 90 | info!("Discovered group: {}", v.name.unwrap_or(String::new())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `v.name.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:111:42 [INFO] [stderr] | [INFO] [stderr] 111 | let channel_id = msg.channel.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.channel.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bot.rs:112:36 [INFO] [stderr] | [INFO] [stderr] 112 | let text = msg.text.unwrap_or(String::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `msg.text.unwrap_or_default()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/main.rs:23:9 [INFO] [stderr] | [INFO] [stderr] 23 | Err(_) => panic!("Failed to get SLACK_BOT_TOKEN from env"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 57.53s [INFO] running `"docker" "inspect" "67132376437b7c735b5addfc0531680c96bf58de7a575b390c44d6bb4b34ec8e"` [INFO] running `"docker" "rm" "-f" "67132376437b7c735b5addfc0531680c96bf58de7a575b390c44d6bb4b34ec8e"` [INFO] [stdout] 67132376437b7c735b5addfc0531680c96bf58de7a575b390c44d6bb4b34ec8e