[INFO] updating cached repository shockham/crony [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shockham/crony [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shockham/crony" "work/ex/clippy-test-run/sources/stable/gh/shockham/crony"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shockham/crony'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shockham/crony" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shockham/crony"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shockham/crony'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 8904a2c5716e9875b900067f60a45ba610d47da8 [INFO] sha for GitHub repo shockham/crony: 8904a2c5716e9875b900067f60a45ba610d47da8 [INFO] validating manifest of shockham/crony on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shockham/crony on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shockham/crony [INFO] finished frobbing shockham/crony [INFO] frobbed toml for shockham/crony written to work/ex/clippy-test-run/sources/stable/gh/shockham/crony/Cargo.toml [INFO] started frobbing shockham/crony [INFO] finished frobbing shockham/crony [INFO] frobbed toml for shockham/crony written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shockham/crony/Cargo.toml [INFO] crate shockham/crony has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shockham/crony against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shockham/crony:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 62161ef795e1302756b57567e2e47dd81ac6dfa122c79af39d890e0555dbdf15 [INFO] running `"docker" "start" "-a" "62161ef795e1302756b57567e2e47dd81ac6dfa122c79af39d890e0555dbdf15"` [INFO] [stderr] Checking mio v0.6.16 [INFO] [stderr] Checking tokio-io v0.1.10 [INFO] [stderr] Checking tokio-threadpool v0.1.9 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.4 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking mio-uds v0.6.7 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking crony v0.1.0 (/opt/crater/workdir) [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:18:35 [INFO] [stderr] | [INFO] [stderr] 18 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: length comparison to zero [INFO] [stderr] --> src/main.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | if vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::len_zero)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `crony`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: length comparison to zero [INFO] [stderr] --> examples/test_client.rs:55:16 [INFO] [stderr] | [INFO] [stderr] 55 | if buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> examples/test_client.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::len_zero)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `crony`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:18:35 [INFO] [stderr] | [INFO] [stderr] 18 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: length comparison to zero [INFO] [stderr] --> src/main.rs:53:32 [INFO] [stderr] | [INFO] [stderr] 53 | if vec.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `vec.is_empty()` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:1:9 [INFO] [stderr] | [INFO] [stderr] 1 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::len_zero)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `crony`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "62161ef795e1302756b57567e2e47dd81ac6dfa122c79af39d890e0555dbdf15"` [INFO] running `"docker" "rm" "-f" "62161ef795e1302756b57567e2e47dd81ac6dfa122c79af39d890e0555dbdf15"` [INFO] [stdout] 62161ef795e1302756b57567e2e47dd81ac6dfa122c79af39d890e0555dbdf15