[INFO] updating cached repository shnarazk/splr [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shnarazk/splr [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shnarazk/splr" "work/ex/clippy-test-run/sources/stable/gh/shnarazk/splr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shnarazk/splr'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shnarazk/splr" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shnarazk/splr"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shnarazk/splr'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] dc2f47097b7748a323caad8ca472d14146fa8af9 [INFO] sha for GitHub repo shnarazk/splr: dc2f47097b7748a323caad8ca472d14146fa8af9 [INFO] validating manifest of shnarazk/splr on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shnarazk/splr on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shnarazk/splr [INFO] finished frobbing shnarazk/splr [INFO] frobbed toml for shnarazk/splr written to work/ex/clippy-test-run/sources/stable/gh/shnarazk/splr/Cargo.toml [INFO] started frobbing shnarazk/splr [INFO] finished frobbing shnarazk/splr [INFO] frobbed toml for shnarazk/splr written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shnarazk/splr/Cargo.toml [INFO] crate shnarazk/splr has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shnarazk/splr against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shnarazk/splr:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5cc6d9b28d062ab45c9abd9fd72e3e2d9662fbc1dcb470b4cdc3d3b2c745a93e [INFO] running `"docker" "start" "-a" "5cc6d9b28d062ab45c9abd9fd72e3e2d9662fbc1dcb470b4cdc3d3b2c745a93e"` [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking splr v0.0.11 (/opt/crater/workdir) [INFO] [stderr] error: only functions may be used as tests [INFO] [stderr] --> src/eliminator.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | use std::fmt; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: only functions may be used as tests [INFO] [stderr] --> src/eliminator.rs:108:1 [INFO] [stderr] | [INFO] [stderr] 108 | / impl fmt::Display for Eliminator { [INFO] [stderr] 109 | | fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { [INFO] [stderr] 110 | | write!( [INFO] [stderr] 111 | | f, [INFO] [stderr] ... | [INFO] [stderr] 115 | | } [INFO] [stderr] 116 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `splr`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/clause.rs:183:61 [INFO] [stderr] | [INFO] [stderr] 183 | pub fn set_flag(&mut self, flag: ClauseFlag, val: bool) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/clause.rs:334:43 [INFO] [stderr] | [INFO] [stderr] 334 | fn bump_cid(&mut self, cid: ClauseId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/clause.rs:364:38 [INFO] [stderr] | [INFO] [stderr] 364 | fn decay_cla_activity(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/clause.rs:438:48 [INFO] [stderr] | [INFO] [stderr] 438 | fn remove_clause(&mut self, cid: ClauseId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/clause.rs:465:71 [INFO] [stderr] | [INFO] [stderr] 465 | fn change_clause_kind(&mut self, cid: ClauseId, kind: ClauseKind) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/clause.rs:486:26 [INFO] [stderr] | [INFO] [stderr] 486 | fn reduce(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/clause.rs:596:39 [INFO] [stderr] | [INFO] [stderr] 596 | fn dump_cnf(&self, fname: String) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/clause.rs:634:82 [INFO] [stderr] | [INFO] [stderr] 634 | fn garbage_collect(&mut self, vars: &mut [Var], eliminator: &mut Eliminator) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/clause.rs:774:63 [INFO] [stderr] | [INFO] [stderr] 774 | fn reset_lbd(&mut self, vars: &[Var], temp: &mut [usize]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/eliminator.rs:89:44 [INFO] [stderr] | [INFO] [stderr] 89 | fn enqueue_var(&mut self, v: &mut Var) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/eliminator.rs:119:91 [INFO] [stderr] | [INFO] [stderr] 119 | fn eliminator_register_clause(&mut self, cid: ClauseId, rank: usize, ignorable: bool) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/eliminator.rs:139:60 [INFO] [stderr] | [INFO] [stderr] 139 | fn eliminator_enqueue_clause(&mut self, cid: ClauseId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/eliminator.rs:160:53 [INFO] [stderr] | [INFO] [stderr] 160 | fn eliminator_enqueue_var(&mut self, vi: VarId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/eliminator.rs:166:63 [INFO] [stderr] | [INFO] [stderr] 166 | fn eliminator_unregister_clause(&mut self, cid: ClauseId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/eliminator.rs:228:9 [INFO] [stderr] | [INFO] [stderr] 228 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/eliminator.rs:220:28 [INFO] [stderr] | [INFO] [stderr] 220 | } else { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 221 | | if !self.vars[v].neg_occurs.contains(&cid) { [INFO] [stderr] 222 | | panic!("aaa {} {:#}", cid2fmt(cid), ch); [INFO] [stderr] 223 | | } [INFO] [stderr] 224 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 220 | } else if !self.vars[v].neg_occurs.contains(&cid) { [INFO] [stderr] 221 | panic!("aaa {} {:#}", cid2fmt(cid), ch); [INFO] [stderr] 222 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/eliminator.rs:446:76 [INFO] [stderr] | [INFO] [stderr] 446 | pub fn make_eliminating_unit_clause(&self, vec: &mut Vec, x: Lit) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/eliminator.rs:451:88 [INFO] [stderr] | [INFO] [stderr] 451 | pub fn make_eliminated_clause(&self, vec: &mut Vec, vi: VarId, cid: ClauseId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/eliminator.rs:659:58 [INFO] [stderr] | [INFO] [stderr] 659 | pub fn extend_model(&mut self, model: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/eliminator.rs:704:33 [INFO] [stderr] | [INFO] [stderr] 704 | pub fn eliminate(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/restart.rs:56:81 [INFO] [stderr] | [INFO] [stderr] 56 | fn block_restart(&mut self, lbd: usize, clv: usize, blv: usize, nas: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/restart.rs:80:33 [INFO] [stderr] | [INFO] [stderr] 80 | fn force_restart(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/restart.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return y.powf(seq as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `y.powf(seq as f64)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/solver.rs:206:43 [INFO] [stderr] | [INFO] [stderr] 206 | pub fn progress(&mut self, mes: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/solver.rs:293:16 [INFO] [stderr] | [INFO] [stderr] 293 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 294 | | if mes.is_empty() { [INFO] [stderr] 295 | | println!( [INFO] [stderr] 296 | | " #mode, Variable Assignment ,, \ [INFO] [stderr] ... | [INFO] [stderr] 345 | | } [INFO] [stderr] 346 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 293 | } else if mes.is_empty() { [INFO] [stderr] 294 | println!( [INFO] [stderr] 295 | " #mode, Variable Assignment ,, \ [INFO] [stderr] 296 | Clause Database Management ,, Restart Strategy ,, \ [INFO] [stderr] 297 | Misc Progress Parameters,, Eliminator" [INFO] [stderr] 298 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/solver.rs:361:38 [INFO] [stderr] | [INFO] [stderr] 361 | pub fn adapt_strategy(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/solver.rs:931:43 [INFO] [stderr] | [INFO] [stderr] 931 | fn cancel_until(&mut self, lv: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/solver.rs:1139:65 [INFO] [stderr] | [INFO] [stderr] 1139 | fn analyze_final(&mut self, ci: ClauseId, skip_first: bool) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/solver.rs:1213:64 [INFO] [stderr] | [INFO] [stderr] 1213 | fn minimize_with_bi_clauses(&mut self, vec: &mut Vec) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/solver.rs:1245:62 [INFO] [stderr] | [INFO] [stderr] 1245 | pub fn uncheck_enqueue(&mut self, l: Lit, cid: ClauseId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/solver.rs:1268:46 [INFO] [stderr] | [INFO] [stderr] 1268 | pub fn uncheck_assume(&mut self, l: Lit) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/solver.rs:1288:35 [INFO] [stderr] | [INFO] [stderr] 1288 | pub fn dump(&self, str: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/types.rs:155:34 [INFO] [stderr] | [INFO] [stderr] 155 | fn update(&mut self, x: f64) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/types.rs:161:25 [INFO] [stderr] | [INFO] [stderr] 161 | fn reset(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/types.rs:180:34 [INFO] [stderr] | [INFO] [stderr] 180 | fn update(&mut self, x: f64) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/types.rs:184:25 [INFO] [stderr] | [INFO] [stderr] 184 | fn reset(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/types.rs:202:34 [INFO] [stderr] | [INFO] [stderr] 202 | fn update(&mut self, x: f64) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/types.rs:206:25 [INFO] [stderr] | [INFO] [stderr] 206 | fn reset(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/validator.rs:7:54 [INFO] [stderr] | [INFO] [stderr] 7 | pub fn inject_assigmnent(&mut self, vec: &[i32]) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/var.rs:154:25 [INFO] [stderr] | [INFO] [stderr] 154 | fn reset(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/var.rs:165:49 [INFO] [stderr] | [INFO] [stderr] 165 | fn update(&mut self, vec: &[Var], v: VarId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/var.rs:173:50 [INFO] [stderr] | [INFO] [stderr] 173 | fn insert(&mut self, vec: &[Var], vi: VarId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/var.rs:189:25 [INFO] [stderr] | [INFO] [stderr] 189 | fn clear(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/var.rs:213:60 [INFO] [stderr] | [INFO] [stderr] 213 | fn percolate_up(&mut self, vars: &[Var], start: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/var.rs:251:62 [INFO] [stderr] | [INFO] [stderr] 251 | fn percolate_down(&mut self, vars: &[Var], start: usize) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/var.rs:294:34 [INFO] [stderr] | [INFO] [stderr] 294 | pub fn check(&self, s: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/var.rs:311:54 [INFO] [stderr] | [INFO] [stderr] 311 | pub fn remove(&mut self, vec: &[Var], vs: VarId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/var.rs:332:32 [INFO] [stderr] | [INFO] [stderr] 332 | fn rebuild_heap(&mut self) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/var.rs:341:38 [INFO] [stderr] | [INFO] [stderr] 341 | fn bump_vi(&mut self, vi: VarId) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/clause.rs:351:12 [INFO] [stderr] | [INFO] [stderr] 351 | if true && 1.0e20 < a { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `1.0e20 < a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/clause.rs:610:13 [INFO] [stderr] | [INFO] [stderr] 610 | / buf.write(format!("p cnf {} {}\n", self.num_vars, nc + nv).as_bytes()) [INFO] [stderr] 611 | | .unwrap(); [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/clause.rs:620:25 [INFO] [stderr] | [INFO] [stderr] 620 | buf.write(format!("{} ", l.int()).as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/clause.rs:622:21 [INFO] [stderr] | [INFO] [stderr] 622 | buf.write("0\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/clause.rs:625:13 [INFO] [stderr] | [INFO] [stderr] 625 | buf.write("c from trail\n".as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/clause.rs:627:17 [INFO] [stderr] | [INFO] [stderr] 627 | buf.write(format!("{} 0\n", x.int()).as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eliminator.rs:455:23 [INFO] [stderr] | [INFO] [stderr] 455 | debug_assert!(0 < ch.lits.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!ch.lits.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 34 [INFO] [stderr] --> src/eliminator.rs:473:5 [INFO] [stderr] | [INFO] [stderr] 473 | / pub fn eliminate_var(&mut self, v: VarId) -> bool { [INFO] [stderr] 474 | | if self.vars[v].assign != BOTTOM { [INFO] [stderr] 475 | | return true; [INFO] [stderr] 476 | | } [INFO] [stderr] ... | [INFO] [stderr] 652 | | } [INFO] [stderr] 653 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eliminator.rs:497:16 [INFO] [stderr] | [INFO] [stderr] 497 | if (*pos).len() == 0 && 0 == (*neg).len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*pos).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eliminator.rs:497:37 [INFO] [stderr] | [INFO] [stderr] 497 | if (*pos).len() == 0 && 0 == (*neg).len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*neg).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eliminator.rs:500:16 [INFO] [stderr] | [INFO] [stderr] 500 | if (*pos).len() == 0 && 0 < (*neg).len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*pos).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eliminator.rs:500:37 [INFO] [stderr] | [INFO] [stderr] 500 | if (*pos).len() == 0 && 0 < (*neg).len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!(*neg).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eliminator.rs:508:16 [INFO] [stderr] | [INFO] [stderr] 508 | if (*neg).len() == 0 && (*pos).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*neg).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/eliminator.rs:508:37 [INFO] [stderr] | [INFO] [stderr] 508 | if (*neg).len() == 0 && (*pos).len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `(*pos).is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 28 [INFO] [stderr] --> src/eliminator.rs:794:5 [INFO] [stderr] | [INFO] [stderr] 794 | / pub fn strengthen(&mut self, cid: ClauseId, p: Lit) -> bool { [INFO] [stderr] 795 | | debug_assert!(!clause!(self.cp, cid).get_flag(ClauseFlag::Dead)); [INFO] [stderr] 796 | | debug_assert!(1 < clause!(self.cp, cid).lits.len()); [INFO] [stderr] 797 | | let cix = cid.to_index(); [INFO] [stderr] ... | [INFO] [stderr] 877 | | } [INFO] [stderr] 878 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/solver.rs:465:20 [INFO] [stderr] | [INFO] [stderr] 465 | if v.neg_occurs.len() == 0 && 0 < v.pos_occurs.len() && v.assign == BOTTOM { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.neg_occurs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/solver.rs:465:47 [INFO] [stderr] | [INFO] [stderr] 465 | if v.neg_occurs.len() == 0 && 0 < v.pos_occurs.len() && v.assign == BOTTOM { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.pos_occurs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/solver.rs:471:27 [INFO] [stderr] | [INFO] [stderr] 471 | } else if v.pos_occurs.len() == 0 && 0 < v.neg_occurs.len() && v.assign == BOTTOM { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `v.pos_occurs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/solver.rs:471:54 [INFO] [stderr] | [INFO] [stderr] 471 | } else if v.pos_occurs.len() == 0 && 0 < v.neg_occurs.len() && v.assign == BOTTOM { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!v.neg_occurs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/solver.rs:490:9 [INFO] [stderr] | [INFO] [stderr] 490 | / match self.search() { [INFO] [stderr] 491 | | _ if !self.ok => { [INFO] [stderr] 492 | | self.cancel_until(0); [INFO] [stderr] 493 | | self.progress("error"); [INFO] [stderr] ... | [INFO] [stderr] 520 | | } [INFO] [stderr] 521 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/solver.rs:586:5 [INFO] [stderr] | [INFO] [stderr] 586 | / fn propagate(&mut self) -> ClauseId { [INFO] [stderr] 587 | | let Solver { [INFO] [stderr] 588 | | ref mut vars, [INFO] [stderr] 589 | | ref mut cp, [INFO] [stderr] ... | [INFO] [stderr] 674 | | NULL_CLAUSE [INFO] [stderr] 675 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/solver.rs:678:5 [INFO] [stderr] | [INFO] [stderr] 678 | / fn propagate_0(&mut self) -> ClauseId { [INFO] [stderr] 679 | | let Solver { [INFO] [stderr] 680 | | ref mut vars, [INFO] [stderr] 681 | | ref mut cp, [INFO] [stderr] ... | [INFO] [stderr] 768 | | NULL_CLAUSE [INFO] [stderr] 769 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 27 [INFO] [stderr] --> src/solver.rs:994:5 [INFO] [stderr] | [INFO] [stderr] 994 | / fn analyze(&mut self, confl: ClauseId, learnt: &mut Vec) -> usize { [INFO] [stderr] 995 | | learnt.push(0); [INFO] [stderr] 996 | | let dl = self.decision_level(); [INFO] [stderr] 997 | | let mut cid: usize = confl; [INFO] [stderr] ... | [INFO] [stderr] 1136 | | level_to_return [INFO] [stderr] 1137 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `learnt` [INFO] [stderr] --> src/solver.rs:1124:22 [INFO] [stderr] | [INFO] [stderr] 1124 | for i in 2..learnt.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 1124 | for (i, ) in learnt.iter().enumerate().skip(2) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `splr`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5cc6d9b28d062ab45c9abd9fd72e3e2d9662fbc1dcb470b4cdc3d3b2c745a93e"` [INFO] running `"docker" "rm" "-f" "5cc6d9b28d062ab45c9abd9fd72e3e2d9662fbc1dcb470b4cdc3d3b2c745a93e"` [INFO] [stdout] 5cc6d9b28d062ab45c9abd9fd72e3e2d9662fbc1dcb470b4cdc3d3b2c745a93e