[INFO] updating cached repository shmutalov/growingtree-maze [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shmutalov/growingtree-maze [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shmutalov/growingtree-maze" "work/ex/clippy-test-run/sources/stable/gh/shmutalov/growingtree-maze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shmutalov/growingtree-maze'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shmutalov/growingtree-maze" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shmutalov/growingtree-maze"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shmutalov/growingtree-maze'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 52d79d954b1aaf81899d599e1452d4428547cc0a [INFO] sha for GitHub repo shmutalov/growingtree-maze: 52d79d954b1aaf81899d599e1452d4428547cc0a [INFO] validating manifest of shmutalov/growingtree-maze on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shmutalov/growingtree-maze on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shmutalov/growingtree-maze [INFO] finished frobbing shmutalov/growingtree-maze [INFO] frobbed toml for shmutalov/growingtree-maze written to work/ex/clippy-test-run/sources/stable/gh/shmutalov/growingtree-maze/Cargo.toml [INFO] started frobbing shmutalov/growingtree-maze [INFO] finished frobbing shmutalov/growingtree-maze [INFO] frobbed toml for shmutalov/growingtree-maze written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shmutalov/growingtree-maze/Cargo.toml [INFO] crate shmutalov/growingtree-maze has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shmutalov/growingtree-maze against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shmutalov/growingtree-maze:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f172d88d8a3fc563493700d7ba8954f1015f75506f4b385c7023f29becedb68 [INFO] running `"docker" "start" "-a" "9f172d88d8a3fc563493700d7ba8954f1015f75506f4b385c7023f29becedb68"` [INFO] [stderr] Checking libc v0.2.24 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking growingtree-maze v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/growing_tree_maze.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/growing_tree_maze.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/growing_tree_maze.rs:38:13 [INFO] [stderr] | [INFO] [stderr] 38 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/growing_tree_maze.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/growing_tree_maze.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | return [1, 2, 4, 8].contains(&edgestate) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[1, 2, 4, 8].contains(&edgestate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/growing_tree_maze.rs:162:13 [INFO] [stderr] | [INFO] [stderr] 162 | return [1, 2, 4, 8].contains(&edgestate) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[1, 2, 4, 8].contains(&edgestate)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/growing_tree_maze.rs:177:15 [INFO] [stderr] | [INFO] [stderr] 177 | while frontier.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!frontier.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/growing_tree_maze.rs:177:15 [INFO] [stderr] | [INFO] [stderr] 177 | while frontier.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!frontier.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.17s [INFO] running `"docker" "inspect" "9f172d88d8a3fc563493700d7ba8954f1015f75506f4b385c7023f29becedb68"` [INFO] running `"docker" "rm" "-f" "9f172d88d8a3fc563493700d7ba8954f1015f75506f4b385c7023f29becedb68"` [INFO] [stdout] 9f172d88d8a3fc563493700d7ba8954f1015f75506f4b385c7023f29becedb68