[INFO] updating cached repository shiver/mips-dis [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shiver/mips-dis [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shiver/mips-dis" "work/ex/clippy-test-run/sources/stable/gh/shiver/mips-dis"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shiver/mips-dis'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shiver/mips-dis" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shiver/mips-dis"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shiver/mips-dis'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 1ee14405deafc8ddb96d37d7a93adc919771d3df [INFO] sha for GitHub repo shiver/mips-dis: 1ee14405deafc8ddb96d37d7a93adc919771d3df [INFO] validating manifest of shiver/mips-dis on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shiver/mips-dis on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shiver/mips-dis [INFO] finished frobbing shiver/mips-dis [INFO] frobbed toml for shiver/mips-dis written to work/ex/clippy-test-run/sources/stable/gh/shiver/mips-dis/Cargo.toml [INFO] started frobbing shiver/mips-dis [INFO] finished frobbing shiver/mips-dis [INFO] frobbed toml for shiver/mips-dis written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shiver/mips-dis/Cargo.toml [INFO] crate shiver/mips-dis has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shiver/mips-dis against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shiver/mips-dis:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b201da7c241543a6baca9a0fe8f0eee8a742e6b30408a2dc3daa58be736268f3 [INFO] running `"docker" "start" "-a" "b201da7c241543a6baca9a0fe8f0eee8a742e6b30408a2dc3daa58be736268f3"` [INFO] [stderr] Compiling num-traits v0.2.2 [INFO] [stderr] Compiling num-traits v0.1.43 [INFO] [stderr] Compiling enum-primitive-derive v0.1.2 [INFO] [stderr] Checking mips-dis v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `num_traits::FromPrimitive` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use num_traits::FromPrimitive; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: private type `opcodes::BEQLVars` in public interface (error E0446) [INFO] [stderr] --> src/opcodes.rs:73:10 [INFO] [stderr] | [INFO] [stderr] 73 | BEQL(BEQLVars), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `opcodes::LUIVars` in public interface (error E0446) [INFO] [stderr] --> src/opcodes.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | LUI(LUIVars), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `opcodes::LWVars` in public interface (error E0446) [INFO] [stderr] --> src/opcodes.rs:75:8 [INFO] [stderr] | [INFO] [stderr] 75 | LW(LWVars), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `opcodes::MTC0Vars` in public interface (error E0446) [INFO] [stderr] --> src/opcodes.rs:76:10 [INFO] [stderr] | [INFO] [stderr] 76 | MTC0(MTC0Vars), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `opcodes::ORIVars` in public interface (error E0446) [INFO] [stderr] --> src/opcodes.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | ORI(ORIVars), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/opcodes.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | _ => format!("Nope"), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | for n in 0..num { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `num_traits::FromPrimitive` [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | use num_traits::FromPrimitive; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: private type `opcodes::BEQLVars` in public interface (error E0446) [INFO] [stderr] --> src/opcodes.rs:73:10 [INFO] [stderr] | [INFO] [stderr] 73 | BEQL(BEQLVars), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(private_in_public)] on by default [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `opcodes::LUIVars` in public interface (error E0446) [INFO] [stderr] --> src/opcodes.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | LUI(LUIVars), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `opcodes::LWVars` in public interface (error E0446) [INFO] [stderr] --> src/opcodes.rs:75:8 [INFO] [stderr] | [INFO] [stderr] 75 | LW(LWVars), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `opcodes::MTC0Vars` in public interface (error E0446) [INFO] [stderr] --> src/opcodes.rs:76:10 [INFO] [stderr] | [INFO] [stderr] 76 | MTC0(MTC0Vars), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: private type `opcodes::ORIVars` in public interface (error E0446) [INFO] [stderr] --> src/opcodes.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | ORI(ORIVars), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stderr] = note: for more information, see issue #34537 [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/opcodes.rs:177:9 [INFO] [stderr] | [INFO] [stderr] 177 | _ => format!("Nope"), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/main.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | for n in 0..num { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/opcodes.rs:97:29 [INFO] [stderr] | [INFO] [stderr] 97 | offset: (value.range_u16(0..15) as i32) << 2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(value.range_u16(0..15))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/opcodes.rs:97:29 [INFO] [stderr] | [INFO] [stderr] 97 | offset: (value.range_u16(0..15) as i32) << 2, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(value.range_u16(0..15))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/opcodes.rs:177:14 [INFO] [stderr] | [INFO] [stderr] 177 | _ => format!("Nope"), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nope".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | fn read_bin(filename: &String) -> Result, Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/opcodes.rs:177:14 [INFO] [stderr] | [INFO] [stderr] 177 | _ => format!("Nope"), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Nope".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/main.rs:19:23 [INFO] [stderr] | [INFO] [stderr] 19 | fn read_bin(filename: &String) -> Result, Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.74s [INFO] running `"docker" "inspect" "b201da7c241543a6baca9a0fe8f0eee8a742e6b30408a2dc3daa58be736268f3"` [INFO] running `"docker" "rm" "-f" "b201da7c241543a6baca9a0fe8f0eee8a742e6b30408a2dc3daa58be736268f3"` [INFO] [stdout] b201da7c241543a6baca9a0fe8f0eee8a742e6b30408a2dc3daa58be736268f3