[INFO] updating cached repository shingtaklam1324/rid [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shingtaklam1324/rid [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shingtaklam1324/rid" "work/ex/clippy-test-run/sources/stable/gh/shingtaklam1324/rid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shingtaklam1324/rid'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shingtaklam1324/rid" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shingtaklam1324/rid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shingtaklam1324/rid'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 60dab159c95e16982a7aca276fd7b1fe745ca4e6 [INFO] sha for GitHub repo shingtaklam1324/rid: 60dab159c95e16982a7aca276fd7b1fe745ca4e6 [INFO] validating manifest of shingtaklam1324/rid on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shingtaklam1324/rid on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shingtaklam1324/rid [INFO] finished frobbing shingtaklam1324/rid [INFO] frobbed toml for shingtaklam1324/rid written to work/ex/clippy-test-run/sources/stable/gh/shingtaklam1324/rid/Cargo.toml [INFO] started frobbing shingtaklam1324/rid [INFO] finished frobbing shingtaklam1324/rid [INFO] frobbed toml for shingtaklam1324/rid written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shingtaklam1324/rid/Cargo.toml [INFO] crate shingtaklam1324/rid has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shingtaklam1324/rid against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shingtaklam1324/rid:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0de7ce65ed129a1cfca6a7feb7caa68118441705b56cc874f559385f9101fcf5 [INFO] running `"docker" "start" "-a" "0de7ce65ed129a1cfca6a7feb7caa68118441705b56cc874f559385f9101fcf5"` [INFO] [stderr] Checking clap v2.31.2 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking rayon-core v1.4.0 [INFO] [stderr] Compiling palette v0.3.0 [INFO] [stderr] Checking rayon v1.0.1 [INFO] [stderr] Checking jpeg-decoder v0.1.14 [INFO] [stderr] Checking image v0.19.0 [INFO] [stderr] Checking rid v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:31 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:34 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:40 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 12th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:43 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 13th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:46 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 14th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:49 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 15th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:52 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 16th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:55 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:22 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:25 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:31 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:34 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 11th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:40 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 12th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:43 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 13th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:46 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 14th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:49 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 15th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:52 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 16th binding whose name is just one char [INFO] [stderr] --> src/main.rs:85:55 [INFO] [stderr] | [INFO] [stderr] 85 | [a, b, c, d, e, f, g, h, i, j, k, l, m, n, o, p] => ( [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:64:10 [INFO] [stderr] | [INFO] [stderr] 64 | .unwrap_or(format!("{}.png", username)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}.png", username))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | .unwrap_or((hash.0)[1] as f32 * (360.0 / 256.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from((hash.0)[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | .unwrap_or((hash.0)[6] as f32 * (100.0 / 256.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from((hash.0)[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | o as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | p as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:131:27 [INFO] [stderr] | [INFO] [stderr] 131 | img.put_pixel(x as u32, y as u32, pixel) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:131:37 [INFO] [stderr] | [INFO] [stderr] 131 | img.put_pixel(x as u32, y as u32, pixel) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:64:10 [INFO] [stderr] | [INFO] [stderr] 64 | .unwrap_or(format!("{}.png", username)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| format!("{}.png", username))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:76:20 [INFO] [stderr] | [INFO] [stderr] 76 | .unwrap_or((hash.0)[1] as f32 * (360.0 / 256.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from((hash.0)[1])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:80:20 [INFO] [stderr] | [INFO] [stderr] 80 | .unwrap_or((hash.0)[6] as f32 * (100.0 / 256.0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f32::from((hash.0)[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:88:13 [INFO] [stderr] | [INFO] [stderr] 88 | o as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(o)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:89:13 [INFO] [stderr] | [INFO] [stderr] 89 | p as f32 / 255.0, [INFO] [stderr] | ^^^^^^^^ help: try: `f32::from(p)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:131:27 [INFO] [stderr] | [INFO] [stderr] 131 | img.put_pixel(x as u32, y as u32, pixel) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(x)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:131:37 [INFO] [stderr] | [INFO] [stderr] 131 | img.put_pixel(x as u32, y as u32, pixel) [INFO] [stderr] | ^^^^^^^^ help: try: `u32::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 14.94s [INFO] running `"docker" "inspect" "0de7ce65ed129a1cfca6a7feb7caa68118441705b56cc874f559385f9101fcf5"` [INFO] running `"docker" "rm" "-f" "0de7ce65ed129a1cfca6a7feb7caa68118441705b56cc874f559385f9101fcf5"` [INFO] [stdout] 0de7ce65ed129a1cfca6a7feb7caa68118441705b56cc874f559385f9101fcf5