[INFO] updating cached repository shenki/rust-memboot
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/shenki/rust-memboot
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/shenki/rust-memboot" "work/ex/clippy-test-run/sources/stable/gh/shenki/rust-memboot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shenki/rust-memboot'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/shenki/rust-memboot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shenki/rust-memboot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shenki/rust-memboot'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5a5670e2b1dae424e01a3ff9ba598993e3994da4
[INFO] sha for GitHub repo shenki/rust-memboot: 5a5670e2b1dae424e01a3ff9ba598993e3994da4
[INFO] validating manifest of shenki/rust-memboot on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of shenki/rust-memboot on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing shenki/rust-memboot
[INFO] finished frobbing shenki/rust-memboot
[INFO] frobbed toml for shenki/rust-memboot written to work/ex/clippy-test-run/sources/stable/gh/shenki/rust-memboot/Cargo.toml
[INFO] started frobbing shenki/rust-memboot
[INFO] finished frobbing shenki/rust-memboot
[INFO] frobbed toml for shenki/rust-memboot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shenki/rust-memboot/Cargo.toml
[INFO] crate shenki/rust-memboot has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting shenki/rust-memboot against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shenki/rust-memboot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 124670fb86fc9ffe85e348ba3706bd000878396dfff231df9e158f0a2401c4b6
[INFO] running `"docker" "start" "-a" "124670fb86fc9ffe85e348ba3706bd000878396dfff231df9e158f0a2401c4b6"`
[INFO] [stderr]     Checking nix v0.10.0
[INFO] [stderr]     Checking memboot v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:84:5
[INFO] [stderr]    |
[INFO] [stderr] 84 |     return map.size;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `map.size`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:90:16
[INFO] [stderr]    |
[INFO] [stderr] 90 |     map.addr = 0x0FFFFFFF & !flash_size;
[INFO] [stderr]    |                ^^^^^^^^^^ help: consider: `0x0FFF_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:84:5
[INFO] [stderr]    |
[INFO] [stderr] 84 |     return map.size;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `map.size`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]   --> src/main.rs:90:16
[INFO] [stderr]    |
[INFO] [stderr] 90 |     map.addr = 0x0FFFFFFF & !flash_size;
[INFO] [stderr]    |                ^^^^^^^^^^ help: consider: `0x0FFF_FFFF`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `aspeed_lpc_mapping`
[INFO] [stderr]   --> src/main.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 | /     pub fn new() -> aspeed_lpc_mapping {
[INFO] [stderr] 46 | |         aspeed_lpc_mapping {
[INFO] [stderr] 47 | |             window_type: 0,
[INFO] [stderr] 48 | |             window_id: 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |         }
[INFO] [stderr] 54 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 32 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `ioctl::lpc_ctrl_get_size` doesn't need a mutable reference
[INFO] [stderr]   --> src/main.rs:78:49
[INFO] [stderr]    |
[INFO] [stderr] 78 |     match unsafe { ioctl::lpc_ctrl_get_size(fd, &mut map) } {
[INFO] [stderr]    |                                                 ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `ioctl::lpc_ctrl_map` doesn't need a mutable reference
[INFO] [stderr]   --> src/main.rs:94:33
[INFO] [stderr]    |
[INFO] [stderr] 94 |         ioctl::lpc_ctrl_map(fd, &mut map)
[INFO] [stderr]    |                                 ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `ioctl::lpc_ctrl_map` doesn't need a mutable reference
[INFO] [stderr]    --> src/main.rs:106:33
[INFO] [stderr]     |
[INFO] [stderr] 106 |         ioctl::lpc_ctrl_map(fd, &mut map)
[INFO] [stderr]     |                                 ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     set_mem_mapping(device.as_raw_fd(), 0x10000, 0x1000);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `aspeed_lpc_mapping`
[INFO] [stderr]   --> src/main.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 | /     pub fn new() -> aspeed_lpc_mapping {
[INFO] [stderr] 46 | |         aspeed_lpc_mapping {
[INFO] [stderr] 47 | |             window_type: 0,
[INFO] [stderr] 48 | |             window_id: 0,
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |         }
[INFO] [stderr] 54 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 32 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `ioctl::lpc_ctrl_get_size` doesn't need a mutable reference
[INFO] [stderr]   --> src/main.rs:78:49
[INFO] [stderr]    |
[INFO] [stderr] 78 |     match unsafe { ioctl::lpc_ctrl_get_size(fd, &mut map) } {
[INFO] [stderr]    |                                                 ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::unnecessary_mut_passed)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `ioctl::lpc_ctrl_map` doesn't need a mutable reference
[INFO] [stderr]   --> src/main.rs:94:33
[INFO] [stderr]    |
[INFO] [stderr] 94 |         ioctl::lpc_ctrl_map(fd, &mut map)
[INFO] [stderr]    |                                 ^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: The function/method `ioctl::lpc_ctrl_map` doesn't need a mutable reference
[INFO] [stderr]    --> src/main.rs:106:33
[INFO] [stderr]     |
[INFO] [stderr] 106 |         ioctl::lpc_ctrl_map(fd, &mut map)
[INFO] [stderr]     |                                 ^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stderr] 
[INFO] [stderr] warning: unused `std::result::Result` that must be used
[INFO] [stderr]    --> src/main.rs:123:5
[INFO] [stderr]     |
[INFO] [stderr] 123 |     set_mem_mapping(device.as_raw_fd(), 0x10000, 0x1000);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr]     = note: this `Result` may be an `Err` variant, which should be handled
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.79s
[INFO] running `"docker" "inspect" "124670fb86fc9ffe85e348ba3706bd000878396dfff231df9e158f0a2401c4b6"`
[INFO] running `"docker" "rm" "-f" "124670fb86fc9ffe85e348ba3706bd000878396dfff231df9e158f0a2401c4b6"`
[INFO] [stdout] 124670fb86fc9ffe85e348ba3706bd000878396dfff231df9e158f0a2401c4b6