[INFO] updating cached repository shekohex/fbcsv [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shekohex/fbcsv [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shekohex/fbcsv" "work/ex/clippy-test-run/sources/stable/gh/shekohex/fbcsv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shekohex/fbcsv'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shekohex/fbcsv" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shekohex/fbcsv"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shekohex/fbcsv'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 065e2baea1766095ed241cbb07d1c9134a1e7375 [INFO] sha for GitHub repo shekohex/fbcsv: 065e2baea1766095ed241cbb07d1c9134a1e7375 [INFO] validating manifest of shekohex/fbcsv on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shekohex/fbcsv on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shekohex/fbcsv [INFO] finished frobbing shekohex/fbcsv [INFO] frobbed toml for shekohex/fbcsv written to work/ex/clippy-test-run/sources/stable/gh/shekohex/fbcsv/Cargo.toml [INFO] started frobbing shekohex/fbcsv [INFO] finished frobbing shekohex/fbcsv [INFO] frobbed toml for shekohex/fbcsv written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shekohex/fbcsv/Cargo.toml [INFO] crate shekohex/fbcsv has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shekohex/fbcsv against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shekohex/fbcsv:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e120fd3764b9f7a3d0a5b99e364c8079b543b15f1a90d106f8a5579aea93e6b4 [INFO] running `"docker" "start" "-a" "e120fd3764b9f7a3d0a5b99e364c8079b543b15f1a90d106f8a5579aea93e6b4"` [INFO] [stderr] Compiling serde v1.0.69 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling syn v0.14.4 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking os_type v2.0.0 [INFO] [stderr] Compiling serde_derive v1.0.69 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking csv v1.0.0 [INFO] [stderr] Checking human-panic v1.0.0 [INFO] [stderr] Checking fbcsv v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / let new_line; [INFO] [stderr] 46 | | if cfg!(target_os = "linux") { [INFO] [stderr] 47 | | new_line = "\n"; [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | // windows [INFO] [stderr] 50 | | new_line = "\r\n"; [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let new_line = if cfg!(target_os = "linux") { "\n" } else { "\r\n" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / let new_line; [INFO] [stderr] 46 | | if cfg!(target_os = "linux") { [INFO] [stderr] 47 | | new_line = "\n"; [INFO] [stderr] 48 | | } else { [INFO] [stderr] 49 | | // windows [INFO] [stderr] 50 | | new_line = "\r\n"; [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let new_line = if cfg!(target_os = "linux") { "\n" } else { "\r\n" };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 23.94s [INFO] running `"docker" "inspect" "e120fd3764b9f7a3d0a5b99e364c8079b543b15f1a90d106f8a5579aea93e6b4"` [INFO] running `"docker" "rm" "-f" "e120fd3764b9f7a3d0a5b99e364c8079b543b15f1a90d106f8a5579aea93e6b4"` [INFO] [stdout] e120fd3764b9f7a3d0a5b99e364c8079b543b15f1a90d106f8a5579aea93e6b4