[INFO] updating cached repository shaurya0/advent_of_code_2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shaurya0/advent_of_code_2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shaurya0/advent_of_code_2018" "work/ex/clippy-test-run/sources/stable/gh/shaurya0/advent_of_code_2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shaurya0/advent_of_code_2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shaurya0/advent_of_code_2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shaurya0/advent_of_code_2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shaurya0/advent_of_code_2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f27725d199b1b51d6954cf60745e41ad664980b [INFO] sha for GitHub repo shaurya0/advent_of_code_2018: 7f27725d199b1b51d6954cf60745e41ad664980b [INFO] validating manifest of shaurya0/advent_of_code_2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shaurya0/advent_of_code_2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shaurya0/advent_of_code_2018 [INFO] finished frobbing shaurya0/advent_of_code_2018 [INFO] frobbed toml for shaurya0/advent_of_code_2018 written to work/ex/clippy-test-run/sources/stable/gh/shaurya0/advent_of_code_2018/Cargo.toml [INFO] started frobbing shaurya0/advent_of_code_2018 [INFO] finished frobbing shaurya0/advent_of_code_2018 [INFO] frobbed toml for shaurya0/advent_of_code_2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shaurya0/advent_of_code_2018/Cargo.toml [INFO] crate shaurya0/advent_of_code_2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shaurya0/advent_of_code_2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shaurya0/advent_of_code_2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 210b1930ad780807279fadb92c7e2eeb41cd87dd870114f11ef8be981cd6cd87 [INFO] running `"docker" "start" "-a" "210b1930ad780807279fadb92c7e2eeb41cd87dd870114f11ef8be981cd6cd87"` [INFO] [stderr] Checking advent_of_code v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/day3/day3.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/day3/day3.rs:133:9 [INFO] [stderr] | [INFO] [stderr] 133 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2/day2.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return array; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `array` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Duration`, `NaiveDate` [INFO] [stderr] --> src/day4/day4.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | use chrono::{NaiveDateTime, NaiveDate, NaiveTime, Duration, Timelike}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4/day4.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return log_messages; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `log_messages` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Duration`, `NaiveDate` [INFO] [stderr] --> src/day4/day4.rs:8:29 [INFO] [stderr] | [INFO] [stderr] 8 | use chrono::{NaiveDateTime, NaiveDate, NaiveTime, Duration, Timelike}; [INFO] [stderr] | ^^^^^^^^^ ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day4/day4.rs:63:5 [INFO] [stderr] | [INFO] [stderr] 63 | return log_messages; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `log_messages` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day2/day2.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | fn char_count(line: &String) -> [i32; 26] { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/day2.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | fn part1(lines: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/day2/day2.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | if *val == 2 && two_found == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!two_found` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/day2/day2.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | if *val == 3 && three_found == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!three_found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/day2.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | fn part2(lines: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guard_sleep_time` [INFO] [stderr] --> src/day4/day4.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let mut guard_sleep_time: HashMap [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_guard_sleep_time` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `timestamp` [INFO] [stderr] --> src/day4/day4.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | let timestamp = message.timestamp; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_timestamp` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `guard_sleep_time` [INFO] [stderr] --> src/day4/day4.rs:97:13 [INFO] [stderr] | [INFO] [stderr] 97 | let mut guard_sleep_time: HashMap [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider using `_guard_sleep_time` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `timestamp` [INFO] [stderr] --> src/day4/day4.rs:115:17 [INFO] [stderr] | [INFO] [stderr] 115 | let timestamp = message.timestamp; [INFO] [stderr] | ^^^^^^^^^ help: consider using `_timestamp` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day4/day4.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | let mut guard_sleep_time: HashMap [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `TimestampedMessage` [INFO] [stderr] --> src/day4/day4.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | struct TimestampedMessage { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day4/day4.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | fn parse_log_messages(messages: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/day4/day4.rs:97:9 [INFO] [stderr] | [INFO] [stderr] 97 | let mut guard_sleep_time: HashMap [INFO] [stderr] | ----^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/day3/day3.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | Some(count) => unclaimed = true, [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] warning: struct is never constructed: `TimestampedMessage` [INFO] [stderr] --> src/day4/day4.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | struct TimestampedMessage { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day4/day4.rs:31:33 [INFO] [stderr] | [INFO] [stderr] 31 | fn parse_log_messages(messages: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/day3/day3.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | Some(&count) => print!("#"), [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw_grid` [INFO] [stderr] --> src/day3/day3.rs:120:1 [INFO] [stderr] | [INFO] [stderr] 120 | fn draw_grid(grid_description: &HashMap, nx: u32, ny: u32){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day4/day4.rs:134:32 [INFO] [stderr] | [INFO] [stderr] 134 | let sum = counts.iter().fold(0,|a, &b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day3/day3.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | fn to_claim(claim: &String) -> Claim { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day3/day3.rs:71:66 [INFO] [stderr] | [INFO] [stderr] 71 | fn check_claim(grid_description: &HashMap, claim : &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/day3/day3.rs:89:16 [INFO] [stderr] | [INFO] [stderr] 89 | if unclaimed == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!unclaimed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day3/day3.rs:100:70 [INFO] [stderr] | [INFO] [stderr] 100 | fn update_grid(grid_description: &mut HashMap, claim : &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/day3/day3.rs:169:23 [INFO] [stderr] | [INFO] [stderr] 169 | for (_, count) in &grid_description { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 169 | for count in grid_description.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/day4/day4.rs:134:32 [INFO] [stderr] | [INFO] [stderr] 134 | let sum = counts.iter().fold(0,|a, &b| a + b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/day2/day2.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | return array; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `array` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/day3/day3.rs:86:22 [INFO] [stderr] | [INFO] [stderr] 86 | Some(count) => unclaimed = true, [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `count` [INFO] [stderr] --> src/day3/day3.rs:129:23 [INFO] [stderr] | [INFO] [stderr] 129 | Some(&count) => print!("#"), [INFO] [stderr] | ^^^^^ help: consider using `_count` instead [INFO] [stderr] [INFO] [stderr] warning: function is never used: `draw_grid` [INFO] [stderr] --> src/day3/day3.rs:120:1 [INFO] [stderr] | [INFO] [stderr] 120 | fn draw_grid(grid_description: &HashMap, nx: u32, ny: u32){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day3/day3.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | fn to_claim(claim: &String) -> Claim { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day3/day3.rs:71:66 [INFO] [stderr] | [INFO] [stderr] 71 | fn check_claim(grid_description: &HashMap, claim : &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/day3/day3.rs:89:16 [INFO] [stderr] | [INFO] [stderr] 89 | if unclaimed == false{ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!unclaimed` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day3/day3.rs:100:70 [INFO] [stderr] | [INFO] [stderr] 100 | fn update_grid(grid_description: &mut HashMap, claim : &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to want to iterate on a map's values [INFO] [stderr] --> src/day3/day3.rs:169:23 [INFO] [stderr] | [INFO] [stderr] 169 | for (_, count) in &grid_description { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::for_kv_map)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#for_kv_map [INFO] [stderr] help: use the corresponding method [INFO] [stderr] | [INFO] [stderr] 169 | for count in grid_description.values() { [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/day2/day2.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | fn char_count(line: &String) -> [i32; 26] { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/day2.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | fn part1(lines: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/day2/day2.rs:27:29 [INFO] [stderr] | [INFO] [stderr] 27 | if *val == 2 && two_found == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!two_found` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/day2/day2.rs:31:29 [INFO] [stderr] | [INFO] [stderr] 31 | if *val == 3 && three_found == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!three_found` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/day2/day2.rs:41:17 [INFO] [stderr] | [INFO] [stderr] 41 | fn part2(lines: &Vec) { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.85s [INFO] running `"docker" "inspect" "210b1930ad780807279fadb92c7e2eeb41cd87dd870114f11ef8be981cd6cd87"` [INFO] running `"docker" "rm" "-f" "210b1930ad780807279fadb92c7e2eeb41cd87dd870114f11ef8be981cd6cd87"` [INFO] [stdout] 210b1930ad780807279fadb92c7e2eeb41cd87dd870114f11ef8be981cd6cd87