[INFO] updating cached repository shashkambh/timer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shashkambh/timer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shashkambh/timer" "work/ex/clippy-test-run/sources/stable/gh/shashkambh/timer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shashkambh/timer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shashkambh/timer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shashkambh/timer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shashkambh/timer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e47148e298deb9da2619fe66b8f31500c1af6448 [INFO] sha for GitHub repo shashkambh/timer: e47148e298deb9da2619fe66b8f31500c1af6448 [INFO] validating manifest of shashkambh/timer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shashkambh/timer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shashkambh/timer [INFO] finished frobbing shashkambh/timer [INFO] frobbed toml for shashkambh/timer written to work/ex/clippy-test-run/sources/stable/gh/shashkambh/timer/Cargo.toml [INFO] started frobbing shashkambh/timer [INFO] finished frobbing shashkambh/timer [INFO] frobbed toml for shashkambh/timer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shashkambh/timer/Cargo.toml [INFO] crate shashkambh/timer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shashkambh/timer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shashkambh/timer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0213dc863f9ac7de7bacd8259b81de8b0bd33e171c7514cad1da5805b64c2610 [INFO] running `"docker" "start" "-a" "0213dc863f9ac7de7bacd8259b81de8b0bd33e171c7514cad1da5805b64c2610"` [INFO] [stderr] Checking chrono v0.4.0 [INFO] [stderr] Checking timer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | file.write(line.as_bytes()).expect("Could not write to ~/.timerconfig"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / let mut out: Option = None; [INFO] [stderr] 122 | | [INFO] [stderr] 123 | | if curr_timer_fields.next().expect("No current timer") == "Current:" { [INFO] [stderr] 124 | | let name: String = curr_timer_fields.next().expect("Invalid ~/.timerconfig").into(); [INFO] [stderr] ... | [INFO] [stderr] 128 | | out = Some(Timer{name, start: datetime}); [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let out = if curr_timer_fields.next().expect("No current timer") == "Current:" { ..; Some(Timer{name, start: datetime}) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:119:61 [INFO] [stderr] | [INFO] [stderr] 119 | let mut curr_timer_fields = curr_timer_string.splitn(3, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `timer`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | env::home_dir() [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | file.write(line.as_bytes()).expect("Could not write to ~/.timerconfig"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/main.rs:121:5 [INFO] [stderr] | [INFO] [stderr] 121 | / let mut out: Option = None; [INFO] [stderr] 122 | | [INFO] [stderr] 123 | | if curr_timer_fields.next().expect("No current timer") == "Current:" { [INFO] [stderr] 124 | | let name: String = curr_timer_fields.next().expect("Invalid ~/.timerconfig").into(); [INFO] [stderr] ... | [INFO] [stderr] 128 | | out = Some(Timer{name, start: datetime}); [INFO] [stderr] 129 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let out = if curr_timer_fields.next().expect("No current timer") == "Current:" { ..; Some(Timer{name, start: datetime}) } else { None };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:119:61 [INFO] [stderr] | [INFO] [stderr] 119 | let mut curr_timer_fields = curr_timer_string.splitn(3, " "); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `timer`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0213dc863f9ac7de7bacd8259b81de8b0bd33e171c7514cad1da5805b64c2610"` [INFO] running `"docker" "rm" "-f" "0213dc863f9ac7de7bacd8259b81de8b0bd33e171c7514cad1da5805b64c2610"` [INFO] [stdout] 0213dc863f9ac7de7bacd8259b81de8b0bd33e171c7514cad1da5805b64c2610