[INFO] updating cached repository sharkdp/vacuum-robot-simulator
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sharkdp/vacuum-robot-simulator
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sharkdp/vacuum-robot-simulator" "work/ex/clippy-test-run/sources/stable/gh/sharkdp/vacuum-robot-simulator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sharkdp/vacuum-robot-simulator'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sharkdp/vacuum-robot-simulator" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sharkdp/vacuum-robot-simulator"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sharkdp/vacuum-robot-simulator'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 60fbdc830e6b21376258a19091eabbca888776a4
[INFO] sha for GitHub repo sharkdp/vacuum-robot-simulator: 60fbdc830e6b21376258a19091eabbca888776a4
[INFO] validating manifest of sharkdp/vacuum-robot-simulator on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sharkdp/vacuum-robot-simulator on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sharkdp/vacuum-robot-simulator
[INFO] finished frobbing sharkdp/vacuum-robot-simulator
[INFO] frobbed toml for sharkdp/vacuum-robot-simulator written to work/ex/clippy-test-run/sources/stable/gh/sharkdp/vacuum-robot-simulator/Cargo.toml
[INFO] started frobbing sharkdp/vacuum-robot-simulator
[INFO] finished frobbing sharkdp/vacuum-robot-simulator
[INFO] frobbed toml for sharkdp/vacuum-robot-simulator written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sharkdp/vacuum-robot-simulator/Cargo.toml
[INFO] crate sharkdp/vacuum-robot-simulator has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sharkdp/vacuum-robot-simulator against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sharkdp/vacuum-robot-simulator:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 02dd109c9ec519c94ae408f36660fba6e5d579000962b69caa0638a41cbadc6a
[INFO] running `"docker" "start" "-a" "02dd109c9ec519c94ae408f36660fba6e5d579000962b69caa0638a41cbadc6a"`
[INFO] [stderr]    Compiling either v1.1.0
[INFO] [stderr]    Compiling heapsize v0.4.1
[INFO] [stderr]     Checking serde v0.9.15
[INFO] [stderr]     Checking num_cpus v1.6.2
[INFO] [stderr]     Checking memmap v0.6.2
[INFO] [stderr]    Compiling x11-dl v2.18.3
[INFO] [stderr]     Checking shared_library v0.1.7
[INFO] [stderr]     Checking deflate v0.7.17
[INFO] [stderr]     Checking piston-viewport v0.5.0
[INFO] [stderr]    Compiling wayland-scanner v0.12.5
[INFO] [stderr]     Checking rand v0.5.5
[INFO] [stderr]     Checking ordered-float v0.5.2
[INFO] [stderr]    Compiling itertools v0.5.10
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]     Checking rayon-core v1.2.1
[INFO] [stderr]     Checking arrayvec v0.4.2
[INFO] [stderr]     Checking png v0.12.0
[INFO] [stderr]     Checking svgparser v0.4.3
[INFO] [stderr]    Compiling syn v0.15.17
[INFO] [stderr]    Compiling gfx_gl v0.5.0
[INFO] [stderr]    Compiling glutin v0.14.0
[INFO] [stderr]     Checking sdl2 v0.31.0
[INFO] [stderr]     Checking rayon v0.8.2
[INFO] [stderr]     Checking wayland-sys v0.12.5
[INFO] [stderr]     Checking pistoncore-input v0.21.0
[INFO] [stderr]     Checking pistoncore-input v0.23.0
[INFO] [stderr]     Checking rusttype v0.4.3
[INFO] [stderr]    Compiling wayland-client v0.12.5
[INFO] [stderr]    Compiling wayland-protocols v0.12.5
[INFO] [stderr]    Compiling derivative v1.0.0
[INFO] [stderr]     Checking tempfile v3.0.4
[INFO] [stderr]     Checking piston2d-graphics v0.26.0
[INFO] [stderr]     Checking pistoncore-window v0.32.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]    Compiling num-derive v0.2.3
[INFO] [stderr]     Checking euclid v0.13.0
[INFO] [stderr]     Checking pistoncore-window v0.34.0
[INFO] [stderr]     Checking pistoncore-event_loop v0.37.0
[INFO] [stderr]     Checking pistoncore-sdl2_window v0.50.0
[INFO] [stderr]     Checking pistoncore-event_loop v0.39.0
[INFO] [stderr]     Checking piston v0.37.0
[INFO] [stderr]     Checking lyon_bezier v0.5.0
[INFO] [stderr]     Checking piston v0.39.0
[INFO] [stderr]     Checking svg2polylines v0.4.0
[INFO] [stderr]     Checking wayland-kbd v0.13.1
[INFO] [stderr]     Checking gfx_core v0.8.3
[INFO] [stderr]     Checking image v0.19.0
[INFO] [stderr]     Checking wayland-window v0.13.3
[INFO] [stderr]     Checking winit v0.12.0
[INFO] [stderr]     Checking piston2d-opengl_graphics v0.53.0
[INFO] [stderr]     Checking pistoncore-glutin_window v0.47.0
[INFO] [stderr]     Checking gfx v0.17.1
[INFO] [stderr]     Checking gfx_device_gl v0.15.3
[INFO] [stderr]     Checking piston-gfx_texture v0.32.0
[INFO] [stderr]     Checking piston2d-gfx_graphics v0.51.0
[INFO] [stderr]     Checking piston_window v0.80.0
[INFO] [stderr]     Checking vacuum-robot-simulator v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/geometry/line.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let d = r.cross(s);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/geometry/line.rs:28:17
[INFO] [stderr]    |
[INFO] [stderr] 28 |             let u = (q - p).cross(r) / d;
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/geometry/line.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |             let t = (q - p).cross(s) / d;
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]   --> src/geometry/line.rs:23:13
[INFO] [stderr]    |
[INFO] [stderr] 23 |         let d = r.cross(s);
[INFO] [stderr]    |             ^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]   --> src/geometry/line.rs:28:17
[INFO] [stderr]    |
[INFO] [stderr] 28 |             let u = (q - p).cross(r) / d;
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 7th binding whose name is just one char
[INFO] [stderr]   --> src/geometry/line.rs:31:17
[INFO] [stderr]    |
[INFO] [stderr] 31 |             let t = (q - p).cross(s) / d;
[INFO] [stderr]    |                 ^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/controller/gridmap.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 | /             match GridMap::indices_from_pos(p) {
[INFO] [stderr] 45 | |                 Some((r, c)) => {
[INFO] [stderr] 46 | |                     let cell: &mut CellState = &mut self.cells[r][c];
[INFO] [stderr] 47 | |                     *cell = match *cell {
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |                 _ => {}
[INFO] [stderr] 54 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 44 |             if let Some((r, c)) = GridMap::indices_from_pos(p) {
[INFO] [stderr] 45 |     let cell: &mut CellState = &mut self.cells[r][c];
[INFO] [stderr] 46 |     *cell = match *cell {
[INFO] [stderr] 47 |         Occupied(count) => Occupied(count + 1),
[INFO] [stderr] 48 |         Freespace => Occupied(1),
[INFO] [stderr] 49 |         Void => Occupied(1),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/controller/gridmap.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 | /                 match GridMap::indices_from_pos(p) {
[INFO] [stderr] 65 | |                     Some((r, c)) => {
[INFO] [stderr] 66 | |                         let cell: &mut CellState = &mut self.cells[r][c];
[INFO] [stderr] 67 | |                         *cell = match *cell {
[INFO] [stderr] ...  |
[INFO] [stderr] 72 | |                     _ => {}
[INFO] [stderr] 73 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 if let Some((r, c)) = GridMap::indices_from_pos(p) {
[INFO] [stderr] 65 |     let cell: &mut CellState = &mut self.cells[r][c];
[INFO] [stderr] 66 |     *cell = match *cell {
[INFO] [stderr] 67 |         Void => Freespace,
[INFO] [stderr] 68 |         o => o,
[INFO] [stderr] 69 |     };
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/controller/gridmap.rs:44:13
[INFO] [stderr]    |
[INFO] [stderr] 44 | /             match GridMap::indices_from_pos(p) {
[INFO] [stderr] 45 | |                 Some((r, c)) => {
[INFO] [stderr] 46 | |                     let cell: &mut CellState = &mut self.cells[r][c];
[INFO] [stderr] 47 | |                     *cell = match *cell {
[INFO] [stderr] ...  |
[INFO] [stderr] 53 | |                 _ => {}
[INFO] [stderr] 54 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 44 |             if let Some((r, c)) = GridMap::indices_from_pos(p) {
[INFO] [stderr] 45 |     let cell: &mut CellState = &mut self.cells[r][c];
[INFO] [stderr] 46 |     *cell = match *cell {
[INFO] [stderr] 47 |         Occupied(count) => Occupied(count + 1),
[INFO] [stderr] 48 |         Freespace => Occupied(1),
[INFO] [stderr] 49 |         Void => Occupied(1),
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/controller/gridmap.rs:64:17
[INFO] [stderr]    |
[INFO] [stderr] 64 | /                 match GridMap::indices_from_pos(p) {
[INFO] [stderr] 65 | |                     Some((r, c)) => {
[INFO] [stderr] 66 | |                         let cell: &mut CellState = &mut self.cells[r][c];
[INFO] [stderr] 67 | |                         *cell = match *cell {
[INFO] [stderr] ...  |
[INFO] [stderr] 72 | |                     _ => {}
[INFO] [stderr] 73 | |                 }
[INFO] [stderr]    | |_________________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 64 |                 if let Some((r, c)) = GridMap::indices_from_pos(p) {
[INFO] [stderr] 65 |     let cell: &mut CellState = &mut self.cells[r][c];
[INFO] [stderr] 66 |     *cell = match *cell {
[INFO] [stderr] 67 |         Void => Freespace,
[INFO] [stderr] 68 |         o => o,
[INFO] [stderr] 69 |     };
[INFO] [stderr]  ...
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:77:29
[INFO] [stderr]    |
[INFO] [stderr] 77 |     fn update(&mut self, _: &UpdateArgs) {
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/main.rs:77:29
[INFO] [stderr]    |
[INFO] [stderr] 77 |     fn update(&mut self, _: &UpdateArgs) {
[INFO] [stderr]    |                             ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 36s
[INFO] running `"docker" "inspect" "02dd109c9ec519c94ae408f36660fba6e5d579000962b69caa0638a41cbadc6a"`
[INFO] running `"docker" "rm" "-f" "02dd109c9ec519c94ae408f36660fba6e5d579000962b69caa0638a41cbadc6a"`
[INFO] [stdout] 02dd109c9ec519c94ae408f36660fba6e5d579000962b69caa0638a41cbadc6a