[INFO] updating cached repository sharkdp/lucid [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sharkdp/lucid [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sharkdp/lucid" "work/ex/clippy-test-run/sources/stable/gh/sharkdp/lucid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sharkdp/lucid'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sharkdp/lucid" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sharkdp/lucid"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sharkdp/lucid'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d7003908e082b4a6e7c13676414469af3a1cac88 [INFO] sha for GitHub repo sharkdp/lucid: d7003908e082b4a6e7c13676414469af3a1cac88 [INFO] validating manifest of sharkdp/lucid on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sharkdp/lucid on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sharkdp/lucid [INFO] finished frobbing sharkdp/lucid [INFO] frobbed toml for sharkdp/lucid written to work/ex/clippy-test-run/sources/stable/gh/sharkdp/lucid/Cargo.toml [INFO] started frobbing sharkdp/lucid [INFO] finished frobbing sharkdp/lucid [INFO] frobbed toml for sharkdp/lucid written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sharkdp/lucid/Cargo.toml [INFO] crate sharkdp/lucid has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sharkdp/lucid against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sharkdp/lucid:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] fadd14ebb04bfa13ca4d0ed1a65cf6bf775781100ad2c3edd07d42c35c972299 [INFO] running `"docker" "start" "-a" "fadd14ebb04bfa13ca4d0ed1a65cf6bf775781100ad2c3edd07d42c35c972299"` [INFO] [stderr] Compiling nix v0.12.0 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking nix v0.11.0 [INFO] [stderr] Checking textwrap v0.10.0 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking ctrlc v3.1.1 [INFO] [stderr] Checking lucid v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match self.verbosity_level { [INFO] [stderr] 76 | | VerbosityLevel::Verbose => self.print_with_prefix(msg), [INFO] [stderr] 77 | | _ => {} [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ help: try this: `if let VerbosityLevel::Verbose = self.verbosity_level { self.print_with_prefix(msg) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:226:14 [INFO] [stderr] | [INFO] [stderr] 226 | .unwrap_or("".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:232:27 [INFO] [stderr] | [INFO] [stderr] 232 | output.print(&format!("Going to sleep forever")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Going to sleep forever".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match self.verbosity_level { [INFO] [stderr] 76 | | VerbosityLevel::Verbose => self.print_with_prefix(msg), [INFO] [stderr] 77 | | _ => {} [INFO] [stderr] 78 | | } [INFO] [stderr] | |_________^ help: try this: `if let VerbosityLevel::Verbose = self.verbosity_level { self.print_with_prefix(msg) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:226:14 [INFO] [stderr] | [INFO] [stderr] 226 | .unwrap_or("".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:232:27 [INFO] [stderr] | [INFO] [stderr] 232 | output.print(&format!("Going to sleep forever")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Going to sleep forever".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.96s [INFO] running `"docker" "inspect" "fadd14ebb04bfa13ca4d0ed1a65cf6bf775781100ad2c3edd07d42c35c972299"` [INFO] running `"docker" "rm" "-f" "fadd14ebb04bfa13ca4d0ed1a65cf6bf775781100ad2c3edd07d42c35c972299"` [INFO] [stdout] fadd14ebb04bfa13ca4d0ed1a65cf6bf775781100ad2c3edd07d42c35c972299