[INFO] updating cached repository shakyShane/rs-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shakyShane/rs-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shakyShane/rs-playground" "work/ex/clippy-test-run/sources/stable/gh/shakyShane/rs-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shakyShane/rs-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shakyShane/rs-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shakyShane/rs-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shakyShane/rs-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 616c25b008485e7b5e315f1b989ec26278ea6331 [INFO] sha for GitHub repo shakyShane/rs-playground: 616c25b008485e7b5e315f1b989ec26278ea6331 [INFO] validating manifest of shakyShane/rs-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shakyShane/rs-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shakyShane/rs-playground [INFO] finished frobbing shakyShane/rs-playground [INFO] frobbed toml for shakyShane/rs-playground written to work/ex/clippy-test-run/sources/stable/gh/shakyShane/rs-playground/Cargo.toml [INFO] started frobbing shakyShane/rs-playground [INFO] finished frobbing shakyShane/rs-playground [INFO] frobbed toml for shakyShane/rs-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shakyShane/rs-playground/Cargo.toml [INFO] crate shakyShane/rs-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shakyShane/rs-playground against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shakyShane/rs-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] abe002b6db81b76b9a5e8b3dcd7088c8c07c6e576db3f5dc952c9960a69e09ce [INFO] running `"docker" "start" "-a" "abe002b6db81b76b9a5e8b3dcd7088c8c07c6e576db3f5dc952c9960a69e09ce"` [INFO] [stderr] Checking memchr v2.0.2 [INFO] [stderr] Checking serde_json v1.0.27 [INFO] [stderr] Checking serde_yaml v0.8.4 [INFO] [stderr] Compiling serde_derive v1.0.79 [INFO] [stderr] Compiling from_file_derive v0.1.3 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking from_file v0.1.3 [INFO] [stderr] Checking rs-playground v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fold.rs:20:56 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn collect<'a>(items: &'a mut Vec, children: &Vec) -> &'a mut Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/hash_map.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | match t.as_ref() { [INFO] [stderr] | ^^^^^^^^^^ help: try this: `t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/hash_map.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | assert_eq!(m.get(&index).unwrap().greet(), "hi shane"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&m[&index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/collect_collections.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | if w.contains("a") { [INFO] [stderr] | ^^^ help: try using a char instead: `'a'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/collect_collections.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | if w.contains("a") { [INFO] [stderr] | ^^^ help: try using a char instead: `'a'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/fold.rs:20:56 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn collect<'a>(items: &'a mut Vec, children: &Vec) -> &'a mut Vec { [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[Item]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this call to `as_ref` does nothing [INFO] [stderr] --> src/hash_map.rs:26:15 [INFO] [stderr] | [INFO] [stderr] 26 | match t.as_ref() { [INFO] [stderr] | ^^^^^^^^^^ help: try this: `t` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_asref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/hash_map.rs:41:20 [INFO] [stderr] | [INFO] [stderr] 41 | assert_eq!(m.get(&index).unwrap().greet(), "hi shane"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&m[&index]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/collect_collections.rs:7:23 [INFO] [stderr] | [INFO] [stderr] 7 | if w.contains("a") { [INFO] [stderr] | ^^^ help: try using a char instead: `'a'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/collect_collections.rs:17:19 [INFO] [stderr] | [INFO] [stderr] 17 | if w.contains("a") { [INFO] [stderr] | ^^^ help: try using a char instead: `'a'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 17.67s [INFO] running `"docker" "inspect" "abe002b6db81b76b9a5e8b3dcd7088c8c07c6e576db3f5dc952c9960a69e09ce"` [INFO] running `"docker" "rm" "-f" "abe002b6db81b76b9a5e8b3dcd7088c8c07c6e576db3f5dc952c9960a69e09ce"` [INFO] [stdout] abe002b6db81b76b9a5e8b3dcd7088c8c07c6e576db3f5dc952c9960a69e09ce