[INFO] updating cached repository shadowmint/rust-base-task [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/shadowmint/rust-base-task [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/shadowmint/rust-base-task" "work/ex/clippy-test-run/sources/stable/gh/shadowmint/rust-base-task"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/shadowmint/rust-base-task'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/shadowmint/rust-base-task" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shadowmint/rust-base-task"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shadowmint/rust-base-task'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6a776ec0900c60834d72f6bf72caeb5fe8b11d25 [INFO] sha for GitHub repo shadowmint/rust-base-task: 6a776ec0900c60834d72f6bf72caeb5fe8b11d25 [INFO] validating manifest of shadowmint/rust-base-task on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of shadowmint/rust-base-task on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing shadowmint/rust-base-task [INFO] finished frobbing shadowmint/rust-base-task [INFO] frobbed toml for shadowmint/rust-base-task written to work/ex/clippy-test-run/sources/stable/gh/shadowmint/rust-base-task/Cargo.toml [INFO] started frobbing shadowmint/rust-base-task [INFO] finished frobbing shadowmint/rust-base-task [INFO] frobbed toml for shadowmint/rust-base-task written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/shadowmint/rust-base-task/Cargo.toml [INFO] crate shadowmint/rust-base-task has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting shadowmint/rust-base-task against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/shadowmint/rust-base-task:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aeb670207ec1fcf5724baaf354d457ba1013b65f47d1467bbc07b6561edbe91f [INFO] running `"docker" "start" "-a" "aeb670207ec1fcf5724baaf354d457ba1013b65f47d1467bbc07b6561edbe91f"` [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.32 [INFO] [stderr] Checking tokio-executor v0.1.0 [INFO] [stderr] Checking base-task v1.0.0 (/opt/crater/workdir) [INFO] [stderr] Checking crossbeam-epoch v0.4.0 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task_error.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return &self.message; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task_error.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / return TaskError { [INFO] [stderr] 40 | | code, [INFO] [stderr] 41 | | message: TaskError::message_for(code, None), [INFO] [stderr] 42 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | TaskError { [INFO] [stderr] 40 | code, [INFO] [stderr] 41 | message: TaskError::message_for(code, None), [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task_error.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / return TaskError { [INFO] [stderr] 49 | | code: TaskErrorCode::Unknown, [INFO] [stderr] 50 | | message: TaskError::message_for(TaskErrorCode::Unknown, Some(message)), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | TaskError { [INFO] [stderr] 49 | code: TaskErrorCode::Unknown, [INFO] [stderr] 50 | message: TaskError::message_for(TaskErrorCode::Unknown, Some(message)), [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return (task, rx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(task, rx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | return action(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `action()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | / match sx.send(result) { [INFO] [stderr] 23 | | Ok(_) => {} [INFO] [stderr] 24 | | Err(_) => {} [INFO] [stderr] 25 | | }; [INFO] [stderr] | |_________________________^ help: try this: `if let Ok(_) = sx.send(result) {}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | / match sx.send(Err(TaskError::from(TaskErrorCode::Panic))) { [INFO] [stderr] 29 | | Ok(_) => {} [INFO] [stderr] 30 | | Err(_) => {} [INFO] [stderr] 31 | | }; [INFO] [stderr] | |_________________________^ help: try this: `if let Ok(_) = sx.send(Err(TaskError::from(TaskErrorCode::Panic))) {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Checking crossbeam-deque v0.3.0 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking tokio-threadpool v0.1.0 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking tokio-reactor v0.1.0 [INFO] [stderr] Checking tokio v0.1.3 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task_error.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return &self.message; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&self.message` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task_error.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | / return TaskError { [INFO] [stderr] 40 | | code, [INFO] [stderr] 41 | | message: TaskError::message_for(code, None), [INFO] [stderr] 42 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 39 | TaskError { [INFO] [stderr] 40 | code, [INFO] [stderr] 41 | message: TaskError::message_for(code, None), [INFO] [stderr] 42 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task_error.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | / return TaskError { [INFO] [stderr] 49 | | code: TaskErrorCode::Unknown, [INFO] [stderr] 50 | | message: TaskError::message_for(TaskErrorCode::Unknown, Some(message)), [INFO] [stderr] 51 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 48 | TaskError { [INFO] [stderr] 49 | code: TaskErrorCode::Unknown, [INFO] [stderr] 50 | message: TaskError::message_for(TaskErrorCode::Unknown, Some(message)), [INFO] [stderr] 51 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | return (task, rx); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(task, rx)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | return action(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `action()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | return Ok(100); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | return Ok(100); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/task.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | return Err(TaskError::from("Aborted")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(TaskError::from("Aborted"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:25:13 [INFO] [stderr] | [INFO] [stderr] 25 | return Ok(1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(1000)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | return Ok(true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(true)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | return Ok(false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(false)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:108:13 [INFO] [stderr] | [INFO] [stderr] 108 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task.rs:22:25 [INFO] [stderr] | [INFO] [stderr] 22 | / match sx.send(result) { [INFO] [stderr] 23 | | Ok(_) => {} [INFO] [stderr] 24 | | Err(_) => {} [INFO] [stderr] 25 | | }; [INFO] [stderr] | |_________________________^ help: try this: `if let Ok(_) = sx.send(result) {}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/task.rs:28:25 [INFO] [stderr] | [INFO] [stderr] 28 | / match sx.send(Err(TaskError::from(TaskErrorCode::Panic))) { [INFO] [stderr] 29 | | Ok(_) => {} [INFO] [stderr] 30 | | Err(_) => {} [INFO] [stderr] 31 | | }; [INFO] [stderr] | |_________________________^ help: try this: `if let Ok(_) = sx.send(Err(TaskError::from(TaskErrorCode::Panic))) {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/task.rs:56:14 [INFO] [stderr] | [INFO] [stderr] 56 | let (foo, mut foo_recv) = Task::new(|| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/task.rs:72:14 [INFO] [stderr] | [INFO] [stderr] 72 | let (foo, mut foo_recv) = Task::new(|| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/task.rs:95:14 [INFO] [stderr] | [INFO] [stderr] 95 | let (foo, mut foo_recv) = Task::new(|| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `foo` [INFO] [stderr] --> src/task.rs:114:14 [INFO] [stderr] | [INFO] [stderr] 114 | let (foo, mut foo_recv) = Task::new(|| { [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:60:13 [INFO] [stderr] | [INFO] [stderr] 60 | / loop { [INFO] [stderr] 61 | | match rx.recv() { [INFO] [stderr] 62 | | Ok(task) => { [INFO] [stderr] 63 | | task.call_once(); [INFO] [stderr] ... | [INFO] [stderr] 68 | | } [INFO] [stderr] 69 | | } [INFO] [stderr] | |_____________^ help: try: `while let Ok(task) = rx.recv() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 9.87s [INFO] running `"docker" "inspect" "aeb670207ec1fcf5724baaf354d457ba1013b65f47d1467bbc07b6561edbe91f"` [INFO] running `"docker" "rm" "-f" "aeb670207ec1fcf5724baaf354d457ba1013b65f47d1467bbc07b6561edbe91f"` [INFO] [stdout] aeb670207ec1fcf5724baaf354d457ba1013b65f47d1467bbc07b6561edbe91f