[INFO] updating cached repository sgpthomas/timetable [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sgpthomas/timetable [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sgpthomas/timetable" "work/ex/clippy-test-run/sources/stable/gh/sgpthomas/timetable"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sgpthomas/timetable'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sgpthomas/timetable" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgpthomas/timetable"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgpthomas/timetable'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0bf04e2f160722254c97390106686f71aa077789 [INFO] sha for GitHub repo sgpthomas/timetable: 0bf04e2f160722254c97390106686f71aa077789 [INFO] validating manifest of sgpthomas/timetable on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sgpthomas/timetable on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sgpthomas/timetable [INFO] finished frobbing sgpthomas/timetable [INFO] frobbed toml for sgpthomas/timetable written to work/ex/clippy-test-run/sources/stable/gh/sgpthomas/timetable/Cargo.toml [INFO] started frobbing sgpthomas/timetable [INFO] finished frobbing sgpthomas/timetable [INFO] frobbed toml for sgpthomas/timetable written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgpthomas/timetable/Cargo.toml [INFO] crate sgpthomas/timetable has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sgpthomas/timetable against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sgpthomas/timetable:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f75ca3c4f436406987c68f08afb3161614d892aa2380c9534c7574fcc229345d [INFO] running `"docker" "start" "-a" "f75ca3c4f436406987c68f08afb3161614d892aa2380c9534c7574fcc229345d"` [INFO] [stderr] Compiling libc v0.2.32 [INFO] [stderr] Checking serde v1.0.16 [INFO] [stderr] Checking bitflags v1.0.0 [INFO] [stderr] Checking shared_library v0.1.7 [INFO] [stderr] Checking nodrop v0.1.11 [INFO] [stderr] Checking tempfile v2.2.0 [INFO] [stderr] Checking rayon-core v1.2.1 [INFO] [stderr] Compiling gl v0.6.3 [INFO] [stderr] Checking x11-dl v2.16.0 [INFO] [stderr] Checking arrayvec v0.4.4 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.16 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Compiling rand v0.3.17 [INFO] [stderr] Checking rusttype v0.2.3 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking piston2d-graphics v0.23.0 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking image v0.17.0 [INFO] [stderr] Checking pistoncore-input v0.20.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.49.0 [INFO] [stderr] Checking pistoncore-window v0.30.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking pistoncore-event_loop v0.35.0 [INFO] [stderr] Checking piston v0.35.0 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking glutin v0.10.0 [INFO] [stderr] Checking pistoncore-glutin_window v0.42.0 [INFO] [stderr] Checking timetable v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | canvas: canvas, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `canvas` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | rate: rate, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | npoints: npoints, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `npoints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | canvas: canvas, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `canvas` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | rate: rate, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | npoints: npoints, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `npoints` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | let i = i as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:52:38 [INFO] [stderr] | [INFO] [stderr] 52 | ret.push((a, (f64::round((a as f64) * (self.factor)) as u32) % self.npoints)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:26 [INFO] [stderr] | [INFO] [stderr] 60 | let inc = 6.28 / (self.npoints as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.npoints)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:90:32 [INFO] [stderr] | [INFO] [stderr] 90 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:24 [INFO] [stderr] | [INFO] [stderr] 92 | self.factor %= self.npoints as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.npoints)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:42:21 [INFO] [stderr] | [INFO] [stderr] 42 | let i = i as f64; [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:52:38 [INFO] [stderr] | [INFO] [stderr] 52 | ret.push((a, (f64::round((a as f64) * (self.factor)) as u32) % self.npoints)); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(a)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:60:26 [INFO] [stderr] | [INFO] [stderr] 60 | let inc = 6.28 / (self.npoints as f64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.npoints)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:90:32 [INFO] [stderr] | [INFO] [stderr] 90 | fn update(&mut self, args: &UpdateArgs) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `UpdateArgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:92:24 [INFO] [stderr] | [INFO] [stderr] 92 | self.factor %= self.npoints as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(self.npoints)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 48.99s [INFO] running `"docker" "inspect" "f75ca3c4f436406987c68f08afb3161614d892aa2380c9534c7574fcc229345d"` [INFO] running `"docker" "rm" "-f" "f75ca3c4f436406987c68f08afb3161614d892aa2380c9534c7574fcc229345d"` [INFO] [stdout] f75ca3c4f436406987c68f08afb3161614d892aa2380c9534c7574fcc229345d