[INFO] updating cached repository sgpthomas/mandelbrot
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sgpthomas/mandelbrot
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sgpthomas/mandelbrot" "work/ex/clippy-test-run/sources/stable/gh/sgpthomas/mandelbrot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sgpthomas/mandelbrot'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sgpthomas/mandelbrot" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgpthomas/mandelbrot"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgpthomas/mandelbrot'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] a8a2fbf60fb0df02a1ce61f79333594925711172
[INFO] sha for GitHub repo sgpthomas/mandelbrot: a8a2fbf60fb0df02a1ce61f79333594925711172
[INFO] validating manifest of sgpthomas/mandelbrot on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sgpthomas/mandelbrot on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sgpthomas/mandelbrot
[INFO] finished frobbing sgpthomas/mandelbrot
[INFO] frobbed toml for sgpthomas/mandelbrot written to work/ex/clippy-test-run/sources/stable/gh/sgpthomas/mandelbrot/Cargo.toml
[INFO] started frobbing sgpthomas/mandelbrot
[INFO] finished frobbing sgpthomas/mandelbrot
[INFO] frobbed toml for sgpthomas/mandelbrot written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgpthomas/mandelbrot/Cargo.toml
[INFO] crate sgpthomas/mandelbrot has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sgpthomas/mandelbrot against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sgpthomas/mandelbrot:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 374f174bfe0960ece3731361a543b82da5e4e34a19878dd4a0f2c783f17f9d88
[INFO] running `"docker" "start" "-a" "374f174bfe0960ece3731361a543b82da5e4e34a19878dd4a0f2c783f17f9d88"`
[INFO] [stderr]     Checking time v0.1.38
[INFO] [stderr]    Compiling freetype-sys v0.4.0
[INFO] [stderr]     Checking threadpool v1.7.1
[INFO] [stderr]     Checking rayon-core v1.2.1
[INFO] [stderr]    Compiling glium v0.16.0
[INFO] [stderr]    Compiling glium v0.18.0
[INFO] [stderr]     Checking backtrace-sys v0.1.16
[INFO] [stderr]     Checking libz-sys v1.0.18
[INFO] [stderr]     Checking backtrace v0.2.3
[INFO] [stderr]     Checking backtrace v0.3.3
[INFO] [stderr]     Checking rayon v0.8.2
[INFO] [stderr]     Checking pbr v1.0.0
[INFO] [stderr]     Checking jpeg-decoder v0.1.13
[INFO] [stderr]     Checking image v0.17.0
[INFO] [stderr]     Checking glium_text v0.11.0
[INFO] [stderr]     Checking mandelbrot v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: the loop variable `y` is used to index `pixels`
[INFO] [stderr]    --> src/main.rs:119:26
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 for y in 0..pixels.len() {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 for (y, <item>) in pixels.iter().enumerate() {
[INFO] [stderr]     |                     ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:150:17
[INFO] [stderr]     |
[INFO] [stderr] 150 | /                 match ev {
[INFO] [stderr] 151 | |                     Event::WindowEvent { event, .. } => match event {
[INFO] [stderr] 152 | |                         WindowEvent::Closed => closed = true,
[INFO] [stderr] 153 | |                         WindowEvent::Resized(x, y) => { draw = true; screen_size[0] = x as f32; screen_size[1] = y as f32}
[INFO] [stderr] ...   |
[INFO] [stderr] 237 | |                     _ => ()
[INFO] [stderr] 238 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 150 |                 if let Event::WindowEvent { event, .. } = ev { match event {
[INFO] [stderr] 151 |     WindowEvent::Closed => closed = true,
[INFO] [stderr] 152 |     WindowEvent::Resized(x, y) => { draw = true; screen_size[0] = x as f32; screen_size[1] = y as f32}
[INFO] [stderr] 153 |     WindowEvent::MouseMoved { position: (x, y), .. } =>  { mouse_x = x as f64; mouse_y = y; }
[INFO] [stderr] 154 |     WindowEvent::MouseInput { button: MouseButton::Left, state: ElementState::Pressed, .. } => {
[INFO] [stderr] 155 |         let zoom_factor: f64 = (2. / zoom) as f64;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:160:29
[INFO] [stderr]     |
[INFO] [stderr] 160 | /                             let mut offset_y: f64 = 0.0;
[INFO] [stderr] 161 | |                             if (screen_size[0] as f64) == max_screen_size {
[INFO] [stderr] 162 | |                                 offset_y = ((screen_size[0] - screen_size[1]) / 2.) as f64;
[INFO] [stderr] 163 | |                             } else {
[INFO] [stderr] 164 | |                                 offset_x = ((screen_size[0] - screen_size[1]) / 2.) as f64;
[INFO] [stderr] 165 | |                             }
[INFO] [stderr]     | |_____________________________^ help: it is more idiomatic to write: `let <mut> offset_y = if (screen_size[0] as f64) == max_screen_size { ((screen_size[0] - screen_size[1]) / 2.) as f64 } else { ..; 0.0 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:156:52
[INFO] [stderr]     |
[INFO] [stderr] 156 |                             let zoom_factor: f64 = (2. / zoom) as f64;
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(2. / zoom)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:157:51
[INFO] [stderr]     |
[INFO] [stderr] 157 |                             let max_screen_size = f32::max(screen_size[0], screen_size[1]) as f64;
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(f32::max(screen_size[0], screen_size[1]))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/main.rs:161:32
[INFO] [stderr]     |
[INFO] [stderr] 161 |                             if (screen_size[0] as f64) == max_screen_size {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `((screen_size[0] as f64) - max_screen_size).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/main.rs:161:32
[INFO] [stderr]     |
[INFO] [stderr] 161 |                             if (screen_size[0] as f64) == max_screen_size {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:161:32
[INFO] [stderr]     |
[INFO] [stderr] 161 |                             if (screen_size[0] as f64) == max_screen_size {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(screen_size[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:162:44
[INFO] [stderr]     |
[INFO] [stderr] 162 |                                 offset_y = ((screen_size[0] - screen_size[1]) / 2.) as f64;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((screen_size[0] - screen_size[1]) / 2.)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:164:44
[INFO] [stderr]     |
[INFO] [stderr] 164 |                                 offset_x = ((screen_size[0] - screen_size[1]) / 2.) as f64;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((screen_size[0] - screen_size[1]) / 2.)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:173:69
[INFO] [stderr]     |
[INFO] [stderr] 173 |                           WindowEvent::KeyboardInput { input, .. } => match input {
[INFO] [stderr]     |  _____________________________________________________________________^
[INFO] [stderr] 174 | |                             KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] 175 | |                                 Some(VirtualKeyCode::Escape) => closed = true,
[INFO] [stderr] 176 | |                                 Some(VirtualKeyCode::Up) => z[0] += pan_rate * 0.1,
[INFO] [stderr] ...   |
[INFO] [stderr] 232 | |                             _ => (),
[INFO] [stderr] 233 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 173 |                         WindowEvent::KeyboardInput { input, .. } => if let KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } = input { draw = true; match virtual_keycode {
[INFO] [stderr] 174 |     Some(VirtualKeyCode::Escape) => closed = true,
[INFO] [stderr] 175 |     Some(VirtualKeyCode::Up) => z[0] += pan_rate * 0.1,
[INFO] [stderr] 176 |     Some(VirtualKeyCode::Down) => z[0] -= pan_rate * 0.1,
[INFO] [stderr] 177 |     Some(VirtualKeyCode::Left) => z[1] += pan_rate * 0.1,
[INFO] [stderr] 178 |     Some(VirtualKeyCode::Right) => z[1] -= pan_rate * 0.1,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:199:54
[INFO] [stderr]     |
[INFO] [stderr] 199 |                                     pan_rate = 0.5 / (zoom as f64).exp();
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^ help: try: `f64::from(zoom)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:204:54
[INFO] [stderr]     |
[INFO] [stderr] 204 |                                     pan_rate = 0.5 / (zoom as f64).exp();
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^ help: try: `f64::from(zoom)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:242:17
[INFO] [stderr]     |
[INFO] [stderr] 242 | /                 match ev {
[INFO] [stderr] 243 | |                     Event::WindowEvent { event, .. } => match event {
[INFO] [stderr] 244 | |                         WindowEvent::KeyboardInput { input, .. } => match input {
[INFO] [stderr] 245 | |                             KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] ...   |
[INFO] [stderr] 260 | |                     _ => ()
[INFO] [stderr] 261 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 if let Event::WindowEvent { event, .. } = ev { match event {
[INFO] [stderr] 243 |     WindowEvent::KeyboardInput { input, .. } => match input {
[INFO] [stderr] 244 |         KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] 245 |             Some(VirtualKeyCode::Q) => {
[INFO] [stderr] 246 |                 anim = -1;
[INFO] [stderr] 247 |                 print!("Waiting on {} jobs ... ", pool.active_count());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:243:57
[INFO] [stderr]     |
[INFO] [stderr] 243 |                       Event::WindowEvent { event, .. } => match event {
[INFO] [stderr]     |  _________________________________________________________^
[INFO] [stderr] 244 | |                         WindowEvent::KeyboardInput { input, .. } => match input {
[INFO] [stderr] 245 | |                             KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] 246 | |                                 Some(VirtualKeyCode::Q) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 258 | |
[INFO] [stderr] 259 | |                     },
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 243 |                     Event::WindowEvent { event, .. } => if let WindowEvent::KeyboardInput { input, .. } = event { match input {
[INFO] [stderr] 244 |     KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] 245 |         Some(VirtualKeyCode::Q) => {
[INFO] [stderr] 246 |             anim = -1;
[INFO] [stderr] 247 |             print!("Waiting on {} jobs ... ", pool.active_count());
[INFO] [stderr] 248 |             stdout().flush().unwrap();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:244:69
[INFO] [stderr]     |
[INFO] [stderr] 244 |                           WindowEvent::KeyboardInput { input, .. } => match input {
[INFO] [stderr]     |  _____________________________________________________________________^
[INFO] [stderr] 245 | |                             KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] 246 | |                                 Some(VirtualKeyCode::Q) => {
[INFO] [stderr] 247 | |                                     anim = -1;
[INFO] [stderr] ...   |
[INFO] [stderr] 255 | |                             _ => ()
[INFO] [stderr] 256 | |                         },
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 244 |                         WindowEvent::KeyboardInput { input, .. } => if let KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } = input { draw = true; match virtual_keycode {
[INFO] [stderr] 245 |     Some(VirtualKeyCode::Q) => {
[INFO] [stderr] 246 |         anim = -1;
[INFO] [stderr] 247 |         print!("Waiting on {} jobs ... ", pool.active_count());
[INFO] [stderr] 248 |         stdout().flush().unwrap();
[INFO] [stderr] 249 |         pool.join();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:245:115
[INFO] [stderr]     |
[INFO] [stderr] 245 |                               KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr]     |  ___________________________________________________________________________________________________________________^
[INFO] [stderr] 246 | |                                 Some(VirtualKeyCode::Q) => {
[INFO] [stderr] 247 | |                                     anim = -1;
[INFO] [stderr] 248 | |                                     print!("Waiting on {} jobs ... ", pool.active_count());
[INFO] [stderr] ...   |
[INFO] [stderr] 253 | |                                 _ => ()
[INFO] [stderr] 254 | |                             } },
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 245 |                             KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; if let Some(VirtualKeyCode::Q) = virtual_keycode {
[INFO] [stderr] 246 |     anim = -1;
[INFO] [stderr] 247 |     print!("Waiting on {} jobs ... ", pool.active_count());
[INFO] [stderr] 248 |     stdout().flush().unwrap();
[INFO] [stderr] 249 |     pool.join();
[INFO] [stderr] 250 |     println!("Done");
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mandelbrot`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: the loop variable `y` is used to index `pixels`
[INFO] [stderr]    --> src/main.rs:119:26
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 for y in 0..pixels.len() {
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 119 |                 for (y, <item>) in pixels.iter().enumerate() {
[INFO] [stderr]     |                     ^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:150:17
[INFO] [stderr]     |
[INFO] [stderr] 150 | /                 match ev {
[INFO] [stderr] 151 | |                     Event::WindowEvent { event, .. } => match event {
[INFO] [stderr] 152 | |                         WindowEvent::Closed => closed = true,
[INFO] [stderr] 153 | |                         WindowEvent::Resized(x, y) => { draw = true; screen_size[0] = x as f32; screen_size[1] = y as f32}
[INFO] [stderr] ...   |
[INFO] [stderr] 237 | |                     _ => ()
[INFO] [stderr] 238 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 150 |                 if let Event::WindowEvent { event, .. } = ev { match event {
[INFO] [stderr] 151 |     WindowEvent::Closed => closed = true,
[INFO] [stderr] 152 |     WindowEvent::Resized(x, y) => { draw = true; screen_size[0] = x as f32; screen_size[1] = y as f32}
[INFO] [stderr] 153 |     WindowEvent::MouseMoved { position: (x, y), .. } =>  { mouse_x = x as f64; mouse_y = y; }
[INFO] [stderr] 154 |     WindowEvent::MouseInput { button: MouseButton::Left, state: ElementState::Pressed, .. } => {
[INFO] [stderr] 155 |         let zoom_factor: f64 = (2. / zoom) as f64;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/main.rs:160:29
[INFO] [stderr]     |
[INFO] [stderr] 160 | /                             let mut offset_y: f64 = 0.0;
[INFO] [stderr] 161 | |                             if (screen_size[0] as f64) == max_screen_size {
[INFO] [stderr] 162 | |                                 offset_y = ((screen_size[0] - screen_size[1]) / 2.) as f64;
[INFO] [stderr] 163 | |                             } else {
[INFO] [stderr] 164 | |                                 offset_x = ((screen_size[0] - screen_size[1]) / 2.) as f64;
[INFO] [stderr] 165 | |                             }
[INFO] [stderr]     | |_____________________________^ help: it is more idiomatic to write: `let <mut> offset_y = if (screen_size[0] as f64) == max_screen_size { ((screen_size[0] - screen_size[1]) / 2.) as f64 } else { ..; 0.0 };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:156:52
[INFO] [stderr]     |
[INFO] [stderr] 156 |                             let zoom_factor: f64 = (2. / zoom) as f64;
[INFO] [stderr]     |                                                    ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(2. / zoom)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:157:51
[INFO] [stderr]     |
[INFO] [stderr] 157 |                             let max_screen_size = f32::max(screen_size[0], screen_size[1]) as f64;
[INFO] [stderr]     |                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(f32::max(screen_size[0], screen_size[1]))`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/main.rs:161:32
[INFO] [stderr]     |
[INFO] [stderr] 161 |                             if (screen_size[0] as f64) == max_screen_size {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `((screen_size[0] as f64) - max_screen_size).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/main.rs:161:32
[INFO] [stderr]     |
[INFO] [stderr] 161 |                             if (screen_size[0] as f64) == max_screen_size {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:161:32
[INFO] [stderr]     |
[INFO] [stderr] 161 |                             if (screen_size[0] as f64) == max_screen_size {
[INFO] [stderr]     |                                ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(screen_size[0])`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:162:44
[INFO] [stderr]     |
[INFO] [stderr] 162 |                                 offset_y = ((screen_size[0] - screen_size[1]) / 2.) as f64;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((screen_size[0] - screen_size[1]) / 2.)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:164:44
[INFO] [stderr]     |
[INFO] [stderr] 164 |                                 offset_x = ((screen_size[0] - screen_size[1]) / 2.) as f64;
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from((screen_size[0] - screen_size[1]) / 2.)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:173:69
[INFO] [stderr]     |
[INFO] [stderr] 173 |                           WindowEvent::KeyboardInput { input, .. } => match input {
[INFO] [stderr]     |  _____________________________________________________________________^
[INFO] [stderr] 174 | |                             KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] 175 | |                                 Some(VirtualKeyCode::Escape) => closed = true,
[INFO] [stderr] 176 | |                                 Some(VirtualKeyCode::Up) => z[0] += pan_rate * 0.1,
[INFO] [stderr] ...   |
[INFO] [stderr] 232 | |                             _ => (),
[INFO] [stderr] 233 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 173 |                         WindowEvent::KeyboardInput { input, .. } => if let KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } = input { draw = true; match virtual_keycode {
[INFO] [stderr] 174 |     Some(VirtualKeyCode::Escape) => closed = true,
[INFO] [stderr] 175 |     Some(VirtualKeyCode::Up) => z[0] += pan_rate * 0.1,
[INFO] [stderr] 176 |     Some(VirtualKeyCode::Down) => z[0] -= pan_rate * 0.1,
[INFO] [stderr] 177 |     Some(VirtualKeyCode::Left) => z[1] += pan_rate * 0.1,
[INFO] [stderr] 178 |     Some(VirtualKeyCode::Right) => z[1] -= pan_rate * 0.1,
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:199:54
[INFO] [stderr]     |
[INFO] [stderr] 199 |                                     pan_rate = 0.5 / (zoom as f64).exp();
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^ help: try: `f64::from(zoom)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting f32 to f64 may become silently lossy if types change
[INFO] [stderr]    --> src/main.rs:204:54
[INFO] [stderr]     |
[INFO] [stderr] 204 |                                     pan_rate = 0.5 / (zoom as f64).exp();
[INFO] [stderr]     |                                                      ^^^^^^^^^^^^^ help: try: `f64::from(zoom)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:242:17
[INFO] [stderr]     |
[INFO] [stderr] 242 | /                 match ev {
[INFO] [stderr] 243 | |                     Event::WindowEvent { event, .. } => match event {
[INFO] [stderr] 244 | |                         WindowEvent::KeyboardInput { input, .. } => match input {
[INFO] [stderr] 245 | |                             KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] ...   |
[INFO] [stderr] 260 | |                     _ => ()
[INFO] [stderr] 261 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 242 |                 if let Event::WindowEvent { event, .. } = ev { match event {
[INFO] [stderr] 243 |     WindowEvent::KeyboardInput { input, .. } => match input {
[INFO] [stderr] 244 |         KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] 245 |             Some(VirtualKeyCode::Q) => {
[INFO] [stderr] 246 |                 anim = -1;
[INFO] [stderr] 247 |                 print!("Waiting on {} jobs ... ", pool.active_count());
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:243:57
[INFO] [stderr]     |
[INFO] [stderr] 243 |                       Event::WindowEvent { event, .. } => match event {
[INFO] [stderr]     |  _________________________________________________________^
[INFO] [stderr] 244 | |                         WindowEvent::KeyboardInput { input, .. } => match input {
[INFO] [stderr] 245 | |                             KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] 246 | |                                 Some(VirtualKeyCode::Q) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 258 | |
[INFO] [stderr] 259 | |                     },
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 243 |                     Event::WindowEvent { event, .. } => if let WindowEvent::KeyboardInput { input, .. } = event { match input {
[INFO] [stderr] 244 |     KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] 245 |         Some(VirtualKeyCode::Q) => {
[INFO] [stderr] 246 |             anim = -1;
[INFO] [stderr] 247 |             print!("Waiting on {} jobs ... ", pool.active_count());
[INFO] [stderr] 248 |             stdout().flush().unwrap();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:244:69
[INFO] [stderr]     |
[INFO] [stderr] 244 |                           WindowEvent::KeyboardInput { input, .. } => match input {
[INFO] [stderr]     |  _____________________________________________________________________^
[INFO] [stderr] 245 | |                             KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr] 246 | |                                 Some(VirtualKeyCode::Q) => {
[INFO] [stderr] 247 | |                                     anim = -1;
[INFO] [stderr] ...   |
[INFO] [stderr] 255 | |                             _ => ()
[INFO] [stderr] 256 | |                         },
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 244 |                         WindowEvent::KeyboardInput { input, .. } => if let KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } = input { draw = true; match virtual_keycode {
[INFO] [stderr] 245 |     Some(VirtualKeyCode::Q) => {
[INFO] [stderr] 246 |         anim = -1;
[INFO] [stderr] 247 |         print!("Waiting on {} jobs ... ", pool.active_count());
[INFO] [stderr] 248 |         stdout().flush().unwrap();
[INFO] [stderr] 249 |         pool.join();
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/main.rs:245:115
[INFO] [stderr]     |
[INFO] [stderr] 245 |                               KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; match virtual_keycode {
[INFO] [stderr]     |  ___________________________________________________________________________________________________________________^
[INFO] [stderr] 246 | |                                 Some(VirtualKeyCode::Q) => {
[INFO] [stderr] 247 | |                                     anim = -1;
[INFO] [stderr] 248 | |                                     print!("Waiting on {} jobs ... ", pool.active_count());
[INFO] [stderr] ...   |
[INFO] [stderr] 253 | |                                 _ => ()
[INFO] [stderr] 254 | |                             } },
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 245 |                             KeyboardInput { virtual_keycode, state: ElementState::Pressed, .. } => { draw = true; if let Some(VirtualKeyCode::Q) = virtual_keycode {
[INFO] [stderr] 246 |     anim = -1;
[INFO] [stderr] 247 |     print!("Waiting on {} jobs ... ", pool.active_count());
[INFO] [stderr] 248 |     stdout().flush().unwrap();
[INFO] [stderr] 249 |     pool.join();
[INFO] [stderr] 250 |     println!("Done");
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mandelbrot`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "374f174bfe0960ece3731361a543b82da5e4e34a19878dd4a0f2c783f17f9d88"`
[INFO] running `"docker" "rm" "-f" "374f174bfe0960ece3731361a543b82da5e4e34a19878dd4a0f2c783f17f9d88"`
[INFO] [stdout] 374f174bfe0960ece3731361a543b82da5e4e34a19878dd4a0f2c783f17f9d88