[INFO] updating cached repository sgbasaraner/yeelight-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sgbasaraner/yeelight-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sgbasaraner/yeelight-cli" "work/ex/clippy-test-run/sources/stable/gh/sgbasaraner/yeelight-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sgbasaraner/yeelight-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sgbasaraner/yeelight-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgbasaraner/yeelight-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgbasaraner/yeelight-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] b266f8b945be1f89a3b5f9f7c16a6d83102b9a57 [INFO] sha for GitHub repo sgbasaraner/yeelight-cli: b266f8b945be1f89a3b5f9f7c16a6d83102b9a57 [INFO] validating manifest of sgbasaraner/yeelight-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sgbasaraner/yeelight-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sgbasaraner/yeelight-cli [INFO] finished frobbing sgbasaraner/yeelight-cli [INFO] frobbed toml for sgbasaraner/yeelight-cli written to work/ex/clippy-test-run/sources/stable/gh/sgbasaraner/yeelight-cli/Cargo.toml [INFO] started frobbing sgbasaraner/yeelight-cli [INFO] finished frobbing sgbasaraner/yeelight-cli [INFO] frobbed toml for sgbasaraner/yeelight-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgbasaraner/yeelight-cli/Cargo.toml [INFO] crate sgbasaraner/yeelight-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sgbasaraner/yeelight-cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sgbasaraner/yeelight-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e4963473a4ab11d9212037e12ab593ec1d95bb1ca377cc463e1e3df8c5c956ad [INFO] running `"docker" "start" "-a" "e4963473a4ab11d9212037e12ab593ec1d95bb1ca377cc463e1e3df8c5c956ad"` [INFO] [stderr] Checking encode_unicode v0.3.1 [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking csv v0.15.0 [INFO] [stderr] Checking prettytable-rs v0.6.7 [INFO] [stderr] Checking yee v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:234:5 [INFO] [stderr] | [INFO] [stderr] 234 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `int` [INFO] [stderr] --> src/main.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | b: ((int >> 0) & 0xFF) as u8 [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:256:24 [INFO] [stderr] | [INFO] [stderr] 256 | fn operate_on_bulb(id: &u32, bulb: &Bulb, method: &str, params: &str) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `int` [INFO] [stderr] --> src/main.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | b: ((int >> 0) & 0xFF) as u8 [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:256:24 [INFO] [stderr] | [INFO] [stderr] 256 | fn operate_on_bulb(id: &u32, bulb: &Bulb, method: &str, params: &str) { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `u32` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.21s [INFO] running `"docker" "inspect" "e4963473a4ab11d9212037e12ab593ec1d95bb1ca377cc463e1e3df8c5c956ad"` [INFO] running `"docker" "rm" "-f" "e4963473a4ab11d9212037e12ab593ec1d95bb1ca377cc463e1e3df8c5c956ad"` [INFO] [stdout] e4963473a4ab11d9212037e12ab593ec1d95bb1ca377cc463e1e3df8c5c956ad