[INFO] updating cached repository sgabhart22/rust-stones [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sgabhart22/rust-stones [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sgabhart22/rust-stones" "work/ex/clippy-test-run/sources/stable/gh/sgabhart22/rust-stones"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sgabhart22/rust-stones'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sgabhart22/rust-stones" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgabhart22/rust-stones"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgabhart22/rust-stones'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e351513c30f82327a7f135b95e9cf6a5d5f38bea [INFO] sha for GitHub repo sgabhart22/rust-stones: e351513c30f82327a7f135b95e9cf6a5d5f38bea [INFO] validating manifest of sgabhart22/rust-stones on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sgabhart22/rust-stones on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sgabhart22/rust-stones [INFO] finished frobbing sgabhart22/rust-stones [INFO] frobbed toml for sgabhart22/rust-stones written to work/ex/clippy-test-run/sources/stable/gh/sgabhart22/rust-stones/Cargo.toml [INFO] started frobbing sgabhart22/rust-stones [INFO] finished frobbing sgabhart22/rust-stones [INFO] frobbed toml for sgabhart22/rust-stones written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgabhart22/rust-stones/Cargo.toml [INFO] crate sgabhart22/rust-stones has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sgabhart22/rust-stones against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sgabhart22/rust-stones:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6474973505f91341d731a59e9f81acda0ccb56f00735b07cde7a8c2c2ca9ced7 [INFO] running `"docker" "start" "-a" "6474973505f91341d731a59e9f81acda0ccb56f00735b07cde7a8c2c2ca9ced7"` [INFO] [stderr] Checking stones v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `piston::input::*` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use piston::input::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Transformed`, `color` [INFO] [stderr] --> src/main.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | use graphics::{color, Transformed}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston_window::*` [INFO] [stderr] --> src/app.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use piston_window::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Image`, `Rectangle`, `color`, `grid`, `line` [INFO] [stderr] --> src/app.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | use graphics::{line, grid, color, Transformed, Rectangle, Image}; [INFO] [stderr] | ^^^^ ^^^^ ^^^^^ ^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/board.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | board [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/board.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | let board = Board{ cells: [[Cell{ cell_color: None, pos: false }; 10]; 10]}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston::input::*` [INFO] [stderr] --> src/main.rs:10:5 [INFO] [stderr] | [INFO] [stderr] 10 | use piston::input::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Transformed`, `color` [INFO] [stderr] --> src/main.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | use graphics::{color, Transformed}; [INFO] [stderr] | ^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `piston_window::*` [INFO] [stderr] --> src/app.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use piston_window::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Image`, `Rectangle`, `color`, `grid`, `line` [INFO] [stderr] --> src/app.rs:6:16 [INFO] [stderr] | [INFO] [stderr] 6 | use graphics::{line, grid, color, Transformed, Rectangle, Image}; [INFO] [stderr] | ^^^^ ^^^^ ^^^^^ ^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/board.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | board [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/board.rs:46:21 [INFO] [stderr] | [INFO] [stderr] 46 | let board = Board{ cells: [[Cell{ cell_color: None, pos: false }; 10]; 10]}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `Transformed` [INFO] [stderr] --> src/app.rs:6:35 [INFO] [stderr] | [INFO] [stderr] 6 | use graphics::{line, grid, color, Transformed, Rectangle, Image}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/board.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | let mut point = Vec2f{ x: x_comp, y: y_comp }; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `selected_cell` [INFO] [stderr] --> src/app.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | selected_cell: Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `BG_Colors` [INFO] [stderr] --> src/tile.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub enum BG_Colors { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `FG_Colors` [INFO] [stderr] --> src/tile.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub enum FG_Colors { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Shapes` [INFO] [stderr] --> src/tile.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub enum Shapes { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Tile` [INFO] [stderr] --> src/tile.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub struct Tile { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused_imports)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/app.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | let ref current = self.board.get_cell(y, x); [INFO] [stderr] | ----^^^^^^^^^^^----------------------------- help: try: `let current = &self.board.get_cell(y, x);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/app.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | if current.pos == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `current.pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:55:50 [INFO] [stderr] | [INFO] [stderr] 55 | let dims = rectangle::square(x as f64 * settings::CELL_DIMS, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:56:50 [INFO] [stderr] | [INFO] [stderr] 56 | y as f64 * settings::CELL_DIMS, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/app.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match button { [INFO] [stderr] 67 | | &Button::Keyboard(key) => { [INFO] [stderr] 68 | | println!("Pressed key {:?}", key); [INFO] [stderr] 69 | | }, [INFO] [stderr] ... | [INFO] [stderr] 73 | | &Button::Controller(_) => {} [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 66 | match *button { [INFO] [stderr] 67 | Button::Keyboard(key) => { [INFO] [stderr] 68 | println!("Pressed key {:?}", key); [INFO] [stderr] 69 | }, [INFO] [stderr] 70 | Button::Mouse(button) => { [INFO] [stderr] 71 | self.on_mouse_click(&button); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:77:46 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn on_mouse_click(&mut self, button: &MouseButton) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `MouseButton` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/app.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let ref point = Vec2f{ x: self.mouse_coords.x, y: self.mouse_coords.y }; [INFO] [stderr] | ----^^^^^^^^^----------------------------------------------------------- help: try: `let point = &Vec2f{ x: self.mouse_coords.x, y: self.mouse_coords.y };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: type `BG_Colors` should have a camel case name such as `BgColors` [INFO] [stderr] --> src/tile.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub enum BG_Colors { [INFO] [stderr] 2 | | Pink, [INFO] [stderr] 3 | | Blue, [INFO] [stderr] 4 | | Green, [INFO] [stderr] 5 | | Black [INFO] [stderr] 6 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `FG_Colors` should have a camel case name such as `FgColors` [INFO] [stderr] --> src/tile.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub enum FG_Colors { [INFO] [stderr] 9 | | Purple, [INFO] [stderr] 10 | | Red, [INFO] [stderr] 11 | | Yellow [INFO] [stderr] 12 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let ref mut gl = GlGraphics::new(opengl); [INFO] [stderr] | ----^^^^^^^^^^--------------------------- help: try: `let gl = &mut GlGraphics::new(opengl);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `stones`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `Transformed` [INFO] [stderr] --> src/app.rs:6:35 [INFO] [stderr] | [INFO] [stderr] 6 | use graphics::{line, grid, color, Transformed, Rectangle, Image}; [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/board.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | let mut point = Vec2f{ x: x_comp, y: y_comp }; [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `selected_cell` [INFO] [stderr] --> src/app.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | selected_cell: Option [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `BG_Colors` [INFO] [stderr] --> src/tile.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | pub enum BG_Colors { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `FG_Colors` [INFO] [stderr] --> src/tile.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub enum FG_Colors { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `Shapes` [INFO] [stderr] --> src/tile.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | pub enum Shapes { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Tile` [INFO] [stderr] --> src/tile.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub struct Tile { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/main.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(unused_imports)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused_imports)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/app.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | let ref current = self.board.get_cell(y, x); [INFO] [stderr] | ----^^^^^^^^^^^----------------------------- help: try: `let current = &self.board.get_cell(y, x);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/app.rs:53:20 [INFO] [stderr] | [INFO] [stderr] 53 | if current.pos == true { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `current.pos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:55:50 [INFO] [stderr] | [INFO] [stderr] 55 | let dims = rectangle::square(x as f64 * settings::CELL_DIMS, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(x)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f64 may become silently lossy if types change [INFO] [stderr] --> src/app.rs:56:50 [INFO] [stderr] | [INFO] [stderr] 56 | y as f64 * settings::CELL_DIMS, [INFO] [stderr] | ^^^^^^^^ help: try: `f64::from(y)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/app.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / match button { [INFO] [stderr] 67 | | &Button::Keyboard(key) => { [INFO] [stderr] 68 | | println!("Pressed key {:?}", key); [INFO] [stderr] 69 | | }, [INFO] [stderr] ... | [INFO] [stderr] 73 | | &Button::Controller(_) => {} [INFO] [stderr] 74 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 66 | match *button { [INFO] [stderr] 67 | Button::Keyboard(key) => { [INFO] [stderr] 68 | println!("Pressed key {:?}", key); [INFO] [stderr] 69 | }, [INFO] [stderr] 70 | Button::Mouse(button) => { [INFO] [stderr] 71 | self.on_mouse_click(&button); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:77:46 [INFO] [stderr] | [INFO] [stderr] 77 | pub fn on_mouse_click(&mut self, button: &MouseButton) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `MouseButton` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/app.rs:81:13 [INFO] [stderr] | [INFO] [stderr] 81 | let ref point = Vec2f{ x: self.mouse_coords.x, y: self.mouse_coords.y }; [INFO] [stderr] | ----^^^^^^^^^----------------------------------------------------------- help: try: `let point = &Vec2f{ x: self.mouse_coords.x, y: self.mouse_coords.y };` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: type `BG_Colors` should have a camel case name such as `BgColors` [INFO] [stderr] --> src/tile.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | / pub enum BG_Colors { [INFO] [stderr] 2 | | Pink, [INFO] [stderr] 3 | | Blue, [INFO] [stderr] 4 | | Green, [INFO] [stderr] 5 | | Black [INFO] [stderr] 6 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_camel_case_types)] on by default [INFO] [stderr] [INFO] [stderr] warning: type `FG_Colors` should have a camel case name such as `FgColors` [INFO] [stderr] --> src/tile.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | / pub enum FG_Colors { [INFO] [stderr] 9 | | Purple, [INFO] [stderr] 10 | | Red, [INFO] [stderr] 11 | | Yellow [INFO] [stderr] 12 | | } [INFO] [stderr] | |_^ [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let ref mut gl = GlGraphics::new(opengl); [INFO] [stderr] | ----^^^^^^^^^^--------------------------- help: try: `let gl = &mut GlGraphics::new(opengl);` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `stones`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6474973505f91341d731a59e9f81acda0ccb56f00735b07cde7a8c2c2ca9ced7"` [INFO] running `"docker" "rm" "-f" "6474973505f91341d731a59e9f81acda0ccb56f00735b07cde7a8c2c2ca9ced7"` [INFO] [stdout] 6474973505f91341d731a59e9f81acda0ccb56f00735b07cde7a8c2c2ca9ced7