[INFO] updating cached repository sgabhart22/color-picker [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sgabhart22/color-picker [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sgabhart22/color-picker" "work/ex/clippy-test-run/sources/stable/gh/sgabhart22/color-picker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sgabhart22/color-picker'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sgabhart22/color-picker" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgabhart22/color-picker"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgabhart22/color-picker'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 13daf7af74e7e934cda5561bc8be8ad747bb244f [INFO] sha for GitHub repo sgabhart22/color-picker: 13daf7af74e7e934cda5561bc8be8ad747bb244f [INFO] validating manifest of sgabhart22/color-picker on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sgabhart22/color-picker on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sgabhart22/color-picker [INFO] finished frobbing sgabhart22/color-picker [INFO] frobbed toml for sgabhart22/color-picker written to work/ex/clippy-test-run/sources/stable/gh/sgabhart22/color-picker/Cargo.toml [INFO] started frobbing sgabhart22/color-picker [INFO] finished frobbing sgabhart22/color-picker [INFO] frobbed toml for sgabhart22/color-picker written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sgabhart22/color-picker/Cargo.toml [INFO] crate sgabhart22/color-picker has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sgabhart22/color-picker against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sgabhart22/color-picker:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 432234e47697df9f8f616e0a1c0e39fcbeeeb3b15713f6186cfe86ed85154e0f [INFO] running `"docker" "start" "-a" "432234e47697df9f8f616e0a1c0e39fcbeeeb3b15713f6186cfe86ed85154e0f"` [INFO] [stderr] Compiling libc v0.2.22 [INFO] [stderr] Checking deque v0.3.2 [INFO] [stderr] Compiling serde_json v0.9.10 [INFO] [stderr] Checking num_cpus v1.4.0 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking shared_library v0.1.5 [INFO] [stderr] Checking num-integer v0.1.34 [INFO] [stderr] Compiling x11-dl v2.13.0 [INFO] [stderr] Checking deflate v0.7.9 [INFO] [stderr] Checking draw_state v0.7.0 [INFO] [stderr] Checking num-iter v0.1.33 [INFO] [stderr] Checking num-rational v0.1.36 [INFO] [stderr] Checking osmesa-sys v0.1.2 [INFO] [stderr] Checking fs2 v0.2.5 [INFO] [stderr] Checking rayon-core v1.0.0 [INFO] [stderr] Checking tempfile v2.1.5 [INFO] [stderr] Checking memmap v0.4.0 [INFO] [stderr] Checking gfx_core v0.7.0 [INFO] [stderr] Checking png v0.7.0 [INFO] [stderr] Checking rayon v0.7.0 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Checking jpeg-decoder v0.1.12 [INFO] [stderr] Checking image v0.13.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.43.0 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.7.8 [INFO] [stderr] Checking wayland-client v0.7.8 [INFO] [stderr] Checking wayland-kbd v0.6.3 [INFO] [stderr] Checking wayland-window v0.4.4 [INFO] [stderr] Checking winit v0.5.11 [INFO] [stderr] Checking glutin v0.7.4 [INFO] [stderr] Checking pistoncore-glutin_window v0.36.0 [INFO] [stderr] Checking gfx v0.15.1 [INFO] [stderr] Checking gfx_device_gl v0.14.0 [INFO] [stderr] Checking piston-gfx_texture v0.23.0 [INFO] [stderr] Checking piston2d-gfx_graphics v0.39.0 [INFO] [stderr] Checking piston_window v0.65.0 [INFO] [stderr] Checking color_picker v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | settings: settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `graphics` [INFO] [stderr] --> src/app.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use graphics; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `opengl_graphics::glyph_cache::GlyphCache` [INFO] [stderr] --> src/app.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use opengl_graphics::glyph_cache::GlyphCache; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/app.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | for n in 0..10 { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `button` [INFO] [stderr] --> src/app.rs:87:39 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn on_button_press(&mut self, button: &Button) { [INFO] [stderr] | ^^^^^^ help: consider using `_button` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `button` [INFO] [stderr] --> src/app.rs:91:34 [INFO] [stderr] | [INFO] [stderr] 91 | fn on_mouse_click(&mut self, button: &MouseButton) { [INFO] [stderr] | ^^^^^^ help: consider using `_button` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/app.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let mut line = line::Line::new(color::BLACK, 1.0); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/app.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let mut line = line::Line::new(color::BLACK, 1.0); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `settings` [INFO] [stderr] --> src/app.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | settings: settings::Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `on_mouse_click` [INFO] [stderr] --> src/app.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | fn on_mouse_click(&mut self, button: &MouseButton) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:91:42 [INFO] [stderr] | [INFO] [stderr] 91 | fn on_mouse_click(&mut self, button: &MouseButton) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `MouseButton` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | let ref mut gl = GlGraphics::new(opengl); [INFO] [stderr] | ----^^^^^^^^^^--------------------------- help: try: `let gl = &mut GlGraphics::new(opengl);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/main.rs:13:5 [INFO] [stderr] | [INFO] [stderr] 13 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `graphics` [INFO] [stderr] --> src/app.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use graphics; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `opengl_graphics::glyph_cache::GlyphCache` [INFO] [stderr] --> src/app.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use opengl_graphics::glyph_cache::GlyphCache; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `n` [INFO] [stderr] --> src/app.rs:56:17 [INFO] [stderr] | [INFO] [stderr] 56 | for n in 0..10 { [INFO] [stderr] | ^ help: consider using `_n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `button` [INFO] [stderr] --> src/app.rs:87:39 [INFO] [stderr] | [INFO] [stderr] 87 | pub fn on_button_press(&mut self, button: &Button) { [INFO] [stderr] | ^^^^^^ help: consider using `_button` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `button` [INFO] [stderr] --> src/app.rs:91:34 [INFO] [stderr] | [INFO] [stderr] 91 | fn on_mouse_click(&mut self, button: &MouseButton) { [INFO] [stderr] | ^^^^^^ help: consider using `_button` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/app.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let mut line = line::Line::new(color::BLACK, 1.0); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/app.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | let mut line = line::Line::new(color::BLACK, 1.0); [INFO] [stderr] | ----^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: field is never used: `settings` [INFO] [stderr] --> src/app.rs:25:5 [INFO] [stderr] | [INFO] [stderr] 25 | settings: settings::Settings, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `on_mouse_click` [INFO] [stderr] --> src/app.rs:91:5 [INFO] [stderr] | [INFO] [stderr] 91 | fn on_mouse_click(&mut self, button: &MouseButton) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/app.rs:91:42 [INFO] [stderr] | [INFO] [stderr] 91 | fn on_mouse_click(&mut self, button: &MouseButton) { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `MouseButton` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | let ref mut gl = GlGraphics::new(opengl); [INFO] [stderr] | ----^^^^^^^^^^--------------------------- help: try: `let gl = &mut GlGraphics::new(opengl);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 58.37s [INFO] running `"docker" "inspect" "432234e47697df9f8f616e0a1c0e39fcbeeeb3b15713f6186cfe86ed85154e0f"` [INFO] running `"docker" "rm" "-f" "432234e47697df9f8f616e0a1c0e39fcbeeeb3b15713f6186cfe86ed85154e0f"` [INFO] [stdout] 432234e47697df9f8f616e0a1c0e39fcbeeeb3b15713f6186cfe86ed85154e0f