[INFO] updating cached repository sfuller/snas
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/sfuller/snas
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/sfuller/snas" "work/ex/clippy-test-run/sources/stable/gh/sfuller/snas"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sfuller/snas'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/sfuller/snas" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sfuller/snas"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sfuller/snas'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] aab5435c5aa435a5e3c8a06b97b3396d0c862f58
[INFO] sha for GitHub repo sfuller/snas: aab5435c5aa435a5e3c8a06b97b3396d0c862f58
[INFO] validating manifest of sfuller/snas on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of sfuller/snas on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing sfuller/snas
[INFO] finished frobbing sfuller/snas
[INFO] frobbed toml for sfuller/snas written to work/ex/clippy-test-run/sources/stable/gh/sfuller/snas/Cargo.toml
[INFO] started frobbing sfuller/snas
[INFO] finished frobbing sfuller/snas
[INFO] frobbed toml for sfuller/snas written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sfuller/snas/Cargo.toml
[INFO] crate sfuller/snas has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting sfuller/snas against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sfuller/snas:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 98f247a1ed7dd14eebc667634a0064a1ffb841e809c497617bd4f280b433c72c
[INFO] running `"docker" "start" "-a" "98f247a1ed7dd14eebc667634a0064a1ffb841e809c497617bd4f280b433c72c"`
[INFO] [stderr]     Checking snas v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/ast/visitors/print_snv.rs:10:31
[INFO] [stderr]    |
[INFO] [stderr] 10 |             node.instruction, "");
[INFO] [stderr]    |                               ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast/mod.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             instruction: instruction,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instruction`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast/mod.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             arguments: arguments
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast/mod.rs:50:28
[INFO] [stderr]    |
[INFO] [stderr] 50 |         NumberExpression { number: number }
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: replace it with: `number`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast/mod.rs:60:32
[INFO] [stderr]    |
[INFO] [stderr] 60 |         IdentifierExpression { id: id }
[INFO] [stderr]    |                                ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast/mod.rs:70:30
[INFO] [stderr]    |
[INFO] [stderr] 70 |         RegisterExpression { register: register }
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^ help: replace it with: `register`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: literal with an empty format string
[INFO] [stderr]   --> src/ast/visitors/print_snv.rs:10:31
[INFO] [stderr]    |
[INFO] [stderr] 10 |             node.instruction, "");
[INFO] [stderr]    |                               ^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::print_literal)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast/mod.rs:21:13
[INFO] [stderr]    |
[INFO] [stderr] 21 |             instruction: instruction,
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `instruction`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast/mod.rs:22:13
[INFO] [stderr]    |
[INFO] [stderr] 22 |             arguments: arguments
[INFO] [stderr]    |             ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `arguments`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast/mod.rs:50:28
[INFO] [stderr]    |
[INFO] [stderr] 50 |         NumberExpression { number: number }
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^ help: replace it with: `number`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast/mod.rs:60:32
[INFO] [stderr]    |
[INFO] [stderr] 60 |         IdentifierExpression { id: id }
[INFO] [stderr]    |                                ^^^^^^ help: replace it with: `id`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/ast/mod.rs:70:30
[INFO] [stderr]    |
[INFO] [stderr] 70 |         RegisterExpression { register: register }
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^ help: replace it with: `register`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:80:28
[INFO] [stderr]    |
[INFO] [stderr] 80 |             Some(token) => return token.clone(),
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `token.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:81:21
[INFO] [stderr]    |
[INFO] [stderr] 81 |             None => return Token::Comma()
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Comma()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:87:28
[INFO] [stderr]    |
[INFO] [stderr] 87 |             Some(token) => return token,
[INFO] [stderr]    |                            ^^^^^^^^^^^^ help: remove `return` as shown: `token`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:88:21
[INFO] [stderr]    |
[INFO] [stderr] 88 |             None => return Token::Comma()
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Comma()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `node`
[INFO] [stderr]   --> src/ast/visitors/print_snv.rs:13:36
[INFO] [stderr]    |
[INFO] [stderr] 13 |     fn visit_expression(&mut self, node: &Expression) {
[INFO] [stderr]    |                                    ^^^^ help: consider using `_node` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `arguments`
[INFO] [stderr]   --> src/ast/mod.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     arguments: Vec<Box<Expression>>
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `number`
[INFO] [stderr]   --> src/ast/mod.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     number: i32
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `id`
[INFO] [stderr]   --> src/ast/mod.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     id: String
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `register`
[INFO] [stderr]   --> src/ast/mod.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     register: Register
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: static item is never used: `REGISTER_NAMES`
[INFO] [stderr]   --> src/lib.rs:54:1
[INFO] [stderr]    |
[INFO] [stderr] 54 | static REGISTER_NAMES : [&str; 8] = ["a", "x", "y", "p", "sp", "dp", "pc", "db"];
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:80:28
[INFO] [stderr]    |
[INFO] [stderr] 80 |             Some(token) => return token.clone(),
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `token.clone()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:81:21
[INFO] [stderr]    |
[INFO] [stderr] 81 |             None => return Token::Comma()
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Comma()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:87:28
[INFO] [stderr]    |
[INFO] [stderr] 87 |             Some(token) => return token,
[INFO] [stderr]    |                            ^^^^^^^^^^^^ help: remove `return` as shown: `token`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/parser.rs:88:21
[INFO] [stderr]    |
[INFO] [stderr] 88 |             None => return Token::Comma()
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Token::Comma()`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Assembler<'a>`
[INFO] [stderr]   --> src/lib.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 | /     pub fn new() -> Assembler<'a> {
[INFO] [stderr] 63 | |         Assembler { 
[INFO] [stderr] 64 | |             src: ""
[INFO] [stderr] 65 | |         }
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 56 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `node`
[INFO] [stderr]   --> src/ast/visitors/print_snv.rs:13:36
[INFO] [stderr]    |
[INFO] [stderr] 13 |     fn visit_expression(&mut self, node: &Expression) {
[INFO] [stderr]    |                                    ^^^^ help: consider using `_node` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `arguments`
[INFO] [stderr]   --> src/ast/mod.rs:15:5
[INFO] [stderr]    |
[INFO] [stderr] 15 |     arguments: Vec<Box<Expression>>
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `number`
[INFO] [stderr]   --> src/ast/mod.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 |     number: i32
[INFO] [stderr]    |     ^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `id`
[INFO] [stderr]   --> src/ast/mod.rs:55:5
[INFO] [stderr]    |
[INFO] [stderr] 55 |     id: String
[INFO] [stderr]    |     ^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `register`
[INFO] [stderr]   --> src/ast/mod.rs:65:5
[INFO] [stderr]    |
[INFO] [stderr] 65 |     register: Register
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: static item is never used: `REGISTER_NAMES`
[INFO] [stderr]   --> src/lib.rs:54:1
[INFO] [stderr]    |
[INFO] [stderr] 54 | static REGISTER_NAMES : [&str; 8] = ["a", "x", "y", "p", "sp", "dp", "pc", "db"];
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Assembler<'a>`
[INFO] [stderr]   --> src/lib.rs:62:5
[INFO] [stderr]    |
[INFO] [stderr] 62 | /     pub fn new() -> Assembler<'a> {
[INFO] [stderr] 63 | |         Assembler { 
[INFO] [stderr] 64 | |             src: ""
[INFO] [stderr] 65 | |         }
[INFO] [stderr] 66 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 56 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1.59s
[INFO] running `"docker" "inspect" "98f247a1ed7dd14eebc667634a0064a1ffb841e809c497617bd4f280b433c72c"`
[INFO] running `"docker" "rm" "-f" "98f247a1ed7dd14eebc667634a0064a1ffb841e809c497617bd4f280b433c72c"`
[INFO] [stdout] 98f247a1ed7dd14eebc667634a0064a1ffb841e809c497617bd4f280b433c72c