[INFO] updating cached repository sfackler/foo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sfackler/foo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sfackler/foo" "work/ex/clippy-test-run/sources/stable/gh/sfackler/foo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sfackler/foo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sfackler/foo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sfackler/foo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sfackler/foo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3de6cb7babc66a3ecb54b93fca114a6fe10ef349 [INFO] sha for GitHub repo sfackler/foo: 3de6cb7babc66a3ecb54b93fca114a6fe10ef349 [INFO] validating manifest of sfackler/foo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sfackler/foo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sfackler/foo [INFO] finished frobbing sfackler/foo [INFO] frobbed toml for sfackler/foo written to work/ex/clippy-test-run/sources/stable/gh/sfackler/foo/Cargo.toml [INFO] started frobbing sfackler/foo [INFO] finished frobbing sfackler/foo [INFO] frobbed toml for sfackler/foo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sfackler/foo/Cargo.toml [INFO] crate sfackler/foo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sfackler/foo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sfackler/foo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 49befb16f8a522f52d54eea8e30a2d73fac69f1619df66c391237d87f65938ae [INFO] running `"docker" "start" "-a" "49befb16f8a522f52d54eea8e30a2d73fac69f1619df66c391237d87f65938ae"` [INFO] [stderr] Checking cfg-if v0.1.1 [INFO] [stderr] Compiling openssl v0.9.14 [INFO] [stderr] Checking iovec v0.1.0 [INFO] [stderr] Checking rand v0.3.15 [INFO] [stderr] Checking num_cpus v1.6.2 [INFO] [stderr] Checking time v0.1.37 [INFO] [stderr] Compiling openssl-sys v0.9.14 [INFO] [stderr] Checking base64 v0.6.0 [INFO] [stderr] Checking net2 v0.2.29 [INFO] [stderr] Checking bytes v0.4.4 [INFO] [stderr] Checking futures-cpupool v0.1.5 [INFO] [stderr] Checking mio v0.6.9 [INFO] [stderr] Checking tokio-io v0.1.2 [INFO] [stderr] Checking tokio-core v0.1.8 [INFO] [stderr] Checking tokio-proto v0.1.1 [INFO] [stderr] Checking tokio-openssl v0.1.3 [INFO] [stderr] Checking tokio-io-timeout v0.1.0 [INFO] [stderr] Checking hyper v0.11.0 [INFO] [stderr] Checking foo v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `Handle` [INFO] [stderr] --> src/main.rs:23:33 [INFO] [stderr] | [INFO] [stderr] 23 | use tokio_core::reactor::{Core, Handle}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `tokio_proto::streaming::pipeline::ServerProto` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | use tokio_proto::streaming::pipeline::ServerProto; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unused import: `Handle` [INFO] [stderr] --> src/main.rs:23:33 [INFO] [stderr] | [INFO] [stderr] 23 | use tokio_core::reactor::{Core, Handle}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `tokio_proto::streaming::pipeline::ServerProto` [INFO] [stderr] --> src/main.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | use tokio_proto::streaming::pipeline::ServerProto; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/main.rs:30:5 [INFO] [stderr] | [INFO] [stderr] 30 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::marker::PhantomData` [INFO] [stderr] --> src/main.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | use std::marker::PhantomData; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/main.rs:72:21 [INFO] [stderr] | [INFO] [stderr] 72 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: field is never used: `method` [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | method: Method, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `uri` [INFO] [stderr] --> src/main.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | uri: Uri, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `version` [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | version: HttpVersion, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `headers` [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | headers: Headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `method` [INFO] [stderr] --> src/main.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn method(&self) -> &Method { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uri` [INFO] [stderr] --> src/main.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn uri(&self) -> &Uri { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `version` [INFO] [stderr] --> src/main.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn version(&self) -> &HttpVersion { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `headers` [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn headers(&self) -> &Headers { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `method` [INFO] [stderr] --> src/main.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | method: Method, [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `uri` [INFO] [stderr] --> src/main.rs:108:5 [INFO] [stderr] | [INFO] [stderr] 108 | uri: Uri, [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `version` [INFO] [stderr] --> src/main.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | version: HttpVersion, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `headers` [INFO] [stderr] --> src/main.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | headers: Headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `method` [INFO] [stderr] --> src/main.rs:126:5 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn method(&self) -> &Method { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `uri` [INFO] [stderr] --> src/main.rs:130:5 [INFO] [stderr] | [INFO] [stderr] 130 | pub fn uri(&self) -> &Uri { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `version` [INFO] [stderr] --> src/main.rs:134:5 [INFO] [stderr] | [INFO] [stderr] 134 | pub fn version(&self) -> &HttpVersion { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `headers` [INFO] [stderr] --> src/main.rs:138:5 [INFO] [stderr] | [INFO] [stderr] 138 | pub fn headers(&self) -> &Headers { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:96:23 [INFO] [stderr] | [INFO] [stderr] 96 | rx.map(|resp| resp.into()) [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `resp` [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:96:23 [INFO] [stderr] | [INFO] [stderr] 96 | rx.map(|resp| resp.into()) [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `resp` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:192:12 [INFO] [stderr] | [INFO] [stderr] 192 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:192:12 [INFO] [stderr] | [INFO] [stderr] 192 | if self.buf.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 21.44s [INFO] running `"docker" "inspect" "49befb16f8a522f52d54eea8e30a2d73fac69f1619df66c391237d87f65938ae"` [INFO] running `"docker" "rm" "-f" "49befb16f8a522f52d54eea8e30a2d73fac69f1619df66c391237d87f65938ae"` [INFO] [stdout] 49befb16f8a522f52d54eea8e30a2d73fac69f1619df66c391237d87f65938ae