[INFO] updating cached repository sfackler/cargo-tree [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/sfackler/cargo-tree [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/sfackler/cargo-tree" "work/ex/clippy-test-run/sources/stable/gh/sfackler/cargo-tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/sfackler/cargo-tree'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/sfackler/cargo-tree" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sfackler/cargo-tree"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sfackler/cargo-tree'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f98af4267117282c2e9b7dd51792138662b879e1 [INFO] sha for GitHub repo sfackler/cargo-tree: f98af4267117282c2e9b7dd51792138662b879e1 [INFO] validating manifest of sfackler/cargo-tree on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of sfackler/cargo-tree on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing sfackler/cargo-tree [INFO] finished frobbing sfackler/cargo-tree [INFO] frobbed toml for sfackler/cargo-tree written to work/ex/clippy-test-run/sources/stable/gh/sfackler/cargo-tree/Cargo.toml [INFO] started frobbing sfackler/cargo-tree [INFO] finished frobbing sfackler/cargo-tree [INFO] frobbed toml for sfackler/cargo-tree written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/sfackler/cargo-tree/Cargo.toml [INFO] crate sfackler/cargo-tree has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting sfackler/cargo-tree against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/sfackler/cargo-tree:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f12b1e3df75cfd239b5ad4a6cf5e173d74bf6db3eb0299cc8c26a194b7b3db98 [INFO] running `"docker" "start" "-a" "f12b1e3df75cfd239b5ad4a6cf5e173d74bf6db3eb0299cc8c26a194b7b3db98"` [INFO] [stderr] Compiling libc v0.2.45 [INFO] [stderr] Compiling cc v1.0.26 [INFO] [stderr] Compiling crc32fast v1.1.2 [INFO] [stderr] Checking rustc-workspace-hack v1.0.0 [INFO] [stderr] Checking shell-escape v0.1.4 [INFO] [stderr] Checking home v0.3.3 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Compiling memchr v2.1.2 [INFO] [stderr] Checking crossbeam-utils v0.6.3 [INFO] [stderr] Checking humantime v1.2.0 [INFO] [stderr] Checking petgraph v0.4.13 [INFO] [stderr] Compiling serde v1.0.82 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Checking semver v0.9.0 [INFO] [stderr] Checking serde_ignored v0.0.4 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking crossbeam-epoch v0.6.1 [INFO] [stderr] Compiling serde_derive v1.0.82 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Compiling libz-sys v1.0.25 [INFO] [stderr] Compiling libnghttp2-sys v0.1.1 [INFO] [stderr] Compiling openssl-sys v0.9.39 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling libssh2-sys v0.2.11 [INFO] [stderr] Compiling curl-sys v0.4.15 [INFO] [stderr] Compiling libgit2-sys v0.7.11 [INFO] [stderr] Compiling miniz-sys v0.1.11 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking socket2 v0.3.8 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking filetime v0.2.4 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking num_cpus v1.9.0 [INFO] [stderr] Checking jobserver v0.1.12 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking tar v0.4.20 [INFO] [stderr] Compiling openssl v0.10.15 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking flate2 v1.0.6 [INFO] [stderr] Checking backtrace v0.3.12 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking rustfix v0.4.4 [INFO] [stderr] Checking opener v0.3.2 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking env_logger v0.6.0 [INFO] [stderr] Compiling parking_lot_core v0.3.1 [INFO] [stderr] Compiling rand_pcg v0.1.1 [INFO] [stderr] Compiling rand_chacha v0.1.0 [INFO] [stderr] Compiling rand v0.6.1 [INFO] [stderr] Checking crypto-hash v0.3.1 [INFO] [stderr] Checking parking_lot v0.6.4 [INFO] [stderr] Checking crossbeam-channel v0.2.6 [INFO] [stderr] Checking ignore v0.4.4 [INFO] [stderr] Checking tempfile v3.0.5 [INFO] [stderr] Checking curl v0.4.19 [INFO] [stderr] Checking crates-io v0.20.0 [INFO] [stderr] Checking git2 v0.7.5 [INFO] [stderr] Checking git2-curl v0.8.2 [INFO] [stderr] Checking cargo v0.32.0 [INFO] [stderr] Checking cargo-tree v0.23.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/parse.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | s: s, [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/parse.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | s: s, [INFO] [stderr] | ^^^^ help: replace it with: `s` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/mod.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | package: package, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `package` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format/mod.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | metadata: metadata, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:193:32 [INFO] [stderr] | [INFO] [stderr] 193 | cargo::exit_with_error(e.into(), &mut shell) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/main.rs:453:1 [INFO] [stderr] | [INFO] [stderr] 453 | / fn print_dependency<'a>( [INFO] [stderr] 454 | | package: &Node<'a>, [INFO] [stderr] 455 | | graph: &Graph<'a>, [INFO] [stderr] 456 | | format: &Pattern, [INFO] [stderr] ... | [INFO] [stderr] 546 | | ); [INFO] [stderr] 547 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/main.rs:549:1 [INFO] [stderr] | [INFO] [stderr] 549 | / fn print_dependency_kind<'a>( [INFO] [stderr] 550 | | kind: Kind, [INFO] [stderr] 551 | | mut deps: Vec<&Node<'a>>, [INFO] [stderr] 552 | | graph: &Graph<'a>, [INFO] [stderr] ... | [INFO] [stderr] 599 | | } [INFO] [stderr] 600 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:193:32 [INFO] [stderr] | [INFO] [stderr] 193 | cargo::exit_with_error(e.into(), &mut shell) [INFO] [stderr] | ^^^^^^^^ help: consider removing `.into()`: `e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (9/7) [INFO] [stderr] --> src/main.rs:453:1 [INFO] [stderr] | [INFO] [stderr] 453 | / fn print_dependency<'a>( [INFO] [stderr] 454 | | package: &Node<'a>, [INFO] [stderr] 455 | | graph: &Graph<'a>, [INFO] [stderr] 456 | | format: &Pattern, [INFO] [stderr] ... | [INFO] [stderr] 546 | | ); [INFO] [stderr] 547 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/main.rs:549:1 [INFO] [stderr] | [INFO] [stderr] 549 | / fn print_dependency_kind<'a>( [INFO] [stderr] 550 | | kind: Kind, [INFO] [stderr] 551 | | mut deps: Vec<&Node<'a>>, [INFO] [stderr] 552 | | graph: &Graph<'a>, [INFO] [stderr] ... | [INFO] [stderr] 599 | | } [INFO] [stderr] 600 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 03s [INFO] running `"docker" "inspect" "f12b1e3df75cfd239b5ad4a6cf5e173d74bf6db3eb0299cc8c26a194b7b3db98"` [INFO] running `"docker" "rm" "-f" "f12b1e3df75cfd239b5ad4a6cf5e173d74bf6db3eb0299cc8c26a194b7b3db98"` [INFO] [stdout] f12b1e3df75cfd239b5ad4a6cf5e173d74bf6db3eb0299cc8c26a194b7b3db98